Travis Cross [Sat, 8 Mar 2014 00:26:19 +0000 (00:26 +0000)]
Add automake subdir-options for modules
The automake project is apparently changing behavior in their next
major version and warning everyone who relies on subdir-options to add
it explicitly.
According to https://code.google.com/p/webrtc/issues/detail?id=2768 ; The Chrome WebRTC engine reserves payload 98 and 99, IKR? So, to avoid taking a nasty spill down the stairs and subjecting ourselves to further school absences, we'll just start our payload space at 102 when making WebRTC calls.......
Travis Cross [Wed, 5 Mar 2014 21:32:07 +0000 (21:32 +0000)]
Drop null-auth suites from our default TLS cipher list
Previously we disallowed anonymous Diffie-Hellman, but there are other
kinds of null-authentication TLS suites. In particular, disallowing
AECDH is important now that we support elliptic-curve Diffie-Hellman.
Brian West [Wed, 5 Mar 2014 11:15:32 +0000 (05:15 -0600)]
configure: error: could not detect a 64-bit integer type
NetBSD dagonet.omniscient.local 6.1.3 NetBSD 6.1.3 (GENERIC_HZ) #1: Sat Mar 1 19:18:46 EST 2014 met@dagonet.omniscient.local:/data/netbsd/obj/usr/src/sys/arch/i386/compile/GENERIC_HZ i386
Failure due to test programs have "Shared object "libXXX.so.X" not found"
Adding -Wl,-rpath,/usr/pkg/lib to LDFLAGS for NetBSD
Travis Cross [Wed, 5 Mar 2014 02:41:59 +0000 (02:41 +0000)]
Revert conference "tool" misfeature
This was added as part of a mass copyright header update in commit 6e7d5d089. That's obviously not the right way to add features, so
we're reverting this.
If this feature is actually desired, it should be added in its own
commit, properly described in the commit message, and documented.
(The commit added a "tool" flag that could be applied to a conference
participant to mess with that person by disrupting his or her audio.)
Travis Cross [Tue, 4 Mar 2014 01:51:04 +0000 (01:51 +0000)]
Improve channel variable name to srtp_allow_idle_gaps
This was momentarily called force_send_silence_when_idle, but that was
non-obvious as you had to set that value to true to be able to not
send silence when idle. This name describes the purpose much better.
Travis Cross [Mon, 3 Mar 2014 20:03:22 +0000 (20:03 +0000)]
Avoid repeating ourselves in generating silence
We were handling the "send silence but not comfort noise" case in both
silence_stream_file_read and switch_generate_sln_silence. This
changes the former to rely on the latter.
Travis Cross [Mon, 3 Mar 2014 18:33:25 +0000 (18:33 +0000)]
Add force_send_silence_when_idle channel variable
If set to true, this prevents us from overriding the value of
send_silence_when_idle. When that is unset or set to zero and SRTP is
engaged, we typically override the value because many devices can't
handle gaps in the SRTP stream.
This variable is mostly for testing whether particular devices can
handle this behavior. Use at your own risk.
Travis Cross [Mon, 3 Mar 2014 18:26:44 +0000 (18:26 +0000)]
Preserve value of send_silence_when_idle if possible
In commit 55d01d3defed4bfdc74704dbea0da9548a97a979 we set
send_silence_when_idle to -1 rather than 400 when SRTP is engaged.
But this left no way to enable white noise silence when desired.
When SRTP is engaged we can't simply not send RTP because it breaks
too many devices. So we need to prevent send_silence_when_idle from
being unset or being set to zero. This change allows it to be set to
other values so as to feed white noise rather than all zeros into the
codec.
Travis Cross [Mon, 3 Mar 2014 23:21:58 +0000 (23:21 +0000)]
Fix handling of send_silence_when_idle==0 in switch_ivr_sleep
When the channel variable send_silence_when_idle was set to zero,
switch_ivr_sleep was calling SWITCH_IVR_VERIFY_SILENCE_DIVISOR on it
anyway, causing it to be set to 400. The only way to get the behavior
of not sending silence when idle was to unset the variable completely.
This corrects the behavior such that setting the value to zero has the
same effect as leaving it unset.