[#4480] Remove unnecessary EOF here-documents from hammer.py

Started looking into this to see if it fixes the env var in the previous
commit not propagating thorugh sudo. It did not. But the code is much
cleaner this way. Also it uncovered that the preivous approach hid
errors. Because immediately after switching to this, I got an error on
SQL statement: "GRANT ALL PRIVILEGES ON DATABASE keauser TO keadb;"
which is wrong because database and user parameters are swapped. The
parameters were also fixed in this commit.

[#4480] Make hammer.py work on Ubuntu 26.04

- Add 'make' to NETCONF dependencies. It's required to build libyang and sysrepo.
- sudo seems to behave differently. Add explicit PGPASSWORD.

[#4453] Changed map into list

[#4453] formatting

[#4453] Added ChangeLog entry

[#4453] Extended syntaxes

[#4445] Fixed typo

[#4478] fixed more typos

[#4478] added missing issue number

[#4478] fixed typo

[#4478] release changes

[#4472] bump up library versions for 3.1.8 release

[#3636] Add ReplicatingFuzzingIssues subsection to fuzz.dox

[#4160] Fix rpath for kea-msg-compiler

[#4344] Added a changelog entry

[#4344] Close connection once

[#4344] Unregister once

[#4314] Fixed indentation

[#4314] Fixed json

[#4314] Updated doc

[#4367] handle all exceptions

[#3985] Fix version in conf.py for EPUB generation in RTD

[#3144] fixed unit tests related to #3062

[#3144] detect before inactivating

[#4154] Spelling

[#4154] Applied RFC 4578 Errata

[#3970] Added reject of all HTTP or TLS keywords

[#3985] Fix `-git` not appearing in ARM for non-released versions

[#4475] Define constexprs in sflq_allocator.cc

  modified: src/lib/dhcpsrv/sflq_allocator.cc

[#4473] fix Changelog etries

[#4376] Change DDNS Lease Length to TTL in log

[#3448] fixed netconf

[#4447] Fixed missed typos

modified:   src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc

[#4447] Addresses review comments

modified:   changelog_unreleased/4447-shared-flq-allocator-reconcile-sflq-pool-create-and-pick-free-lease-inconsistency
modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.cc
modified:   src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
modified:   src/lib/dhcpsrv/sflq_allocator.cc

[#4447] Removed left joins from pick functions

Left joins are perf killers. Relying on free
leseseX consistency instead.

a/src/bin/admin/tests/mysql_tests.sh.in
    mysql_sflqPickFreeLease6()
    mysql_sflqPickFreeLease6()
    - updated tests

/src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_sflqPickFreeLease6()
    pgsql_sflqPickFreeLease6()
    - updated tests

/src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testSflqLeaseOps4()
    GenericLeaseMgrTest::testSflqLeaseOps6()
    - updated tests

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    - remove left join from SFLQ pick functions

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    - remove left join from SFLQ pick functions

[#4447] Remove checks after rebase

modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4447] Fix update stored procedures

Fix merge mistake which left expiration check in update
stored procedures.

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4447] Do not include expired in SFLQ

/src/bin/admin/tests/mysql_tests.sh.in
    Updated tests:
    mysql_sflqCreateFlqPool4()
    mysql_sflqCreateFlqPool6()
    mysql_sflqInsertLease4()
    mysql_sflqUpdateLease4()
    mysql_sflqInsertLease6()
    mysql_sflqUpdateLease6()

/src/bin/admin/tests/pgsql_tests.sh.in
    Updated tests:
    pgsql_sflqCreateFlqPool4()
    pgsql_sflqCreateFlqPool6()
    pgsql_sflqInsertLease4()
    pgsql_sflqUpdateLease4()
    pgsql_sflqInsertLease6()
    pgsql_sflqUpdateLease6()

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    Updated functions:
    sflqCreateFlqPool4()
    sflqCreateFlqPool6()
    sflqInsertLease4()
    sflqUpdateLease4()
    sflqInsertLease6()
    sflqUpdateLease6()

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    Updated functions:
    sflqCreateFlqPool4()
    sflqCreateFlqPool4()
    sflqCreateFlqPool6()
    sflqInsertLease4()
    sflqUpdateLease4()
    sflqInsertLease6()
    sflqUpdateLease6()

[#4454] addressed review comments

[#4454] remove solaris iface_mgr

[#3448] addressed review

[#3448] Fixed json

[#3448] Removed extra CA refs in examples

[#3448] Moved rbac example

[#3448] Fixed rebase

[#3448] Revert HTTP control socket in DHCPv4

[#3448] Checkpoint

[#3448] Fixed again keactrl tests

[#3448] Fixed doc

[#3448] Many fixes

[#3448] Fixed yang control socket

[#3448] Tentative hammer

[#3448] Fixed keactrl tests

[#3448] Fixed doc build

[#3448] Fixed shellcheck

[#3448] Checkpoint

[#3448] Checkpoint

[#4441] Add missing order by

modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4441] Fixed asan leak

modified:   src/lib/dhcpsrv/sflq_allocator.cc

[#4441] Add tranactions to PostgreSQL lease ops

/src/hooks/dhcp/mysql/mysql_lease_mgr.cc
/src/lib/pgsql/pgsql_connection.h
    PgSqlLeaseMgr::addLeaseCommon()
    PgSqlLeaseMgr::updateLeaseCommon()
    PgSqlLeaseMgr::deleteLeaseCommon()
    - added scoped transactions

[#4441] Add tranactions to MySQL lease ops

/src/hooks/dhcp/mysql/mysql_lease_mgr.cc
/src/lib/mysql/mysql_connection.h
    MySqlLeaseMgr::addLeaseCommon()
    MySqlLeaseMgr::updateLeaseCommon()
    MySqlLeaseMgr::deleteLeaseCommon()
    - added scoped transactions

/src/lib/dhcpsrv/sflq_allocator.cc
    SharedFlqAllocator::sanityChecksSflqAllocator6()
    handle alloctor types correctly

    various nits from review comments

[#4441] Replace row count mechanism in PostgreSQL

    Aligns postresql implementation with mysql implementation.
    Lease op functions now return the leaseX table affected row count.

/src/bin/admin/tests/pgsql_tests.sh.in
    Updated tests

/src/hooks/dhcp/pgsql/pgsql_lease_mgr.*
    PgSqlLeaseMgr::getRowCount() - new conveniece function
    Updated lease op functions and common functions

/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    added row test to insert funcs

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    Updated lease op functions
    deleted FUNCTION sflqFakeRowCount()

[#4441]  A few more comments

    Fixed typos

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/bin/admin/tests/pgsql_tests.sh.in
modified:   src/lib/dhcpsrv/lease_mgr.h
modified:   src/lib/dhcpsrv/sflq_allocator.h

[#4441] Consume results of insert

modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.cc
modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.h

[#4441] Fix row count issue in Mariadb

Mariadb affected row counts from stored procedures are
unreliable. Converted lease op procedures to functions
that return the leaseX table affected row count.

/src/bin/admin/tests/mysql_tests.sh.in
    Change lease op calls to selects, check rows returned

/src/hooks/dhcp/mysql/mysql_lease_mgr.*
    Change lease op SFLQ SQL statement calls to selects
    For update and delete, check row count returned instead of
    affect rows from statement context

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    Convert SFLQ lease op PROCEDURES to FUNCTIONS that
    return leaseX table rows affected count
    Deleted  PROCEDURE sflqFakeRowCount

[#4441] A few more comments

Restored capacity limit to 16M

[#4441] More review comments

/src/hooks/dhcp/mysql/mysql_lease_mgr.cc
/src/hooks/dhcp/mysql/pgsql_lease_mgr.cc
    Use new constants for capacity check

/src/lib/dhcpsrv/sflq_allocator.*
    SharedFlqAllocator::sanityChecksSflqAllocator4(Subnet4Ptr subnet)
    SharedFlqAllocator::sanityChecksSflqAllocator6(Subnet6Ptr subnet)
    - new functions

/src/lib/dhcpsrv/srv_config.cc
    use SharedFlqAllocator::sanityChecksSflqAllocator*

[#4441] Added sanity check

/src/bin/dhcp4/json_config_parser.cc
/src/bin/dhcp6/json_config_parser.cc
    Add call to cfg->sanityChecksSflqAllocator();

/src/lib/dhcpsrv/cb_ctl_dhcp4.cc
/src/lib/dhcpsrv/cb_ctl_dhcp6.cc
    Add call to external_cfg->sanityChecksSflqAllocator();

/src/lib/dhcpsrv/srv_config.*
    SrvConfig::sanityChecksSflqAllocator() - new function

[#4441] Addressed initial review comments

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/bin/admin/tests/pgsql_tests.sh.in
modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.cc
modified:   src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
modified:   src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
modified:   src/hooks/dhcp/pgsql/tests/pgsql_lease_mgr_unittest.cc
modified:   src/lib/dhcpsrv/parsers/shared_network_parser.cc
modified:   src/lib/dhcpsrv/sflq_allocator.cc
modified:   src/lib/dhcpsrv/subnet.cc
modified:   src/lib/dhcpsrv/tests/sflq_allocator_unittest.cc
modified:   src/lib/dhcpsrv/tests/shared_network_unittest.cc
modified:   src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
modified:   src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.h
modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4441] Fix mysql loop limit error

Also whitespace clean up

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.cc
modified:   src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
modified:   src/lib/dhcpsrv/sflq_allocation_state.h
modified:   src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in

[#4441] Clean up and new UTs

/src/lib/dhcpsrv/sflq_allocation_state.h
/src/lib/dhcpsrv/sflq_allocator.h
     clean up

/src/lib/dhcpsrv/tests/shared_network_unittest.cc
    TEST(SharedNetwork4Test, sflqGetPreferredSubnet)
    TEST(SharedNetwork6Test, sflqGetPreferredSubnet)
    - new tests

[#4441] Added capacity checks

Both MySQL and PostgreSQL are working end to end!

/src/hooks/dhcp/mysql/mysql_lb_messages.mes
    Added capacity to pool create logs

/src/hooks/dhcp/mysql/mysql_lease_mgr.cc
    MySqlLeaseMgr::sflqCreateFlqPool4()
    MySqlLeaseMgr::sflqCreateFlqPool6()
    - Added capacity to pool create log added 16M pool capacity guard

/src/hooks/dhcp/pgsql/pgsql_lb_messages.mes
    Added capacity to pool create logs

/src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
    PgSqlLeaseMgr::sflqCreateFlqPool4()
    PgSqlLeaseMgr::sflqCreateFlqPool6()
    - Added capacity to pool create log added 16M pool capacity guard

/src/lib/dhcpsrv/subnet.cc
    Subnet6::createAllocators() - fixed allocator type check

[#4441] PostgreSQL add where params, row logic

Catch up with MySQL changes

/src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_sflqUpdateLease4()
    pgsql_sflqUpdateLease6()
    - add where parameters

/src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
    SFLQ_UPDATE_LEASE4
    SFLQ_UPDATE_LEASE6
    - add where parameters

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    sflqUpdateLease4
    sflqUpdateLease6
    - make logic consistent with PostgreSQL

/src/share/database/scripts/mysql/dhcpdb_drop.mysql
    Added sflqFakeRowCount

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
    FUNCTION sflqFakeRowCount() - new function

    sflqUpdateLease4()
    sflqUpdateLease6()
    - add where parameters
    - add fake row logic

    sflqDeleteLease4()
    sflqDeleteLease6()
    - add fake row logic

/src/share/database/scripts/pgsql/dhcpdb_drop.pgsql
    Added sflqFakeRowCount

[#4441] cfg parsing, allocation state, Mysql bugs

Parsing changes so shared-flq allocator can be configured

Added SubnetSflqAllocationState class

MySQL changes:
Added transacations back to lease ops SQL proceduresr
changes in one session were not being committed, so
invisible to others.

Added omitted where parameters to sflqUpdateLease*
Added sflqFakeRowCount() to set affected row count in
lease op procedures

new file:   src/lib/dhcpsrv/sflq_allocation_state.cc
new file:   src/lib/dhcpsrv/sflq_allocation_state.h

/src/bin/admin/tests/mysql_tests.sh.in
    mysql_sflqUpdateLease4()
    mysql_sflqUpdateLease6()
    - added where params:

/src/hooks/dhcp/mysql/mysql_lease_mgr.cc
     MySqlLeaseMgr::SFLQ_UPDATE_LEASE4
     MySqlLeaseMgr::SFLQ_UPDATE_LEASE6
    - added where params:

/src/lib/dhcpsrv/meson.build
    Add sflq_allcoation_state.*

/src/lib/dhcpsrv/parsers/base_network_parser.cc
    BaseNetworkParser::parseAllocatorParams()
    BaseNetworkParser::parsePdAllocatorParams()
    - allow "shared-flg"

/src/lib/dhcpsrv/parsers/shared_network_parser.cc
    SharedNetwork6Parser::parse()
    - disallow shared-flq for NA pools

/src/lib/dhcpsrv/sflq_allocator.*
    SharedFlqAllocator::pickAddressInternal()
    - set last allocated time in subnet allocator state
    SharedFlqAllocator::getSubnetState() - new function

/src/lib/dhcpsrv/subnet.cc
    Subnet4::createAllocators()
    Subnet6::createAllocators()
    - support "shared-flq"

/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
    TEST_F(ParseConfigTest, invalidSubnetAllocator4)
    TEST_F(ParseConfigTest, invalidSubnetAllocator6)
    - updated expected error msg

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    sflqFakeRowCount()
    - new procedure

    sflqInsertLease4
    sflqInsertLease6
    - add back transaction

    sflqUpdateLease4
    sflqUpdateLease6
    - add back transaction
    - preserve affected row count
    - add where params

    sflqDeleteLease4
    sflqDeleteLease6
    - add back transaction
    - preserve affected row count

[#4441] Added alt statements and UTs

MySql and PostgreSQL lease mgrs now call
alteranate SQL statements when lease is
under SFLQ jurisdiction

/src/hooks/dhcp/mysql/mysql_lease_mgr.*
    Added alternate statements:
    {MySqlLeaseMgr::SFLQ_INSERT_LEASE4,
    {MySqlLeaseMgr::SFLQ_UPDATE_LEASE4,
    {MySqlLeaseMgr::SFLQ_DELETE_LEASE4,
    {MySqlLeaseMgr::SFLQ_INSERT_LEASE6,
    {MySqlLeaseMgr::SFLQ_UPDATE_LEASE6,
    {MySqlLeaseMgr::SFLQ_DELETE_LEASE6,

    Modified to call alt statements:
    MySqlLeaseMgr::addLease*()
    MySqlLeaseMgr::udpateLease*()
    MySqlLeaseMgr::deleteLease*()

    MySqlLeaseMgr::sflqPickFreeLease4() fix output bind

/src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
    Renamed testSFLQ4() to testSflqCreateAndPick4()
    Renamed testSFLQ6() to testSflqCreateAndPick6()

    TEST_F(MySqlLeaseMgrTest, testSflqLeaseOps4 - new test
    TEST_F(MySqlLeaseMgrTest, testSflqLeaseOps6 - new test

/src/hooks/dhcp/pgsql/pgsql_lease_mgr.*
    Added alternate statements:
        SFLQ_INSERT_LEASE4
        SFLQ_UPDATE_LEASE4
        SLQ_DELETE_LEASE4
        SFLQ_INSERT_LEASE6
        SFLQ_UPDATE_LEASE6
        SFLQ_DELETE_LEASE6

    Modified to call alt statements:
    PgSqlLeaseMgr::addLease*()
    PgSqlLeaseMgr::udpateLease*()
    PgSqlLeaseMgr::deleteLease*()

/src/hooks/dhcp/pgsql/tests/pgsql_lease_mgr_unittest.cc
    Renamed testSFLQ4() to testSflqCreateAndPick4()
    Renamed testSFLQ6() to testSflqCreateAndPick6()

    TEST_F(PgSqlLeaseMgrTest, testSflqLeaseOps4 - new test
    TEST_F(PgSqlLeaseMgrTest, testSflqLeaseOps6 - new test

/src/lib/dhcpsrv/lease_mgr.*
    bool LeaseMgr::useSharedFlqStatement(*) - new functions

/src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.*
    Renamed testSFLQ4() to testSflqCreateAndPick4()
    Renamed testSFLQ6() to testSflqCreateAndPick6()

    testSflqLeaseOps4() - new test
    testSflqLeaseOps6()- new test

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    Fixed null returns in sflqPickFreeLease*

[#4381] Update release_checklist.md

[#4381] Update release_checklist.md

[#4212] added more UTs

[#4212] Improved readability

[#4212] Ported Razvan's test/bench

[#4212] Checkpoint: xoy extra UTs

[#4258] Added lru UTs

[#4258] Experiment with relocate

[#4448] added ChangeLog entry

[#4448] fix ha listener shutdown under load

[#4446] Increase timeout of mysql_tests.sh

[#4425] Fixed typos

modified:   src/lib/dhcpsrv/sflq_allocator.h
modified:   src/lib/dhcpsrv/testutils/sflqtest_lease_mgr.h

[#4425] Addressed more review comments

/src/bin/admin/tests/pgsql_tests.sh.in
     Minor nits

/src/lib/dhcpsrv/tests/sflq_allocator_unittest.cc
    Replace contains with count

/src/lib/dhcpsrv/testutils/sflqtest_lease_mgr.h
    Fixed override warnings

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    inetToBytea(inet_address inet) - handle v6 addresses
    with empty first hextet

[#4425] Fixed v4-mapped address issue in inetToBytea

/src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_inetToBytea() - new test

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    Handle special case first octect zero

[#4425] Addressed review comments

/src/bin/admin/tests/mysql_tests.sh.in
    mysql_sflqCreateFlqPool4Invalid() - new test
    mysql_sflqPickFreeLease4() - added test cases
    mysql_sflqCreateFlqPool6Invalid() - new test
    mysql_sflqPickFreeLease6() - added test cases

/src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_sflqCreateFlqPool4Invalid() - new test
    pgsql_sflqPickFreeLease4() - added test cases
    pgsql_sflqCreateFlqPool6Invalid() - new test
    pgsql_sflqPickFreeLease6() - added test cases

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    Added parameter validation and fixed overruns in
    create pool functions

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in
    Added parameter validation and fixed overruns in
    create pool functions
    Fixed a bug in inetToBytea on address with an empty first octet

And various nits.

[#4425] Catch overrun in MySql sflqCreateFlqPool4

modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in

[#4425] Improved MySQL setLoopLimit

Sets a cap of 1000, and sets the DB's session
variable limit if it is zero.

[#4425] Implement SharedFlqAllocator class

modified:   src/lib/dhcpsrv/cfg_subnets4.cc
modified:   src/lib/dhcpsrv/cfg_subnets6.cc
modified:   src/lib/dhcpsrv/iterative_allocator.h
modified:   src/lib/dhcpsrv/meson.build
new file:   src/lib/dhcpsrv/sflq_allocator.cc
new file:   src/lib/dhcpsrv/sflq_allocator.h
modified:   src/lib/dhcpsrv/tests/meson.build
new file:   src/lib/dhcpsrv/tests/sflq_allocator_unittest.cc
modified:   src/lib/dhcpsrv/testutils/meson.build
new file:   src/lib/dhcpsrv/testutils/sflqtest_lease_mgr.cc
new file:   src/lib/dhcpsrv/testutils/sflqtest_lease_mgr.h

[#4417] Addressed review comments

Applied batch to turn PostgreSQL procedures into functions
for PosgreSQL 10 compatibility

Several smaller typos and mistakes.

modified:
src/bin/admin/tests/pgsql_tests.sh.in
src/hooks/dhcp/mysql/mysql_lb_messages.cc
src/hooks/dhcp/mysql/mysql_lb_messages.mes
src/hooks/dhcp/mysql/mysql_lease_mgr.cc
src/hooks/dhcp/mysql/mysql_lease_mgr.h
src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
src/hooks/dhcp/pgsql/pgsql_lb_messages.cc
src/hooks/dhcp/pgsql/pgsql_lb_messages.mes
src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
src/hooks/dhcp/pgsql/pgsql_lease_mgr.h
src/lib/dhcpsrv/lease_mgr.h
src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.h
src/lib/mysql/mysql_binding.h
src/share/database/scripts/mysql/dhcpdb_create.mysql
src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
src/share/database/scripts/pgsql/dhcpdb_create.pgsql
src/share/database/scripts/pgsql/dhcpdb_drop.pgsql
src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4417] Fix missing log argument

modified:   src/hooks/dhcp/mysql/mysql_lease_mgr.cc
modified:   src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc

[#4417] Add log messages

modified:   ../mysql/mysql_lb_messages.cc
modified:   ../mysql/mysql_lb_messages.h
modified:   ../mysql/mysql_lb_messages.mes
modified:   ../mysql/mysql_lease_mgr.cc
modified:   pgsql_lb_messages.cc
modified:   pgsql_lb_messages.h
modified:   pgsql_lb_messages.mes
modified:   pgsql_lease_mgr.cc

[#4417] SFLQ Create/Pick added to LeaseMgrs

Added new SQL statements and functions to
create and pick from SFLQ pools to
MySQL and PostgreSQL lease managers

/src/hooks/dhcp/pgsql/pgsql_lease_mgr.cc
    New SQL statements:
    SFLQ_CREATE_POOL4
    SFLQ_PICK_FREE_LEASE4
    SFLQ_CREATE_POOL6
    SFLQ_PICK_FREE_LEASE6

    New functions:
    PgSqlLeaseMgr::sflqCreateFlqPool4()
    PgSqlLeaseMgr::sflqPickFreeLease4()
    PgSqlLeaseMgr::sflqCreateFlqPool6()
    PgSqlLeaseMgr::sflqPickFreeLease6()

/src/hooks/dhcp/pgsql/tests/pgsql_lease_mgr_unittest.cc
    New tests:
    TEST_F(PgSqlLeaseMgrTest, testSFLQ4)
    TEST_F(PgSqlLeaseMgrTest, testSFLQ6)

/src/hooks/dhcp/mysql/mysql_lease_mgr.*
    New SQL statements:
    MySqlLeaseMgr::SFLQ_CREATE_FLQ_POOL4
    MySqlLeaseMgr::SFLQ_PICK_FREE_LEASE4
    MySqlLeaseMgr::SFLQ_CREATE_FLQ_POOL6
    MySqlLeaseMgr::SFLQ_PICK_FREE_LEASE6

    New functions:
    MySqlLeaseMgr::sflqCreateFlqPool4()
    MySqlLeaseMgr::sflqPickFreeLease4()
    MySqlLeaseMgr::sflqCreateFlqPool6()
    MySqlLeaseMgr::sflqPickFreeLease6()

/src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
    New tests:
    TEST_F(MySqlLeaseMgrTest, testSFLQ4)
    TEST_F(MySqlLeaseMgrTest, testSFLQ6)

/src/lib/dhcpsrv/lease_mgr.*
    New Functions:
    LeaseMgr::sflqCreateFlqPool4()
    LeaseMgr::sflqPickFreeLease4()
    LeaseMgr::sflqCreateFlqPool6()
    LeaseMgr::sflqPickFreeLease6()

/src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.*
    New tests:
    GenericLeaseMgrTest::testSFLQ4()
    GenericLeaseMgrTest::testSFLQ6()

[#4405] Addressed review comments

    Fixed typos

modified:   src/bin/admin/tests/mysql_tests.sh.in
modified:   src/bin/admin/tests/pgsql_tests.sh.in
modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[#4405] Removed transactions

Removed transactions from add/update/delete procedures.
They have a big impact performance and don't make much sense.

modified:   src/share/database/scripts/mysql/dhcpdb_create.mysql
modified:   src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
modified:   src/share/database/scripts/pgsql/dhcpdb_create.pgsql
modified:   src/share/database/scripts/pgsql/upgrade_032_to_033.sh.in

[4405] SFLQ lease insert,update,delete procedures

Added stored procedures and UTs for MySql
and PostgreSQL for lease insert, update, and delete

/src/share/database/scripts/mysql/dhcpdb_create.mysql
/src/share/database/scripts/mysql/dhcpdb_drop.mysql
/src/share/database/scripts/mysql/upgrade_033_to_034.sh.in
    New stored procedures:
    sflqInsertLease4
    sflqUpdateLease4
    sflqDeleteLease4
    sflqInsertLease6
    sflqUpdateLease6

/src/share/database/scripts/pgsql/dhcpdb_create.pgsql
/src/share/database/scripts/pgsql/dhcpdb_drop.pgsql
/src/share/database/scripts/mysql/upgrade_032_to_033.sh.in
    New stored procedures:
    sflqInsertLease4
    sflqUpdateLease4
    sflqDeleteLease4
    sflqInsertLease6
    sflqUpdateLease6

/src/bin/admin/tests/mysql_tests.sh.in
    New tests:
    mysql_sflqInsertLease4
    mysql_sflqUpdateLease4
    mysql_sflqDeleteLease4
    mysql_sflqInsertLease6
    mysql_sflqUpdateLease6
    mysql_sflqDeleteLease6

/src/bin/admin/tests/pgsql_tests.sh.in
    New tests:
    pgsql_sflqInsertLease4
    pgsql_sflqUpdateLease4
    pgsql_sflqDeleteLease4
    pgsql_sflqInsertLease6
    pgsql_sflqUpdateLease6
    pgsql_sflqDeleteLease6