From 6b447602897ffb1248ab0108f7b511275187bbf0 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Wed, 15 Jul 2026 12:58:02 +0200
Subject: [PATCH] rpc_server: Simplify dns_split_node_name()

Use talloc_asprintf_addsep()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jul 30 14:14:44 UTC 2026 on atb-devel-224
---
 source4/rpc_server/dnsserver/dnsdata.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index 6ffca196861..5d39234a6cc 100644
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -269,14 +269,12 @@ char *dns_split_node_name(TALLOC_CTX *tmp_ctx, const char *node_name, const char
 			if (match == ncount) {
 				prefix = talloc_strdup(tmp_ctx, zone_name);
 			} else {
-				prefix = talloc_strdup(tmp_ctx, nlist[0]);
-				if (prefix != NULL) {
-					for (i=1; i<ncount-match; i++) {
-						prefix = talloc_asprintf_append(prefix, ".%s", nlist[i]);
-						if (prefix == NULL) {
-							break;
-						}
-					}
+				prefix = talloc_strdup(tmp_ctx, "");
+				for (i = 0; i < ncount - match; i++) {
+					talloc_asprintf_addsep(&prefix,
+							       ".",
+							       "%s",
+							       nlist[i]);
 				}
 			}
 		}
-- 
2.47.3