From 4a113ad752ca8ea1cd4dccefdb17d0015c4e0467 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 27 May 2026 10:10:40 +0200 Subject: [PATCH] 6.6-stable patches added patches: smb-client-reject-userspace-cifs.spnego-descriptions.patch --- queue-6.6/series | 1 + ...t-userspace-cifs.spnego-descriptions.patch | 66 +++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 queue-6.6/smb-client-reject-userspace-cifs.spnego-descriptions.patch diff --git a/queue-6.6/series b/queue-6.6/series index 377ae91b44..dab275f248 100644 --- a/queue-6.6/series +++ b/queue-6.6/series @@ -13,3 +13,4 @@ ksmbd-add-durable-scavenger-timer.patch ksmbd-validate-owner-of-durable-handle-on-reconnect.patch ksmbd-close-durable-scavenger-races-against-m_fp_lis.patch af_unix-give-up-gc-if-msg_peek-intervened.patch +smb-client-reject-userspace-cifs.spnego-descriptions.patch diff --git a/queue-6.6/smb-client-reject-userspace-cifs.spnego-descriptions.patch b/queue-6.6/smb-client-reject-userspace-cifs.spnego-descriptions.patch new file mode 100644 index 0000000000..f9a7bd4d82 --- /dev/null +++ b/queue-6.6/smb-client-reject-userspace-cifs.spnego-descriptions.patch @@ -0,0 +1,66 @@ +From 3da1fdf4efbc490041eb4f836bf596201203f8f2 Mon Sep 17 00:00:00 2001 +From: Asim Viladi Oglu Manizada +Date: Sat, 16 May 2026 21:15:39 +0000 +Subject: smb: client: reject userspace cifs.spnego descriptions + +From: Asim Viladi Oglu Manizada + +commit 3da1fdf4efbc490041eb4f836bf596201203f8f2 upstream. + +cifs.spnego key descriptions contain authority-bearing fields such as +pid, uid, creduid, and upcall_target that cifs.upcall treats as +kernel-originating inputs. However, userspace can also create keys of +this type through request_key(2) or add_key(2), allowing those fields to +be supplied without CIFS origin. + +Only accept cifs.spnego descriptions while CIFS is using its private +spnego_cred to request the key. + +Fixes: f1d662a7d5e5 ("[CIFS] Add upcall files for cifs to use spnego/kerberos") +Assisted-by: avom-custom-harness:gpt-5.5-qwen3.6-mod-mix +Reviewed-by: David Howells +Signed-off-by: Asim Viladi Oglu Manizada +Signed-off-by: Steve French +Signed-off-by: Greg Kroah-Hartman +--- + fs/smb/client/cifs_spnego.c | 16 ++++++++++++++++ + 1 file changed, 16 insertions(+) + +--- a/fs/smb/client/cifs_spnego.c ++++ b/fs/smb/client/cifs_spnego.c +@@ -8,6 +8,7 @@ + */ + + #include ++#include + #include + #include + #include +@@ -46,12 +47,27 @@ cifs_spnego_key_destroy(struct key *key) + kfree(key->payload.data[0]); + } + ++static int ++cifs_spnego_key_vet_description(const char *description) ++{ ++ /* ++ * cifs.spnego descriptions are authority-bearing inputs to cifs.upcall. ++ * They are only valid when produced by CIFS while using the private ++ * spnego_cred installed below. Do not let userspace create this type ++ * of key through request_key(2)/add_key(2), since the helper treats ++ * pid/uid/creduid/upcall_target as kernel-originating fields. ++ */ ++ if (current_cred() != spnego_cred) ++ return -EPERM; ++ return 0; ++} + + /* + * keytype for CIFS spnego keys + */ + struct key_type cifs_spnego_key_type = { + .name = "cifs.spnego", ++ .vet_description = cifs_spnego_key_vet_description, + .instantiate = cifs_spnego_key_instantiate, + .destroy = cifs_spnego_key_destroy, + .describe = user_describe, -- 2.47.3