]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ext4: remove ctime/mtime update from ext4_alloc_file_blocks()
authorZhang Yi <yi.zhang@huawei.com>
Fri, 27 Mar 2026 10:29:37 +0000 (18:29 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 10 Apr 2026 01:57:52 +0000 (21:57 -0400)
The ctime and mtime update is already handled by file_modified() in
ext4_fallocate(), the caller of ext4_alloc_file_blocks(). So remove the
redundant calls to inode_set_ctime_current() and inode_set_mtime_to_ts()
in ext4_alloc_file_blocks().

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260327102939.1095257-12-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 053aeb9f0e74e77ef5636dddf4492065c8dfab44..4e7e798a5e494621f2ebc03cf1901b2fca0368f0 100644 (file)
@@ -4652,13 +4652,10 @@ retry:
                 */
                retries = 0;
                epos = EXT4_LBLK_TO_B(inode, map.m_lblk + ret);
-               inode_set_ctime_current(inode);
                if (new_size) {
                        if (epos > new_size)
                                epos = new_size;
-                       if (ext4_update_inode_size(inode, epos) & 0x1)
-                               inode_set_mtime_to_ts(inode,
-                                                     inode_get_ctime(inode));
+                       ext4_update_inode_size(inode, epos);
                        if (epos > old_size)
                                pagecache_isize_extended(inode, old_size, epos);
                }