]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86: Move delayed work on system_dfl_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Fri, 15 May 2026 14:58:51 +0000 (16:58 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 28 May 2026 11:44:43 +0000 (14:44 +0300)
Currently the code enqueue work items using {queue|mod}_delayed_work(),
using system_wq, which will be deprecated soon and replaced by
system_percpu_wq.

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")

The function(s) mentioned earlier, end up calling __queue_delayed_work(),
which set a global timer that could fire anywhere, enqueuing the work
where the timer fired.

Unbound works could benefit from scheduler task placement, to optimize
performance and power consumption.

Since the workqueue work doesn't rely on per-cpu variables, there is no
obvious reason that justify the use of a per-cpu workqueue. So change
system_wq with system_dfl_wq so that the work may benefit from
scheduler task placement.

Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20260515145851.318787-1-marco.crivellari@suse.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/hp/hp-wmi.c

index f63bc00d9a9b3ee347e4dfc4846219745c0e8b38..48292cc02ee266b88d9ed0b85133227fc89b7552 100644 (file)
@@ -2396,7 +2396,7 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hwmon_priv *priv)
                ret = hp_wmi_fan_speed_max_set(1);
                if (ret < 0)
                        return ret;
-               mod_delayed_work(system_wq, &priv->keep_alive_dwork,
+               mod_delayed_work(system_dfl_wq, &priv->keep_alive_dwork,
                                 secs_to_jiffies(KEEP_ALIVE_DELAY_SECS));
                return 0;
        case PWM_MODE_MANUAL:
@@ -2405,7 +2405,7 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hwmon_priv *priv)
                ret = hp_wmi_fan_speed_set(priv, pwm_to_rpm(priv->pwm, priv));
                if (ret < 0)
                        return ret;
-               mod_delayed_work(system_wq, &priv->keep_alive_dwork,
+               mod_delayed_work(system_dfl_wq, &priv->keep_alive_dwork,
                                 secs_to_jiffies(KEEP_ALIVE_DELAY_SECS));
                return 0;
        case PWM_MODE_AUTO: