]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: rk808: fix OF node reference imbalance
authorJohan Hovold <johan@kernel.org>
Wed, 8 Apr 2026 07:30:50 +0000 (09:30 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 9 Apr 2026 19:19:31 +0000 (20:19 +0100)
The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 647e57351f8e ("regulator: rk808: reduce 'struct rk808' usage")
Cc: stable@vger.kernel.org # 6.2
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260408073055.5183-3-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/rk808-regulator.c

index e66408f23bb64cd77a385fc2daddd160b7c5e668..1e956153427e54c016934132f8c22ae4c3000c20 100644 (file)
@@ -2114,8 +2114,7 @@ static int rk808_regulator_probe(struct platform_device *pdev)
        struct regmap *regmap;
        int ret, i, nregulators;
 
-       pdev->dev.of_node = pdev->dev.parent->of_node;
-       pdev->dev.of_node_reused = true;
+       device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
 
        regmap = dev_get_regmap(pdev->dev.parent, NULL);
        if (!regmap)