fs: efs: remove unneeded debug prints

The current code uses debug prints conditionally compiled with #ifdef
DEBUG.  However, that code, when compiled, causes compiler errors due to
incompatible formatters and undefined variables, notably:

fs/efs/file.c: In function `efs_get_block':
fs/efs/file.c:26:35: error: `block' undeclared (first use in this
function); did you mean `iblock'?
  26 |                         __func__, block, inode->i_blocks, inode->i_size);
     |                                   ^~~~~

and:

fs/efs/file.c: In function `efs_bmap':
./include/linux/kern_levels.h:5:25: error: format `%ld' expects
argument of type `long int', but argument 4 has type `blkcnt_t' {aka
`long long unsigned int'} [-Werror=format=]
   5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
     |                         ^~~~~~

which also extends to the other formatters.  As this part of the code has
been dead for just about 14 years now, it has not been modernized to stay
compatible with the most recent gcc compilers.  Fix these issues by
removing the debug prints.

Link: https://lore.kernel.org/20260605035251.89305-2-m32285159@gmail.com
Fixes: f403d1dbac6d ("fs/efs: add pr_fmt / use __func__")
Signed-off-by: Maxwell Doose <m32285159@gmail.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Christian Brauner <brauner@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/fs/efs/file.c b/fs/efs/file.c
index 9e641da6fab2760f351e0c290cc880847fe349de..9153dfe79bbcc9ec90e36d03f414e459382132bc 100644 (file)
--- a/fs/efs/file.c
+++ b/fs/efs/file.c
@@ -18,16 +18,9 @@ int efs_get_block(struct inode *inode, sector_t iblock,
 
        if (create)
                return error;
-       if (iblock >= inode->i_blocks) {
-#ifdef DEBUG
-               /*
-                * i have no idea why this happens as often as it does
-                */
-               pr_warn("%s(): block %d >= %ld (filesize %ld)\n",
-                       __func__, block, inode->i_blocks, inode->i_size);
-#endif
+       if (iblock >= inode->i_blocks)
                return 0;
-       }
+
        phys = efs_map_block(inode, iblock);
        if (phys)
                map_bh(bh_result, inode->i_sb, phys);
@@ -42,16 +35,8 @@ int efs_bmap(struct inode *inode, efs_block_t block) {
        }
 
        /* are we about to read past the end of a file ? */
-       if (!(block < inode->i_blocks)) {
-#ifdef DEBUG
-               /*
-                * i have no idea why this happens as often as it does
-                */
-               pr_warn("%s(): block %d >= %ld (filesize %ld)\n",
-                       __func__, block, inode->i_blocks, inode->i_size);
-#endif
+       if (!(block < inode->i_blocks))
                return 0;
-       }
 
        return efs_map_block(inode, block);
 }