]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
counter: ftm-quaddec: use devm_mutex_init()
authorStepan Ionichev <sozdayvek@gmail.com>
Sat, 23 May 2026 18:43:51 +0000 (23:43 +0500)
committerWilliam Breathitt Gray <wbg@kernel.org>
Wed, 27 May 2026 22:12:18 +0000 (07:12 +0900)
ftm_quaddec_probe() calls mutex_init() but neither the cleanup
action nor a remove callback issues a matching mutex_destroy(),
so the lock debug state is leaked on driver unbind.

Switch to devm_mutex_init() so the mutex is torn down in the same
devm scope it was set up in.

Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Link: https://lore.kernel.org/r/20260523184351.7567-1-sozdayvek@gmail.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
drivers/counter/ftm-quaddec.c

index c47741292ae1112d4300f9aa41534a423aad56bf..8455f16d62cb789c3deebb958afd2fc31deed37a 100644 (file)
@@ -292,7 +292,9 @@ static int ftm_quaddec_probe(struct platform_device *pdev)
        counter->signals = ftm_quaddec_signals;
        counter->num_signals = ARRAY_SIZE(ftm_quaddec_signals);
 
-       mutex_init(&ftm->ftm_quaddec_mutex);
+       ret = devm_mutex_init(&pdev->dev, &ftm->ftm_quaddec_mutex);
+       if (ret)
+               return ret;
 
        ftm_quaddec_init(ftm);