]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
xprtrdma: Remove tautological I2 assertion in rpcrdma_reply_put
authorChuck Lever <chuck.lever@oracle.com>
Mon, 1 Jun 2026 17:54:13 +0000 (13:54 -0400)
committerAnna Schumaker <anna.schumaker@hammerspace.com>
Mon, 8 Jun 2026 14:21:56 +0000 (10:21 -0400)
rpcrdma_reply_put() sets req->rl_reply to NULL when it is
non-NULL, and skips the block when it is already NULL.  The
WARN_ON_ONCE(req->rl_reply) that follows can never fire
because both paths leave rl_reply NULL.

Remove the dead assertion and its comment.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@hammerspace.com>
net/sunrpc/xprtrdma/verbs.c

index da2c6fa44154e20e15e4061c263b369e84dc96de..92c691d2521f0c16347355e2655a8cae56e7ff81 100644 (file)
@@ -1259,10 +1259,6 @@ void rpcrdma_reply_put(struct rpcrdma_buffer *buffers, struct rpcrdma_req *req)
                req->rl_reply = NULL;
                rpcrdma_rep_put(buffers, rep);
        }
-       /* I2: rl_reply NULL after the put closes the
-        * 'rep on rb_free_reps still referenced by req' window.
-        */
-       WARN_ON_ONCE(req->rl_reply);
 }
 
 /**