]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: stop printing condition result in assertion failure messages
authorFilipe Manana <fdmanana@suse.com>
Thu, 19 Feb 2026 15:37:59 +0000 (15:37 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 7 Apr 2026 16:55:58 +0000 (18:55 +0200)
It's useless to print the result of the condition, it's always 0 if the
assertion is triggered, so it doesn't provide any useful information.

Examples:

   assertion failed: cb->bbio.bio.bi_iter.bi_size == disk_num_bytes :: 0, in inode.c:9991
   assertion failed: folio_test_writeback(folio) :: 0, in subpage.c:476

So stop printing that, it's always ":: 0" for any assertion triggered
(except for conditions that are just an identifier).

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/messages.h

index c8e92efce4058e5f6213269dfe1a4360cbe7c785..556d4e79cde60a58695dcdd9dba50b256d7ce914 100644 (file)
@@ -144,11 +144,11 @@ do {                                                                              \
        verify_assert_printk_format("check the format string" args);            \
        if (!likely(cond)) {                                                    \
                if (("" __FIRST_ARG(args) [0]) == 0) {                          \
-                       pr_err("assertion failed: %s :: %ld, in %s:%d\n",       \
-                               #cond, (long)(cond), __FILE__, __LINE__);       \
+                       pr_err("assertion failed: %s, in %s:%d\n",              \
+                               #cond, __FILE__, __LINE__);                     \
                } else {                                                        \
-                       pr_err("assertion failed: %s :: %ld, in %s:%d (" __FIRST_ARG(args) ")\n", \
-                               #cond, (long)(cond), __FILE__, __LINE__ __REST_ARGS(args)); \
+                       pr_err("assertion failed: %s, in %s:%d (" __FIRST_ARG(args) ")\n", \
+                               #cond, __FILE__, __LINE__ __REST_ARGS(args));   \
                }                                                               \
                BUG();                                                          \
        }                                                                       \