]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: tegra194: Use DWC IP core version
authorManikanta Maddireddy <mmaddireddy@nvidia.com>
Tue, 24 Mar 2026 19:07:52 +0000 (00:37 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 8 Apr 2026 22:00:23 +0000 (17:00 -0500)
Tegra194 PCIe driver used custom version numbers to detect Tegra194 and
Tegra234 IPs. With version detect logic added, version check results in
mismatch warnings:

  tegra194-pcie 14100000.pcie: Versions don't match (0000562a != 3536322a)

Use HW version numbers which match to PORT_LOGIC.PCIE_VERSION_OFF in
Tegra194 driver to avoid these kernel warnings.

Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
Link: https://patch.msgid.link/20260324190755.1094879-12-mmaddireddy@nvidia.com
drivers/pci/controller/dwc/pcie-designware.h
drivers/pci/controller/dwc/pcie-tegra194.c

index ae6389dd9caa5c27690f998d58729130ea863984..82946bf78b212255b86021c1bf3094088491d332 100644 (file)
 #define DW_PCIE_VER_470A               0x3437302a
 #define DW_PCIE_VER_480A               0x3438302a
 #define DW_PCIE_VER_490A               0x3439302a
+#define DW_PCIE_VER_500A               0x3530302a
 #define DW_PCIE_VER_520A               0x3532302a
 #define DW_PCIE_VER_540A               0x3534302a
+#define DW_PCIE_VER_562A               0x3536322a
 
 #define __dw_pcie_ver_cmp(_pci, _ver, _op) \
        ((_pci)->version _op DW_PCIE_VER_ ## _ver)
index 3527a4e82bac8368df3bbfcab486fc6751556317..688da5a73d02ef009fb7e0633018f9220f767559 100644 (file)
@@ -35,8 +35,8 @@
 #include <soc/tegra/bpmp-abi.h>
 #include "../../pci.h"
 
-#define TEGRA194_DWC_IP_VER                    0x490A
-#define TEGRA234_DWC_IP_VER                    0x562A
+#define TEGRA194_DWC_IP_VER                    DW_PCIE_VER_500A
+#define TEGRA234_DWC_IP_VER                    DW_PCIE_VER_562A
 
 #define APPL_PINMUX                            0x0
 #define APPL_PINMUX_PEX_RST                    BIT(0)