[3.15] gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo() (GH-15167...

Co-authored-by: Daniele Nicolodi <daniele@grinta.net>

diff --git a/Doc/whatsnew/3.15.rst b/Doc/whatsnew/3.15.rst
index bad9e2d8dff37f66ad10414c97fc66b3659e1731..ae75d14a3088ba90c87fa828ec148602a43bd31c 100644 (file)
--- a/Doc/whatsnew/3.15.rst
+++ b/Doc/whatsnew/3.15.rst
@@ -1541,6 +1541,9 @@ tarfile
   now replace slashes with backslashes in symlink targets on Windows to prevent
   creation of corrupted links.
   (Contributed by Christoph Walcher in :gh:`57911`.)
+* :func:`~tarfile.TarFile.gettarinfo` now replaces backslashes with slashes in
+  symlink targets on Windows to conform to the tar format standard. (Contributed
+  by Daniele Nicolodi in :gh:`151669`.)
 
 
 threading

diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index 8c058357f114ad76386a1a96f6cad593e22974f7..fe28ea68cfd1322e26ca41d774104ead24dcd186 100644 (file)
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -2275,7 +2275,7 @@ class TarFile(object):
             type = FIFOTYPE
         elif stat.S_ISLNK(stmd):
             type = SYMTYPE
-            linkname = os.readlink(name)
+            linkname = os.readlink(name).replace(os.sep, "/")
         elif stat.S_ISCHR(stmd):
             type = CHRTYPE
         elif stat.S_ISBLK(stmd):

diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 9615547fc22dfa72148577347f6103d1cb3ff0a8..2c6f0da7887f53e40d6a894144a772a79f77ef93 100644 (file)
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -1647,6 +1647,22 @@ class WriteTest(WriteTestBase, unittest.TestCase):
         finally:
             os_helper.unlink(path)
 
+    @os_helper.skip_unless_symlink
+    def test_symlink_target_normalization(self):
+        # Test for gh-151669.
+        path = os.path.join(TEMPDIR, "symlink")
+        target = "subdir/link/target"
+        os.symlink(target.replace("/", os.sep), path)
+        try:
+            tar = tarfile.open(tmpname, self.mode)
+            try:
+                tarinfo = tar.gettarinfo(path)
+                self.assertEqual(tarinfo.linkname, target)
+            finally:
+                tar.close()
+        finally:
+            os_helper.unlink(path)
+
     def test_add_self(self):
         # Test for #1257255.
         dstname = os.path.abspath(tmpname)

diff --git a/Misc/NEWS.d/next/Library/2026-06-24-23-28-42.gh-issue-151669.tPUavQ.rst b/Misc/NEWS.d/next/Library/2026-06-24-23-28-42.gh-issue-151669.tPUavQ.rst
new file mode 100644 (file)
index 0000000..d8e4850
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-06-24-23-28-42.gh-issue-151669.tPUavQ.rst
@@ -0,0 +1,3 @@
+On Windows, when populating tar archives from filesystem content, to
+conform to the tar format standard, backslashes in symlink targets are
+be replaced by slashes.