From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Fri, 24 Apr 2026 13:58:42 +0000 (+0200)
Subject: BUG/MEDIUM: stats: fix crash on 'dump stats-file'
X-Git-Url: http://git.ipfire.org/index.cgi?a=commitdiff_plain;ds=inline;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: stats: fix crash on 'dump stats-file'

A crash occurs immediately when stats-file dump is requested by the
command-line. The issue is caused by the introduction of watchers when
iterating over the proxies list, which is now required with dynamic
backends.

  commit 20376c54e2166a0882b71b26326360786f79ebdb
  MINOR: stats: protect proxy iteration via watcher

The above patch initializes the new proxy watcher for stats dump and
HTML. However, this was forgotten for stats-file command context. Fix
this by adding the missing watcher_init() in cli_parse_show_stat().

No need to backport.
---

diff --git a/src/stats.c b/src/stats.c
index 09c3b1a08..3c143c27d 100644
--- a/src/stats.c
+++ b/src/stats.c
@@ -1057,6 +1057,7 @@ static int cli_parse_dump_stat_file(char **args, char *payload,
 	ctx->domain = STATS_DOMAIN_PROXY;
 	ctx->flags |= STAT_F_FMT_FILE;
 	watcher_init(&ctx->srv_watch, &ctx->obj2, offsetof(struct server, watcher_list));
+	watcher_init(&ctx->px_watch,  &ctx->obj1, offsetof(struct proxy, watcher_list));
 
 	return 0;
 }