From: Shweta Sodani Date: Mon, 6 Apr 2026 05:53:32 +0000 (+0530) Subject: vfs_ceph_new: remove double-cleanup in closedir X-Git-Url: http://git.ipfire.org/index.cgi?a=commitdiff_plain;ds=inline;p=thirdparty%2Fsamba.git vfs_ceph_new: remove double-cleanup in closedir vfs_ceph_release_fh() was called explicitly then again via the FSP extension destructor triggered by vfs_ceph_remove_fh(). Drop the explicit call and let the destructor handle cleanup. Signed-off-by: Shweta Sodani Reviewed-by: Anoop C S Reviewed-by: John Mulligan Autobuild-User(master): Anoop C S Autobuild-Date(master): Tue Apr 21 22:18:42 UTC 2026 on atb-devel-224 --- diff --git a/source3/modules/vfs_ceph_new.c b/source3/modules/vfs_ceph_new.c index c2e33ca5243..b5657e572ec 100644 --- a/source3/modules/vfs_ceph_new.c +++ b/source3/modules/vfs_ceph_new.c @@ -2678,7 +2678,6 @@ static int vfs_ceph_closedir(struct vfs_handle_struct *handle, DIR *dirp) START_PROFILE_X(SNUM(handle->conn), syscall_closedir); DBG_DEBUG("[CEPH] closedir: dirp=%p\n", dirp); result = vfs_ceph_ll_releasedir(handle, cfh); - vfs_ceph_release_fh(cfh); vfs_ceph_remove_fh(handle, cfh->fsp); DBG_DEBUG("[CEPH] closedir: dirp=%p result=%d\n", dirp, result); END_PROFILE_X(syscall_closedir);