From: Claudiu Beznea Date: Tue, 26 May 2026 08:47:03 +0000 (+0300) Subject: dmaengine: sh: rz-dmac: Drop the update of channel->chctrl with CHCTRL_SETEN X-Git-Tag: v7.2-rc1~55^2~34 X-Git-Url: http://git.ipfire.org/index.cgi?a=commitdiff_plain;h=e8baee1d1cddc8e2be7bc362d6dc3fcb2021e873;p=thirdparty%2Flinux.git dmaengine: sh: rz-dmac: Drop the update of channel->chctrl with CHCTRL_SETEN The CHCTRL_SETEN bit is explicitly set in rz_dmac_enable_hw(). Updating struct rz_dmac_chan::chctrl with this bit in rz_dmac_prepare_desc_for_memcpy() and rz_dmac_prepare_descs_for_slave_sg() is unnecessary in the current code base. Moreover, it conflicts with the configuration sequence that will be used for cyclic DMA channels during suspend to RAM. Cyclic DMA support will be introduced in subsequent commits. This is a preparatory commit for cyclic DMA suspend to RAM support. Reviewed-by: Frank Li Tested-by: John Madieu Signed-off-by: Claudiu Beznea Tested-by: Tommaso Merciai Link: https://patch.msgid.link/20260526084710.3491480-12-claudiu.beznea@kernel.org Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 557364443a5fd..c9c00650ddd5d 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -377,7 +377,7 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_dmac_chan *channel) rz_dmac_set_dma_req_no(dmac, channel->index, dmac->info->default_dma_req_no); channel->chcfg = chcfg; - channel->chctrl = CHCTRL_STG | CHCTRL_SETEN; + channel->chctrl = CHCTRL_STG; } static void rz_dmac_prepare_descs_for_slave_sg(struct rz_dmac_chan *channel) @@ -428,7 +428,7 @@ static void rz_dmac_prepare_descs_for_slave_sg(struct rz_dmac_chan *channel) rz_dmac_set_dma_req_no(dmac, channel->index, channel->mid_rid); - channel->chctrl = CHCTRL_SETEN; + channel->chctrl = 0; } static void rz_dmac_xfer_desc(struct rz_dmac_chan *chan)