]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 days agoJust reconnect for UDP which will start the status checks developer/ndptech master
Nick Porter [Fri, 17 Apr 2026 13:16:13 +0000 (14:16 +0100)] 
Just reconnect for UDP which will start the status checks

3 days agoIf the connection is status_checking then status_check packets are allowed
Nick Porter [Fri, 17 Apr 2026 13:13:38 +0000 (14:13 +0100)] 
If the connection is status_checking then status_check packets are allowed

3 days agoCompare correct time values for last reply within allowed window
Nick Porter [Fri, 17 Apr 2026 12:58:58 +0000 (13:58 +0100)] 
Compare correct time values for last reply within allowed window

3 days agoIf we're verifying replies, we need the original packet
Nick Porter [Thu, 16 Apr 2026 13:58:04 +0000 (14:58 +0100)] 
If we're verifying replies, we need the original packet

4 days agoLoop correctly after parsing octet sequence
Nick Porter [Wed, 15 Apr 2026 17:52:21 +0000 (18:52 +0100)] 
Loop correctly after parsing octet sequence

After `p = end`, p will be pointing to the next character to parse, so
no need to further increment the pointer.

5 days agoupdate docs developer/alandekok
Alan T. DeKok [Tue, 14 Apr 2026 19:40:21 +0000 (15:40 -0400)] 
update docs

5 days agoadd more items and sort in alphabetical order
Alan T. DeKok [Tue, 14 Apr 2026 19:11:13 +0000 (15:11 -0400)] 
add more items and sort in alphabetical order

6 days agoDon't parent temporary dir buffer to ef in exfile_open_mkdir (#5823)
Ethan Thompson [Mon, 13 Apr 2026 18:25:29 +0000 (14:25 -0400)] 
Don't parent temporary dir buffer to ef in exfile_open_mkdir (#5823)

The buffer is always freed before the function returns, so parenting
it to ef implied a lifetime relationship that didn't exist.

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
7 days agoDisarm rather than delete timers
Nick Porter [Mon, 13 Apr 2026 14:12:06 +0000 (15:12 +0100)] 
Disarm rather than delete timers

To avoid repeated freeing / allocating

7 days agoEnsure parent cleanup timer is disarmed following new TCP connection
Nick Porter [Mon, 13 Apr 2026 14:02:29 +0000 (15:02 +0100)] 
Ensure parent cleanup timer is disarmed following new TCP connection

11 days agoOnly standard modules register xlats with their own name
Nick Porter [Thu, 9 Apr 2026 13:05:43 +0000 (14:05 +0100)] 
Only standard modules register xlats with their own name

Without this, if a virtual server, for example, has the same name as a
module which registers an xlat in its name, then, during server
shutdown, removing the process module for the virtual server attempts to
unregister the xlat which it doesn't own and leads to a seg fault.

11 days agoAdd name to coord_pair
Nick Porter [Thu, 9 Apr 2026 13:27:28 +0000 (14:27 +0100)] 
Add name to coord_pair

So request names can indicate which coordinator they belong to.

11 days agoParent coord_pair_reg off the list of registrations
Nick Porter [Thu, 9 Apr 2026 13:55:16 +0000 (14:55 +0100)] 
Parent coord_pair_reg off the list of registrations

As with coord_reg, the entry component of the registration will change
as additional modules register coord_pair, which conflicts with module
instance data protection.

11 days agoParent coordinator registrations off the list of registrations
Nick Porter [Wed, 8 Apr 2026 10:55:46 +0000 (11:55 +0100)] 
Parent coordinator registrations off the list of registrations

When more than one module registers a coordinator, the "previous"
registration changes when the new one is added to the list.  If the
registration is parented off the module instance data then that gets
protected - so a seg fault happens when the second registration is
added.  Parenting the registration off the list removes this issue.

11 days agoUse fr_dlist_talloc_init to type check entries
Nick Porter [Wed, 8 Apr 2026 10:14:49 +0000 (11:14 +0100)] 
Use fr_dlist_talloc_init to type check entries

11 days agoProtect CONF_SECTION with const
Nick Porter [Mon, 6 Apr 2026 16:13:15 +0000 (17:13 +0100)] 
Protect CONF_SECTION with const

11 days agoCONF_SECTION is not changed by map_afrom_cs, so use const
Nick Porter [Mon, 6 Apr 2026 16:09:05 +0000 (17:09 +0100)] 
CONF_SECTION is not changed by map_afrom_cs, so use const

12 days agomove "run asciidoctor" code
Alan T. DeKok [Tue, 7 Apr 2026 23:36:33 +0000 (19:36 -0400)] 
move "run asciidoctor" code

into block where we have asciidoctor

12 days agodocs-v4: Intergrity check on condition.adoc - fix syntax, added truth table, wordsmithing
nolade [Tue, 7 Apr 2026 21:35:49 +0000 (17:35 -0400)] 
docs-v4: Intergrity check on condition.adoc - fix syntax, added truth table, wordsmithing

12 days agodocs-v4: Updated copyright message to current year using Alan's perl magic
nolade [Tue, 7 Apr 2026 20:35:21 +0000 (16:35 -0400)] 
docs-v4: Updated copyright message to current year using Alan's perl magic
`perl -p -i -e 's/Copyright \(C\) 2.../Copyright (C) 2026/'  $(git grep -l 'Copyright' $(find doc/antora/ -name "*.adoc" -print))`

12 days agoUpdated the link to the InkBridge Networks website
Marc-Andre Casavant [Tue, 7 Apr 2026 18:09:33 +0000 (14:09 -0400)] 
Updated the link to the InkBridge Networks website

13 days agoCorrect comment
Nick Porter [Tue, 7 Apr 2026 11:39:38 +0000 (12:39 +0100)] 
Correct comment

13 days agoPacify Coverity (CID #1691057)
Nick Porter [Tue, 7 Apr 2026 07:31:59 +0000 (08:31 +0100)] 
Pacify Coverity (CID #1691057)

Xlat args will prevent in_head being NULL, but Coverity doesn't follow
that path.

13 days agoPacify Coverity (CID #1691058)
Nick Porter [Tue, 7 Apr 2026 07:25:20 +0000 (08:25 +0100)] 
Pacify Coverity (CID #1691058)

Module configuration requires that we there will be a "find" query.

13 days agoPacify Coverity (#CID 1691059)
Nick Porter [Tue, 7 Apr 2026 07:15:14 +0000 (08:15 +0100)] 
Pacify Coverity (#CID 1691059)

The xlat args will ensure that func is populated, but Coverity doesn't
follow that path.

13 days agoAllow Message-Authenticator !* 0x00 for "don't send it"
Alan T. DeKok [Tue, 7 Apr 2026 00:47:08 +0000 (20:47 -0400)] 
Allow Message-Authenticator !* 0x00 for "don't send it"

13 days agofr_packet_foo -> fr_radius_packet_foo
Alan T. DeKok [Mon, 6 Apr 2026 22:39:47 +0000 (18:39 -0400)] 
fr_packet_foo -> fr_radius_packet_foo

13 days agotweak encoder for static analyzer
Alan T. DeKok [Mon, 6 Apr 2026 20:14:08 +0000 (16:14 -0400)] 
tweak encoder for static analyzer

which changes the use of the random numbers, and therefore the
tests have to be updated

13 days agoqualify funtion name with "fr_radius"
Alan T. DeKok [Mon, 6 Apr 2026 20:01:43 +0000 (16:01 -0400)] 
qualify funtion name with "fr_radius"

13 days agowe don't need this macro, it's only used once
Alan T. DeKok [Mon, 6 Apr 2026 20:00:53 +0000 (16:00 -0400)] 
we don't need this macro, it's only used once

13 days agotweak fr_radius_verify() to keep static analyzer happy
Alan T. DeKok [Mon, 6 Apr 2026 19:28:06 +0000 (15:28 -0400)] 
tweak fr_radius_verify() to keep static analyzer happy

2 weeks agoUpdate action for node.js 24
Nick Porter [Mon, 6 Apr 2026 13:30:51 +0000 (14:30 +0100)] 
Update action for node.js 24

2 weeks agoAdd sample config for CRL delta building
Nick Porter [Mon, 6 Apr 2026 12:58:35 +0000 (13:58 +0100)] 
Add sample config for CRL delta building

Currently `openssl crl` won't take a key on the command line, so `make
rsa/delta.crl` will prompt for the password.

2 weeks agoSend CRL-Expire to worker if refresh of expired CRL fails
Nick Porter [Mon, 6 Apr 2026 10:38:38 +0000 (11:38 +0100)] 
Send CRL-Expire to worker if refresh of expired CRL fails

and expired CRLs are not allowed.

2 weeks agoAdd time validity options to CRL virtual server
Nick Porter [Tue, 31 Mar 2026 13:36:38 +0000 (14:36 +0100)] 
Add time validity options to CRL virtual server

2 weeks agoAdd process_crl.so to RHEL packaging
Nick Porter [Fri, 27 Mar 2026 17:51:02 +0000 (17:51 +0000)] 
Add process_crl.so to RHEL packaging

2 weeks agoUpdate docs from raddb
Nick Porter [Fri, 27 Mar 2026 17:39:53 +0000 (17:39 +0000)] 
Update docs from raddb

2 weeks agoAdd url option to rlm_crl
Nick Porter [Fri, 27 Mar 2026 17:29:11 +0000 (17:29 +0000)] 
Add url option to rlm_crl

To allow pre-fetching of CRLs before they are needed for certificate
verification.

2 weeks agoRework CRL test to handle limitations of unit_test_module
Nick Porter [Fri, 27 Mar 2026 16:17:50 +0000 (16:17 +0000)] 
Rework CRL test to handle limitations of unit_test_module

2 weeks agoAdd %crl.refresh() to forcibly trigger refresh
Nick Porter [Fri, 27 Mar 2026 16:17:03 +0000 (16:17 +0000)] 
Add %crl.refresh() to forcibly trigger refresh

2 weeks agoPlumb coordinator framework into unit_test_module
Nick Porter [Fri, 27 Mar 2026 15:58:43 +0000 (15:58 +0000)] 
Plumb coordinator framework into unit_test_module

2 weeks agoAdd fr_schedule_worker_id_set
Nick Porter [Fri, 27 Mar 2026 15:55:44 +0000 (15:55 +0000)] 
Add fr_schedule_worker_id_set

Only to be used from test frameworks such as unit_test_module.

2 weeks agoUpdate rlm_crl tests with updated config
Nick Porter [Fri, 27 Mar 2026 11:43:16 +0000 (11:43 +0000)] 
Update rlm_crl tests with updated config

2 weeks agoUpdate sample rlm_crl configuration
Nick Porter [Fri, 27 Mar 2026 11:34:27 +0000 (11:34 +0000)] 
Update sample rlm_crl configuration

2 weeks agoConvert rlm_crl to use coordinator thread
Nick Porter [Thu, 26 Mar 2026 16:41:39 +0000 (16:41 +0000)] 
Convert rlm_crl to use coordinator thread

2 weeks agoAdd a sample CRL virtual server
Nick Porter [Fri, 27 Mar 2026 11:25:49 +0000 (11:25 +0000)] 
Add a sample CRL virtual server

2 weeks agoAdd CRL process module
Nick Porter [Thu, 26 Mar 2026 12:17:53 +0000 (12:17 +0000)] 
Add CRL process module

For a coordinator thread to run requests to fetch CRLs

2 weeks agoquiet static analyzer
Alan T. DeKok [Sun, 5 Apr 2026 23:51:09 +0000 (19:51 -0400)] 
quiet static analyzer

via using static[256] for fixed-size buffers, among other tweaks

2 weeks agoinputfp may be NULL
Alan T. DeKok [Sun, 5 Apr 2026 23:41:28 +0000 (19:41 -0400)] 
inputfp may be NULL

2 weeks agoallocation may fail
Alan T. DeKok [Sun, 5 Apr 2026 23:41:17 +0000 (19:41 -0400)] 
allocation may fail

2 weeks agotweak checks for digest attributes
Alan T. DeKok [Sun, 5 Apr 2026 18:04:44 +0000 (14:04 -0400)] 
tweak checks for digest attributes

2 weeks agoclean up radmin
Alan T. DeKok [Sun, 5 Apr 2026 15:04:52 +0000 (11:04 -0400)] 
clean up radmin

double check return paths, exit codes, messages, etc.

2 weeks agoWrite "Including files" only in debug2
Alan T. DeKok [Sun, 5 Apr 2026 14:51:32 +0000 (10:51 -0400)] 
Write "Including files" only in debug2

2 weeks agoremove unused code
Alan T. DeKok [Sun, 5 Apr 2026 14:47:43 +0000 (10:47 -0400)] 
remove unused code

we don't use the tmpl rules for anything, so we might as well
remove it.

2 weeks agoadd tests for the dictionary file parser
Alan T. DeKok [Fri, 3 Apr 2026 22:09:47 +0000 (18:09 -0400)] 
add tests for the dictionary file parser

2 weeks agoadd fr_dict_afrom_file()
Alan T. DeKok [Fri, 3 Apr 2026 22:03:49 +0000 (18:03 -0400)] 
add fr_dict_afrom_file()

only for testing.  And add wrapper to unit_test_attribute

2 weeks agouse different UTF-8 text for test data
Alan T. DeKok [Sat, 4 Apr 2026 16:36:24 +0000 (12:36 -0400)] 
use different UTF-8 text for test data

2 weeks agoremove debug / testing output
Alan T. DeKok [Sat, 4 Apr 2026 16:10:36 +0000 (12:10 -0400)] 
remove debug / testing output

2 weeks agoadd assume() macro
Alan T. DeKok [Sat, 4 Apr 2026 15:57:19 +0000 (11:57 -0400)] 
add assume() macro

which is a hint to the compiler that a variable can have a
particular value.  It's not an assertion, but it lets the compiler
know that it can make more optimizations based on the given
assumption.

2 weeks agoadd notes for run-time DNS resolution of client sockets
Alan T. DeKok [Sat, 4 Apr 2026 14:51:06 +0000 (10:51 -0400)] 
add notes for run-time DNS resolution of client sockets

2 weeks agoallow for END PROTOCOL, and END VENDOR too
Alan T. DeKok [Fri, 3 Apr 2026 21:46:34 +0000 (17:46 -0400)] 
allow for END PROTOCOL, and END VENDOR too

which is obvious to use.  Because using "BEGIN PROTOCOL" followed
by "END-PROTOCOL" is just weird.

Previously it would complain with an entirely opaque error.

2 weeks agotweak dict_from_file to be a bit more forgiving
Alan T. DeKok [Fri, 3 Apr 2026 21:35:43 +0000 (17:35 -0400)] 
tweak dict_from_file to be a bit more forgiving

2 weeks agolook up duplicate number if it's _not_ name-only
Alan T. DeKok [Fri, 3 Apr 2026 21:11:19 +0000 (17:11 -0400)] 
look up duplicate number if it's _not_ name-only

2 weeks agodefault to 0 buffer count
Alan T. DeKok [Fri, 3 Apr 2026 22:04:42 +0000 (18:04 -0400)] 
default to 0 buffer count

which is the least surprising.  Otherwise it is not at all obvious
why there is a delay.

and enforce min/max limits on the buffer count/delay, so that they
aren't zero

2 weeks agoUpdate linelog examples and documentation
Alan T. DeKok [Fri, 3 Apr 2026 20:46:18 +0000 (16:46 -0400)] 
Update linelog examples and documentation

2 weeks agoallow radmin to read custom dictionaries, too.
Alan T. DeKok [Fri, 3 Apr 2026 16:59:40 +0000 (12:59 -0400)] 
allow radmin to read custom dictionaries, too.

the server and radclient assume that the RADIUS protocol is loaded
before reading raddb/dictionary.  So radmin should do that, too

2 weeks agoremove conflicting Altiga attributes
Alan T. DeKok [Fri, 3 Apr 2026 16:59:20 +0000 (12:59 -0400)] 
remove conflicting Altiga attributes

2 weeks agoport attributes from v3.2.x
Alan T. DeKok [Fri, 3 Apr 2026 16:58:54 +0000 (12:58 -0400)] 
port attributes from v3.2.x

2 weeks agochange '-r file' to '-o file'
Alan T. DeKok [Fri, 3 Apr 2026 16:53:36 +0000 (12:53 -0400)] 
change '-r file' to '-o file'

the default is to assume that '-r file' means "read file".
Instead, it means "destroy that file", which is unfriendly.

2 weeks agothese don't need to be exported
Alan T. DeKok [Fri, 3 Apr 2026 16:38:53 +0000 (12:38 -0400)] 
these don't need to be exported

2 weeks agoclean up RADIUS TCP handler.
Alan T. DeKok [Fri, 3 Apr 2026 12:23:07 +0000 (08:23 -0400)] 
clean up RADIUS TCP handler.

* check length in header and close if the header length is invalid
* use the master IO allow / deny trie API, instead of rolling
  our own

2 weeks agoasserts and checks when printing log messages
Alan T. DeKok [Fri, 3 Apr 2026 12:22:38 +0000 (08:22 -0400)] 
asserts and checks when printing log messages

2 weeks agoCancelling is really an error
Nick Porter [Fri, 3 Apr 2026 14:06:56 +0000 (15:06 +0100)] 
Cancelling is really an error

And this populates Module-Failure-Message so logs can report what
happened.

2 weeks agoImprove comment
Nick Porter [Fri, 3 Apr 2026 14:04:47 +0000 (15:04 +0100)] 
Improve comment

2 weeks agoAdd %tacacs.verify.secret for verification in new client section
Nick Porter [Fri, 3 Apr 2026 14:04:10 +0000 (15:04 +0100)] 
Add %tacacs.verify.secret for verification in new client section

2 weeks agocatch more corner cases
Alan T. DeKok [Fri, 3 Apr 2026 11:28:53 +0000 (07:28 -0400)] 
catch more corner cases

2 weeks agocancel includes the current depth
Alan T. DeKok [Fri, 3 Apr 2026 11:23:29 +0000 (07:23 -0400)] 
cancel includes the current depth

2 weeks agovarious minor tweaks to unlang compiler
Alan T. DeKok [Thu, 2 Apr 2026 19:54:21 +0000 (15:54 -0400)] 
various minor tweaks to unlang compiler

2 weeks agomake certificates more quietly
Alan T. DeKok [Thu, 2 Apr 2026 19:35:48 +0000 (15:35 -0400)] 
make certificates more quietly

2 weeks agofree secret before over-writing it
Alan T. DeKok [Thu, 2 Apr 2026 13:14:22 +0000 (09:14 -0400)] 
free secret before over-writing it

2 weeks agocheck return code of openss3_init()
Alan T. DeKok [Thu, 2 Apr 2026 13:13:35 +0000 (09:13 -0400)] 
check return code of openss3_init()

2 weeks agoupdate macro to allow things checking it
Alan T. DeKok [Thu, 2 Apr 2026 13:13:09 +0000 (09:13 -0400)] 
update macro to allow things checking it

2 weeks agocorrect comparison
Alan T. DeKok [Thu, 2 Apr 2026 13:12:35 +0000 (09:12 -0400)] 
correct comparison

in practice, this won't happen, but it's good to fix

2 weeks agofree packets on error
Alan T. DeKok [Thu, 2 Apr 2026 13:11:44 +0000 (09:11 -0400)] 
free packets on error

2 weeks agofix typo
Alan T. DeKok [Thu, 2 Apr 2026 13:11:06 +0000 (09:11 -0400)] 
fix typo

2 weeks agouse correct request for removal from the CoA tree
Alan T. DeKok [Thu, 2 Apr 2026 13:09:53 +0000 (09:09 -0400)] 
use correct request for removal from the CoA tree

2 weeks agoset timers to remaining.
Alan T. DeKok [Thu, 2 Apr 2026 13:09:16 +0000 (09:09 -0400)] 
set timers to remaining.

@todo - just use fr_retry_t

2 weeks agodocs-v4: added more syntax examples for <type> field.
nolade [Wed, 1 Apr 2026 21:27:40 +0000 (17:27 -0400)] 
docs-v4: added more syntax examples for <type> field.

2 weeks agotweak / rename "force module return code"
Alan T. DeKok [Thu, 2 Apr 2026 09:30:24 +0000 (05:30 -0400)] 
tweak / rename "force module return code"

2 weeks agodocs-v4: added 5 more instances (disallow, handled, invalid, notfound, updated) used...
nolade [Wed, 1 Apr 2026 21:06:37 +0000 (17:06 -0400)] 
docs-v4: added 5 more instances (disallow, handled, invalid, notfound, updated) used by `always` module

2 weeks agofix typo
Alan T. DeKok [Thu, 2 Apr 2026 09:29:28 +0000 (05:29 -0400)] 
fix typo

2 weeks agomash <1us (and negative) to zero for timeout
Alan T. DeKok [Thu, 2 Apr 2026 09:26:09 +0000 (05:26 -0400)] 
mash <1us (and negative) to zero for timeout

2 weeks agodocs-v4: wordsmiting 1st paragraph to clearly explain `return` versus `break`
nolade [Wed, 1 Apr 2026 20:24:08 +0000 (16:24 -0400)] 
docs-v4: wordsmiting 1st paragraph to clearly explain `return` versus `break`

2 weeks agodocs-v4: added info re: `default` keyword, added `parallel` info, updated nav file
nolade [Wed, 1 Apr 2026 19:21:26 +0000 (15:21 -0400)] 
docs-v4: added info re: `default` keyword, added `parallel` info, updated nav file

2 weeks agolocal variables are now alloed.
Alan T. DeKok [Wed, 1 Apr 2026 17:41:24 +0000 (13:41 -0400)] 
local variables are now alloed.

2 weeks agodocs-v4: added subrequest & policy to list of where local vars can be used, fixed...
nolade [Wed, 1 Apr 2026 14:45:37 +0000 (10:45 -0400)] 
docs-v4: added subrequest & policy to list of where local vars can be used, fixed typo

2 weeks agoallow certs to be made quietly
Alan T. DeKok [Wed, 1 Apr 2026 15:40:00 +0000 (11:40 -0400)] 
allow certs to be made quietly

because the CI output is polluted with tons of OpenSSL output,
and we don't need to see that.

2 weeks agoLook up in client tree, even if we have a cached entry. Fixes #5676
Shang Chieh Tseng [Wed, 1 Apr 2026 15:25:32 +0000 (11:25 -0400)] 
Look up in client tree, even if we have a cached entry.  Fixes #5676

When the per-thread client trie has a cached entry from a broad
subnet (e.g. /8), it shadows more specific client definitions
(e.g. /24) for subsequent connections.  This causes the wrong
shared secret to be used, breaking packet authentication (RADIUS)
or decryption (TACACS+).

After the trie lookup returns a cached client, verify it against
the global client list.  If a more specific match exists, discard
the cached result so the existing code path does a fresh lookup
and caches the correct client.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 weeks agoclarify outer vs parent issues
Alan T. DeKok [Wed, 1 Apr 2026 15:19:11 +0000 (11:19 -0400)] 
clarify outer vs parent issues

2 weeks agotypo
Alan T. DeKok [Wed, 1 Apr 2026 14:48:00 +0000 (10:48 -0400)] 
typo