]> git.ipfire.org Git - people/ms/linux.git/commitdiff
udp: Use WARN_ON_ONCE() in udp_read_skb()
authorPeilin Ye <peilin.ye@bytedance.com>
Wed, 21 Sep 2022 00:59:15 +0000 (17:59 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Sep 2022 13:42:57 +0000 (06:42 -0700)
Prevent udp_read_skb() from flooding the syslog.

Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Link: https://lore.kernel.org/r/20220921005915.2697-1-yepeilin.cs@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/udp.c

index cd72158e953a5989987c2122f12ed02f15fa7c1b..560d9eadeaa5805e4eeb416ff3b07a36bd746223 100644 (file)
@@ -1821,7 +1821,7 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
                        continue;
                }
 
-               WARN_ON(!skb_set_owner_sk_safe(skb, sk));
+               WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));
                used = recv_actor(sk, skb);
                if (used <= 0) {
                        if (!copied)