bfd/ChangeLog

   1 2021-04-01  Martin Liska  <mliska@suse.cz>
   2
   3         * elf-bfd.h (bfd_section_is_ctf): Use startswith function.
   4         * elf.c (_bfd_elf_make_section_from_shdr): Likewise.
   5         (elf_get_reloc_section): Likewise.
   6         * elf32-arc.c (elf_arc_size_dynamic_sections): Likewise.
   7         * elf32-m32r.c (m32r_elf_section_flags): Likewise.
   8         * elf32-microblaze.c (microblaze_elf_size_dynamic_sections): Likewise.
   9         * elf32-nds32.c (nds32_elf_size_dynamic_sections): Likewise.
  10         (nds32_elf_relocate_section): Likewise.
  11         (nds32_elf_action_discarded): Likewise.
  12         (nds32_elf_check_relocs): Likewise.
  13         (nds32_elf_section_flags): Likewise.
  14         * elf32-or1k.c (or1k_elf_check_relocs): Likewise.
  15         * elf32-ppc.c (ppc_elf_section_from_shdr): Likewise.
  16         * elf32-rx.c (rx_table_find): Likewise.
  17         (rx_table_map): Likewise.
  18         * elf32-spu.c (spu_elf_backend_symbol_processing): Likewise.
  19         (spu_elf_find_overlays): Likewise.
  20         (needs_ovl_stub): Likewise.
  21         (allocate_spuear_stubs): Likewise.
  22         (build_spuear_stubs): Likewise.
  23         (mark_overlay_section): Likewise.
  24         (spu_elf_auto_overlay): Likewise.
  25         (spu_elf_output_symbol_hook): Likewise.
  26         * elf32-tilepro.c (tilepro_elf_size_dynamic_sections): Likewise.
  27         * elf32-xtensa.c (xtensa_property_section_name): Likewise.
  28         * elf64-ppc.c (ppc64_elf_section_flags): Likewise.
  29         (ppc64_elf_relocate_section): Likewise.
  30         * elflink.c (resolve_section): Likewise.
  31         (UNARY_OP): Likewise.
  32         (BINARY_OP_HEAD): Likewise.
  33         (elf_link_input_bfd): Likewise.
  34         * elfnn-riscv.c (riscv_elf_size_dynamic_sections): Likewise.
  35         * elfxx-riscv.c (riscv_parse_subset): Likewise.
  36         * elfxx-tilegx.c (tilegx_elf_size_dynamic_sections): Likewise.
  37         * opncls.c (get_build_id): Likewise.
  38
  39 2021-03-31  Alan Modra  <amodra@gmail.com>
  40
  41         PR 27671
  42         * bfd-in.h: Don't poison FALSE or TRUE.
  43         * bfd-in2.h: Regenerate.
  44
  45 2021-03-31  Alan Modra  <amodra@gmail.com>
  46
  47         * sysdep.h: POISON_BFD_BOOLEAN: Define.
  48         * aix5ppc-core.c, * aout-cris.c, * aout-ns32k.c, * aout-target.h,
  49         * aoutx.h, * arc-got.h, * archive.c, * archive64.c, * archures.c,
  50         * bfd-in.h, * bfd.c, * bfdwin.c, * binary.c, * cache.c,
  51         * coff-alpha.c, * coff-arm.c, * coff-arm.h, * coff-bfd.c,
  52         * coff-bfd.h, * coff-go32.c, * coff-i386.c, * coff-ia64.c,
  53         * coff-mcore.c, * coff-mips.c, * coff-rs6000.c, * coff-sh.c,
  54         * coff-stgo32.c, * coff-tic30.c, * coff-tic4x.c, * coff-tic54x.c,
  55         * coff-x86_64.c, * coff-z80.c, * coff-z8k.c, * coff64-rs6000.c,
  56         * coffcode.h, * coffgen.c, * cofflink.c, * compress.c,
  57         * corefile.c, * cpu-aarch64.c, * cpu-aarch64.h, * cpu-alpha.c,
  58         * cpu-arc.c, * cpu-arm.c, * cpu-arm.h, * cpu-avr.c, * cpu-bfin.c,
  59         * cpu-bpf.c, * cpu-cr16.c, * cpu-cris.c, * cpu-crx.c,
  60         * cpu-csky.c, * cpu-d10v.c, * cpu-d30v.c, * cpu-dlx.c,
  61         * cpu-epiphany.c, * cpu-fr30.c, * cpu-frv.c, * cpu-ft32.c,
  62         * cpu-h8300.c, * cpu-hppa.c, * cpu-i386.c, * cpu-ia64.c,
  63         * cpu-iamcu.c, * cpu-ip2k.c, * cpu-iq2000.c, * cpu-k1om.c,
  64         * cpu-l1om.c, * cpu-lm32.c, * cpu-m10200.c, * cpu-m10300.c,
  65         * cpu-m32c.c, * cpu-m32r.c, * cpu-m68hc11.c, * cpu-m68hc12.c,
  66         * cpu-m68k.c, * cpu-m9s12x.c, * cpu-m9s12xg.c, * cpu-mcore.c,
  67         * cpu-mep.c, * cpu-metag.c, * cpu-microblaze.c, * cpu-mips.c,
  68         * cpu-mmix.c, * cpu-moxie.c, * cpu-msp430.c, * cpu-mt.c,
  69         * cpu-nds32.c, * cpu-nfp.c, * cpu-nios2.c, * cpu-ns32k.c,
  70         * cpu-or1k.c, * cpu-pdp11.c, * cpu-pj.c, * cpu-powerpc.c,
  71         * cpu-pru.c, * cpu-riscv.c, * cpu-rl78.c, * cpu-rs6000.c,
  72         * cpu-rx.c, * cpu-s12z.c, * cpu-s390.c, * cpu-score.c,
  73         * cpu-sh.c, * cpu-sparc.c, * cpu-spu.c, * cpu-tic30.c,
  74         * cpu-tic4x.c, * cpu-tic54x.c, * cpu-tic6x.c, * cpu-tilegx.c,
  75         * cpu-tilepro.c, * cpu-v850.c, * cpu-v850_rh850.c, * cpu-vax.c,
  76         * cpu-visium.c, * cpu-wasm32.c, * cpu-xc16x.c, * cpu-xgate.c,
  77         * cpu-xstormy16.c, * cpu-xtensa.c, * cpu-z80.c, * cpu-z8k.c,
  78         * dwarf1.c, * dwarf2.c, * ecoff-bfd.h, * ecoff.c, * ecofflink.c,
  79         * elf-attrs.c, * elf-bfd.h, * elf-eh-frame.c, * elf-hppa.h,
  80         * elf-ifunc.c, * elf-m10200.c, * elf-m10300.c, * elf-nacl.c,
  81         * elf-nacl.h, * elf-properties.c, * elf-s390-common.c,
  82         * elf-s390.h, * elf-strtab.c, * elf-vxworks.c, * elf-vxworks.h,
  83         * elf.c, * elf32-am33lin.c, * elf32-arc.c, * elf32-arm.c,
  84         * elf32-arm.h, * elf32-avr.c, * elf32-avr.h, * elf32-bfin.c,
  85         * elf32-bfin.h, * elf32-cr16.c, * elf32-cr16.h, * elf32-cris.c,
  86         * elf32-crx.c, * elf32-csky.c, * elf32-csky.h, * elf32-d10v.c,
  87         * elf32-d30v.c, * elf32-dlx.c, * elf32-epiphany.c,
  88         * elf32-fr30.c, * elf32-frv.c, * elf32-ft32.c, * elf32-gen.c,
  89         * elf32-h8300.c, * elf32-hppa.c, * elf32-hppa.h, * elf32-i386.c,
  90         * elf32-ip2k.c, * elf32-iq2000.c, * elf32-lm32.c, * elf32-m32c.c,
  91         * elf32-m32r.c, * elf32-m68hc11.c, * elf32-m68hc12.c,
  92         * elf32-m68hc1x.c, * elf32-m68hc1x.h, * elf32-m68k.c,
  93         * elf32-m68k.h, * elf32-mcore.c, * elf32-mep.c, * elf32-metag.c,
  94         * elf32-metag.h, * elf32-microblaze.c, * elf32-mips.c,
  95         * elf32-moxie.c, * elf32-msp430.c, * elf32-mt.c, * elf32-nds32.c,
  96         * elf32-nios2.c, * elf32-nios2.h, * elf32-or1k.c, * elf32-pj.c,
  97         * elf32-ppc.c, * elf32-ppc.h, * elf32-pru.c, * elf32-rl78.c,
  98         * elf32-rx.c, * elf32-s12z.c, * elf32-s390.c, * elf32-score.c,
  99         * elf32-score.h, * elf32-score7.c, * elf32-sh-relocs.h,
 100         * elf32-sh.c, * elf32-sparc.c, * elf32-spu.c, * elf32-spu.h,
 101         * elf32-tic6x.c, * elf32-tic6x.h, * elf32-tilegx.c,
 102         * elf32-tilepro.c, * elf32-v850.c, * elf32-v850.h,
 103         * elf32-vax.c, * elf32-visium.c, * elf32-wasm32.c,
 104         * elf32-xc16x.c, * elf32-xgate.c, * elf32-xstormy16.c,
 105         * elf32-xtensa.c, * elf32-z80.c, * elf64-alpha.c, * elf64-bpf.c,
 106         * elf64-gen.c, * elf64-hppa.c, * elf64-ia64-vms.c,
 107         * elf64-mips.c, * elf64-mmix.c, * elf64-nfp.c, * elf64-ppc.c,
 108         * elf64-ppc.h, * elf64-s390.c, * elf64-sparc.c,
 109         * elf64-tilegx.c, * elf64-x86-64.c, * elfcode.h,
 110         * elfcore.h, * elflink.c, * elfn32-mips.c, * elfnn-aarch64.c,
 111         * elfnn-ia64.c, * elfnn-riscv.c, * elfxx-aarch64.c,
 112         * elfxx-aarch64.h, * elfxx-ia64.c, * elfxx-ia64.h,
 113         * elfxx-mips.c, * elfxx-mips.h, * elfxx-riscv.c, * elfxx-riscv.h,
 114         * elfxx-sparc.c, * elfxx-sparc.h, * elfxx-target.h,
 115         * elfxx-tilegx.c, * elfxx-tilegx.h, * elfxx-x86.c, * elfxx-x86.h,
 116         * format.c, * genlink.h, * hash.c, * i386aout.c, * i386lynx.c,
 117         * i386msdos.c, * ihex.c, * libaout.h, * libbfd-in.h,
 118         * libbfd.c, * libcoff-in.h, * libecoff.h, * libpei.h,
 119         * libxcoff.h, * linker.c, * mach-o-aarch64.c, * mach-o-arm.c,
 120         * mach-o-i386.c, * mach-o-x86-64.c, * mach-o.c, * mach-o.h,
 121         * merge.c, * mmo.c, * netbsd.h, * opncls.c, * pc532-mach.c,
 122         * pdp11.c, * pe-arm.c, * pe-i386.c, * pe-mcore.c, * pe-sh.c,
 123         * pe-x86_64.c, * peXXigen.c, * pef.c, * pei-arm.c, * pei-i386.c,
 124         * pei-ia64.c, * pei-mcore.c, * pei-sh.c, * pei-x86_64.c,
 125         * peicode.h, * plugin.c, * plugin.h, * ppcboot.c, * reloc.c,
 126         * reloc16.c, * rs6000-core.c, * section.c, * simple.c, * som.c,
 127         * som.h, * srec.c, * stabs.c, * syms.c, * targets.c, * tekhex.c,
 128         * verilog.c, * vms-alpha.c, * vms-lib.c, * vms-misc.c, * vms.h,
 129         * wasm-module.c, * xcofflink.c, * xcofflink.h, * xsym.c,
 130         * xsym.h: Replace bfd_boolean with bool, FALSE with false, and
 131         TRUE with true throughout.
 132         * bfd-in2.h: Regenerate.
 133         * libbfd.h: Regenerate.
 134         * libcoff.h: Regenerate.
 135
 136 2021-03-31  Alan Modra  <amodra@gmail.com>
 137
 138         * bfd-in.h: Include stdbool.h.
 139         (bfd_boolean): Define as bool
 140         * bfd-in2.h: Regenerate.
 141
 142 2021-03-31  Alan Modra  <amodra@gmail.com>
 143
 144         * .gitignore: Delete bfd_stdint.h entry.
 145         * Makefile.am (bfdinclude_HEADERS): Delete bfd_stdint.h.
 146         (BUILD_HFILES, LOCAL_H_DEPS): Likewise.
 147         * bfd-in.h: Include stdint.h in place of bfd_stdint.h.
 148         * configure.ac: Don't invoke GCC_HEADER_STDINT.
 149         * configure.com: Don't create bfd_stdint.h.
 150         * Makefile.in: Regenerate.
 151         * aclocal.m4: Regenerate.
 152         * bfd-in2.h: Regenerate.
 153         * config.in: Regenerate.
 154         * configure: Regenerate.
 155         * doc/Makefile.in: Regenerate.
 156         * po/BLD-POTFILES.in: Regenerate.
 157
 158 2021-03-31  Alan Modra  <amodra@gmail.com>
 159
 160         * bfd-in.h: Include string.h.
 161         (LITMEMCPY, LITSTRCPY): Delete.
 162         * bfd-in2.h: Regenerate.
 163
 164 2021-03-30  Alan Modra  <amodra@gmail.com>
 165
 166         * elflink.c (elf_link_add_object_symbols): Don't set h->indx
 167         unless is_elf_hash_table.
 168
 169 2021-03-29  Alan Modra  <amodra@gmail.com>
 170
 171         * aoutx.h (aout_link_write_symbols): Don't cast boolean expression
 172         to bfd_boolean.
 173         * elf32-or1k.c (or1k_set_got_and_rela_sizes): Dont compare booleans
 174         against FALSE.
 175         * elf32-arc.c (name_for_global_symbol): Don't compare boolean to TRUE.
 176         (is_reloc_PC_relative): Don't use "boolean_condition ? TRUE : FALSE".
 177         (is_reloc_SDA_relative, is_reloc_for_GOT): Likewise.
 178         (is_reloc_for_PLT, is_reloc_for_TLS): Likewise.
 179         * elf32-arm.c (stm32l4xx_need_create_replacing_stub): Likewise.
 180         * elf32-nds32.c (insert_nds32_elf_blank): Likewise.
 181         * elf32-rx.c (rx_set_section_contents): Likewise.
 182         * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Likewise.
 183         * elfxx-mips.c (_bfd_mips_elf_ignore_undef_symbol): Likewise.
 184         * mach-o.c (bfd_mach_o_read_command): Likewise.
 185         * targets.c (bfd_get_target_info): Likewise.
 186
 187 2021-03-29  Alan Modra  <amodra@gmail.com>
 188
 189         * coff-z80.c (z80_is_local_label_name): Return bfd_boolean.
 190         * elf32-z80.c (z80_is_local_label_name): Likewise.
 191         * elf32-spu.c (spu_elf_modify_headers): Likewise.
 192         * elf32-nds32.h (struct elf_nds32_link_hash_table <hyper_relax>):
 193         Change type to int.
 194         * vms-lib.c (_bfd_vms_lib_write_archive_contents): Correct test
 195         for error return from vms_write_data_block.
 196
 197 2021-03-29  Alan Modra  <amodra@gmail.com>
 198
 199         * elf32-i386.c (elf_i386_finish_local_dynamic_symbol): Return int.
 200         * elf64-ia64-vms.c (elf64_ia64_local_dyn_info_free): Likewise.
 201         (elf64_ia64_local_dyn_sym_thunk): Likewise.
 202         * elf64-x86-64.c (elf_x86_64_finish_local_dynamic_symbol): Likewise.
 203         * elfnn-aarch64.c (elfNN_aarch64_allocate_local_ifunc_dynrelocs),
 204         (elfNN_aarch64_finish_local_dynamic_symbol): Likewise.
 205         * elfnn-ia64.c (elfNN_ia64_local_dyn_info_free): Likewise.
 206         (elfNN_ia64_local_dyn_sym_thunk): Likewise.
 207         * elfnn-riscv.c (allocate_local_ifunc_dynrelocs): Likewise.
 208         (riscv_pcrel_reloc_eq): Likewise.
 209         (riscv_elf_finish_local_dynamic_symbol): Likewise.
 210         * elfxx-sparc.c (allocate_local_dynrelocs): Likewise.
 211         (finish_local_dynamic_symbol): Likewise.
 212         * elfxx-x86.c (elf_x86_allocate_local_dynreloc): Likewise.
 213         * elfxx-mips.c (mips_elf_resolve_got_page_ref): Likewise.
 214         (mips_elf_count_got_symbols): Change return type to bfd_boolean.
 215
 216 2021-03-29  Alan Modra  <amodra@gmail.com>
 217
 218         * elflink.c (elf_link_output_symstrtab): Make flinfo parameter
 219         a void pointer.
 220         (bfd_elf_final_link): Delete out_sym_func typedef and don't cast
 221         elf_link_output_symstrtab when calling output_arch_syms and
 222         output_arch_local_syms.
 223         * elf-bfd.h (struct elf_backend_data <elf_backend_output_arch_syms,
 224         elf_backend_output_arch_local_syms>): Change return type of func
 225         arg to match elf_link_output_symstrtab.
 226         * elf-vxworks.h (elf_vxworks_link_output_symbol_hook): Correct
 227         return type.
 228         * elf32-nds32.c (nds32_elf_output_symbol_hook): Correct return type.
 229         (nds32_elf_output_arch_syms): Correct func return type.
 230
 231 2021-03-29  Alan Modra  <amodra@gmail.com>
 232
 233         * elf-m10200.c (mn10200_elf_relocate_section): Return int.
 234         * elf-m10300.c (mn10300_elf_relocate_section): Likewise.
 235         * elf32-arc.c (elf_arc_relocate_section): Likewise.
 236         * elf32-arm.c (elf32_arm_relocate_section): Likewise.
 237         * elf32-avr.c (elf32_avr_relocate_section): Likewise.
 238         * elf32-bfin.c (bfin_relocate_section): Likewise.
 239         (bfinfdpic_relocate_section): Likewise.
 240         * elf32-cr16.c (elf32_cr16_relocate_section): Likewise.
 241         * elf32-cris.c (cris_elf_relocate_section): Likewise.
 242         * elf32-crx.c (elf32_crx_relocate_section): Likewise.
 243         * elf32-csky.c (csky_elf_relocate_section): Likewise.
 244         * elf32-d10v.c (elf32_d10v_relocate_section): Likewise.
 245         * elf32-epiphany.c (epiphany_elf_relocate_section): Likewise.
 246         * elf32-fr30.c (fr30_elf_relocate_section): Likewise.
 247         * elf32-frv.c (elf32_frv_relocate_section): Likewise.
 248         * elf32-ft32.c (ft32_elf_relocate_section): Likewise.
 249         * elf32-h8300.c (elf32_h8_relocate_section): Likewise.
 250         * elf32-hppa.c (elf32_hppa_relocate_section): Likewise.
 251         * elf32-i386.c (elf_i386_relocate_section): Likewise.
 252         * elf32-ip2k.c (ip2k_elf_relocate_section): Likewise.
 253         * elf32-iq2000.c (iq2000_elf_relocate_section): Likewise.
 254         * elf32-lm32.c (lm32_elf_relocate_section): Likewise.
 255         * elf32-m32c.c (m32c_elf_relocate_section): Likewise.
 256         * elf32-m32r.c (m32r_elf_relocate_section): Likewise.
 257         * elf32-m68hc1x.c (elf32_m68hc11_relocate_section): Likewise.
 258         * elf32-m68hc1x.h (elf32_m68hc11_relocate_section): Likewise.
 259         * elf32-m68k.c (elf_m68k_relocate_section): Likewise.
 260         * elf32-mcore.c (mcore_elf_relocate_section): Likewise.
 261         * elf32-mep.c (mep_elf_relocate_section): Likewise.
 262         * elf32-metag.c (elf_metag_relocate_section): Likewise.
 263         * elf32-microblaze.c (microblaze_elf_relocate_section): Likewise.
 264         * elf32-moxie.c (moxie_elf_relocate_section): Likewise.
 265         * elf32-msp430.c (elf32_msp430_relocate_section): Likewise.
 266         * elf32-mt.c (mt_elf_relocate_section): Likewise.
 267         * elf32-nds32.c (nds32_elf_relocate_section): Likewise.
 268         * elf32-nios2.c (nios2_elf32_relocate_section): Likewise.
 269         * elf32-or1k.c (or1k_elf_relocate_section): Likewise.
 270         * elf32-ppc.c (ppc_elf_relocate_section): Likewise.
 271         * elf32-pru.c (pru_elf32_relocate_section): Likewise.
 272         * elf32-rl78.c (rl78_elf_relocate_section): Likewise.
 273         * elf32-rx.c (rx_elf_relocate_section): Likewise.
 274         * elf32-s390.c (elf_s390_relocate_section): Likewise.
 275         * elf32-score.c (s3_bfd_score_elf_relocate_section): Likewise.
 276         (_bfd_score_elf_relocate_section): Likewise.
 277         * elf32-score.h (s7_bfd_score_elf_relocate_section): Likewise.
 278         * elf32-score7.c (s7_bfd_score_elf_relocate_section): Likewise.
 279         * elf32-sh.c (sh_elf_relocate_section): Likewise.
 280         * elf32-tic6x.c (elf32_tic6x_relocate_section): Likewise.
 281         * elf32-tilepro.c (tilepro_elf_relocate_section): Likewise.
 282         * elf32-v850.c (v850_elf_relocate_section): Likewise.
 283         * elf32-vax.c (elf_vax_relocate_section): Likewise.
 284         * elf32-visium.c (visium_elf_relocate_section): Likewise.
 285         * elf32-xc16x.c (elf32_xc16x_relocate_section): Likewise.
 286         * elf32-xstormy16.c (xstormy16_elf_relocate_section): Likewise.
 287         * elf32-xtensa.c (elf_xtensa_relocate_section): Likewise.
 288         * elf32-z80.c (z80_elf_relocate_section): Likewise.
 289         * elf64-alpha.c (elf64_alpha_relocate_section_r): Likewise.
 290         (elf64_alpha_relocate_section): Likewise.
 291         * elf64-bpf.c (bpf_elf_relocate_section): Likewise.
 292         * elf64-hppa.c (elf64_hppa_relocate_section): Likewise.
 293         * elf64-ia64-vms.c (elf64_ia64_relocate_section): Likewise.
 294         * elf64-mmix.c (mmix_elf_relocate_section): Likewise.
 295         * elf64-ppc.c (ppc64_elf_relocate_section): Likewise.
 296         * elf64-s390.c (elf_s390_relocate_section): Likewise.
 297         * elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
 298         * elfnn-aarch64.c (elfNN_aarch64_relocate_section): Likewise.
 299         * elfnn-ia64.c (elfNN_ia64_relocate_section): Likewise.
 300         * elfnn-riscv.c (riscv_elf_relocate_section): Likewise.
 301         * elfxx-mips.c (_bfd_mips_elf_relocate_section): Likewise.
 302         * elfxx-mips.h (_bfd_mips_elf_relocate_section): Likewise.
 303         * elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Likewise.
 304         * elfxx-sparc.h (_bfd_sparc_elf_relocate_section): Likewise.
 305         * elfxx-tilegx.c (tilegx_elf_relocate_section): Likewise.
 306         * elfxx-tilegx.h (tilegx_elf_relocate_section): Likewise.
 307
 308 2021-03-26  Keith Seitz  <keiths@redhat.com>
 309
 310         * elfcore.h (_bfd_elf_core_find_build_id): Seek file
 311         offset of program headers after calling elf_read_notes.
 312
 313 2021-03-23  Jan Beulich  <jbeulich@suse.com>
 314
 315         * dwarf2.c (read_indexed_string): Rename index to idx.
 316
 317 2021-03-22  Martin Liska  <mliska@suse.cz>
 318
 319         * bfd-in.h (startswith): Add startswith function.
 320         (CONST_STRNEQ): Remove.
 321         * bfd-in2.h (startswith): Regenerate with make headers.
 322         * archive.c (bfd_slurp_armap): Replace usage of CONST_STRNEQ with startswith.
 323         (_bfd_slurp_extended_name_table): Likewise.
 324         * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
 325         * bfd.c (bfd_get_sign_extend_vma): Likewise.
 326         (bfd_convert_section_size): Likewise.
 327         (bfd_convert_section_contents): Likewise.
 328         * coff-stgo32.c (go32exe_create_stub): Likewise.
 329         (go32exe_check_format): Likewise.
 330         * coffcode.h (styp_to_sec_flags): Likewise.
 331         (GNU_DEBUGALTLINK): Likewise.
 332         * coffgen.c (_bfd_coff_section_already_linked): Likewise.
 333         (coff_gc_sweep): Likewise.
 334         (bfd_coff_gc_sections): Likewise.
 335         * cofflink.c (coff_link_add_symbols): Likewise.
 336         (process_embedded_commands): Likewise.
 337         * compress.c (bfd_is_section_compressed_with_header): Likewise.
 338         (bfd_init_section_decompress_status): Likewise.
 339         * dwarf2.c (find_debug_info): Likewise.
 340         (place_sections): Likewise.
 341         * ecoff.c (_bfd_ecoff_slurp_armap): Likewise.
 342         * elf-m10300.c (_bfd_mn10300_elf_size_dynamic_sections): Likewise.
 343         * elf.c (_bfd_elf_make_section_from_shdr): Likewise.
 344         (assign_section_numbers): Likewise.
 345         (elfcore_grok_win32pstatus): Likewise.
 346         * elf32-arm.c (cmse_scan): Likewise.
 347         (elf32_arm_gc_mark_extra_sections): Likewise.
 348         (elf32_arm_size_dynamic_sections): Likewise.
 349         (is_arm_elf_unwind_section_name): Likewise.
 350         * elf32-bfin.c (bfin_size_dynamic_sections): Likewise.
 351         * elf32-cr16.c (_bfd_cr16_elf_size_dynamic_sections): Likewise.
 352         * elf32-cris.c (elf_cris_size_dynamic_sections): Likewise.
 353         * elf32-csky.c (csky_elf_size_dynamic_sections): Likewise.
 354         * elf32-hppa.c (elf32_hppa_size_dynamic_sections): Likewise.
 355         * elf32-iq2000.c (iq2000_elf_check_relocs): Likewise.
 356         * elf32-lm32.c (lm32_elf_size_dynamic_sections): Likewise.
 357         * elf32-m32r.c (m32r_elf_size_dynamic_sections): Likewise.
 358         * elf32-m68k.c (elf_m68k_size_dynamic_sections): Likewise.
 359         * elf32-metag.c (elf_metag_size_dynamic_sections): Likewise.
 360         * elf32-msp430.c (msp430_elf_relax_delete_bytes): Likewise.
 361         * elf32-nios2.c (nios2_elf32_size_dynamic_sections): Likewise.
 362         * elf32-or1k.c (or1k_elf_size_dynamic_sections): Likewise.
 363         * elf32-ppc.c (ppc_elf_size_dynamic_sections): Likewise.
 364         * elf32-s390.c (elf_s390_size_dynamic_sections): Likewise.
 365         * elf32-score.c (s3_bfd_score_elf_size_dynamic_sections): Likewise.
 366         * elf32-score7.c (s7_bfd_score_elf_size_dynamic_sections): Likewise.
 367         * elf32-sh.c (sh_elf_size_dynamic_sections): Likewise.
 368         * elf32-tic6x.c (is_tic6x_elf_unwind_section_name): Likewise.
 369         (elf32_tic6x_size_dynamic_sections): Likewise.
 370         * elf32-vax.c (elf_vax_size_dynamic_sections): Likewise.
 371         * elf32-xtensa.c (elf_xtensa_size_dynamic_sections): Likewise.
 372         (xtensa_is_insntable_section): Likewise.
 373         (xtensa_is_littable_section): Likewise.
 374         (xtensa_is_proptable_section): Likewise.
 375         (xtensa_property_section_name): Likewise.
 376         (xtensa_callback_required_dependence): Likewise.
 377         * elf64-alpha.c (elf64_alpha_size_dynamic_sections): Likewise.
 378         * elf64-hppa.c (elf64_hppa_size_dynamic_sections): Likewise.
 379         * elf64-ia64-vms.c (is_unwind_section_name): Likewise.
 380         (get_reloc_section): Likewise.
 381         (elf64_ia64_size_dynamic_sections): Likewise.
 382         (elf64_ia64_object_p): Likewise.
 383         * elf64-mmix.c (mmix_elf_add_symbol_hook): Likewise.
 384         * elf64-ppc.c (ppc64_elf_size_dynamic_sections): Likewise.
 385         * elf64-s390.c (elf_s390_size_dynamic_sections): Likewise.
 386         * elflink.c (elf_link_add_object_symbols): Likewise.
 387         (_bfd_elf_gc_mark_extra_sections): Likewise.
 388         (bfd_elf_parse_eh_frame_entries): Likewise.
 389         (_bfd_elf_section_already_linked): Likewise.
 390         * elfnn-aarch64.c (elfNN_aarch64_size_dynamic_sections): Likewise.
 391         * elfnn-ia64.c (is_unwind_section_name): Likewise.
 392         (elfNN_ia64_size_dynamic_sections): Likewise.
 393         (elfNN_ia64_object_p): Likewise.
 394         * elfxx-mips.c (FN_STUB_P): Likewise.
 395         (CALL_STUB_P): Likewise.
 396         (CALL_FP_STUB_P): Likewise.
 397         (_bfd_mips_elf_section_from_shdr): Likewise.
 398         (_bfd_mips_elf_fake_sections): Likewise.
 399         (_bfd_mips_elf_size_dynamic_sections): Likewise.
 400         (_bfd_mips_final_write_processing): Likewise.
 401         (_bfd_mips_elf_final_link): Likewise.
 402         * elfxx-sparc.c (_bfd_sparc_elf_size_dynamic_sections): Likewise.
 403         * elfxx-x86.c (elf_i386_is_reloc_section): Likewise.
 404         (elf_x86_64_is_reloc_section): Likewise.
 405         * hpux-core.c (thread_section_p): Likewise.
 406         * libcoff.h (bfd_pei_p): Likewise.
 407         * linker.c (REAL): Likewise.
 408         (unwrap_hash_lookup): Likewise.
 409         (_bfd_generic_link_add_one_symbol): Likewise.
 410         * mmo.c (mmo_internal_write_section): Likewise.
 411         * osf-core.c (osf_core_core_file_p): Likewise.
 412         * pef.c (bfd_pef_print_symbol): Likewise.
 413         * pei-x86_64.c (pex64_print_all_pdata_sections): Likewise.
 414         * som.c (som_slurp_symbol_table): Likewise.
 415         (som_slurp_armap): Likewise.
 416         * wasm-module.c (wasm_compute_custom_section_file_position): Likewise.
 417
 418 2021-03-22  Jan Beulich  <jbeulich@suse.com>
 419
 420         * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Add missing
 421         language translation wrapping to _bfd_error_handler()
 422         invocations.
 423
 424 2021-03-21  Alan Modra  <amodra@gmail.com>
 425
 426         * bfd-in.h (startswith): New inline.
 427         (CONST_STRNEQ): Use startswith.
 428         * bfd-in2.h: Regenerate.
 429
 430 2021-03-20  Alan Modra  <amodra@gmail.com>
 431
 432         PR 27590
 433         * elf.c (_bfd_elf_make_section_from_shdr): Remove SHF_EXCLUDE
 434         test for .gnu.debuglto*.
 435
 436 2021-03-18  H.J. Lu  <hongjiu.lu@intel.com>
 437
 438         PR ld/27590
 439         * elf.c (_bfd_elf_make_section_from_shdr): Treat
 440         .gnu.debuglto_.debug_ section as debugging section unless it is
 441         marked with SHF_EXCLUDE.
 442         * elflink.c (elf_create_symbuf): Revert commit 994b2513281.
 443         (bfd_elf_match_symbols_in_sections): Ignore section symbols when
 444         matching non-debugging sections or linkonce section with comdat
 445         section.
 446
 447 2021-03-18  H.J. Lu  <hongjiu.lu@intel.com>
 448
 449         PR ld/27587
 450         * dwarf2.c (read_attribute_value): Check version >= 3 for
 451         DW_FORM_ref_addr.
 452
 453 2021-03-16  Nick Clifton  <nickc@redhat.com>
 454
 455         * peXXigen.c (_bfd_XXi_swap_aux_out): Avoid potential buffer
 456         overrun by using sizeof of the destination x_fname field as the
 457         limit for a memcpy.
 458
 459 2021-03-16  Kuan-Lin Chen  <kuanlinchentw@gmail.com>
 460
 461         * elfxx-riscv.c (riscv_std_z_ext_strtab): Add zba, zbb and zbc.
 462
 463 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 464
 465         * reloc.c (BFD_RELOC_PPC_TLS_LE, BFD_RELOC_PPC_TLS_IE,
 466         BFD_RELOC_PPC_TLS_M, BFD_RELOC_PPC_TLS_ML, BFD_RELOC_PPC64_TLS_GD,
 467         BFD_RELOC_PPC64_TLS_LD, BFD_RELOC_PPC64_TLS_LE,
 468         BFD_RELOC_PPC64_TLS_IE, BFD_RELOC_PPC64_TLS_M,
 469         BFD_RELOC_PPC64_TLS_ML): New relocations.
 470         * bfd-in2.h: Regenerate.
 471         * libbfd.h: Regenerate.
 472         * coff-rs6000.c (xcoff_calculate_relocation): Call
 473         xcoff_reloc_type_tls for TLS relocations.
 474         (xcoff_howto_table): Implement TLS relocations.
 475         (_bfd_xcoff_reloc_type_lookup): Add cases TLS relocations.
 476         (xcoff_reloc_type_tls): New function.
 477         * coff64-rs6000.c (xcoff_calculate_relocation): Likewise.
 478         (xcoff_howto_table): Likewise.
 479         (_bfd_xcoff_reloc_type_lookup): Likewise.
 480         * coffcode.h (sec_to_styp_flags): Handle TLS sections.
 481         (styp_to_sec_flags): Likewise.
 482         (coff_compute_section_file_positions): Avoid file offset
 483         optimisation for .data when the previous section is .tdata.
 484         (coff_write_object_contents): Handle TLS sections.
 485         * coffswap.h (coff_swap_aouthdr_out): Add support for
 486         new fields in aouthdr.
 487         * libxcoff.h (xcoff_reloc_type_tls): Add prototype.
 488         * xcofflink.c (xcoff_link_add_symbols): Handle XMC_UL.
 489         (xcoff_need_ldrel_p): Add cases for TLS relocations.
 490         (xcoff_create_ldrel): Add l_symndx for TLS sections.
 491
 492 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 493
 494         * reloc.c (BFD_RELOC_PPC_TOC16_HI, BFD_RELOC_PPC_TOC16_LO):
 495         New relocations.
 496         * bfd-in2.h: Regenerate.
 497         * libbfd.h: Regenerate.
 498         * coff-rs6000.c (xcoff_calculate_relocation): Call
 499         xcoff_reloc_type_toc for R_TOCU and R_TOCL.
 500         (xcoff_howto_table): Remove src_mask for TOC relocations.
 501         Add R_TOCU and R_TOCL howtos.
 502         (_bfd_xcoff_reloc_type_lookup): Add cases for
 503         BFD_RELOC_PPC_TOC16_HI and BFD_RELOC_PPC_TOC16_LO.
 504         (xcoff_reloc_type_toc): Compute the whole offset.
 505         Implement R_TOCU and R_TOCL.
 506         * coff64-rs6000.c (xcoff64_calculate_relocation):
 507         Likewise.
 508         (xcoff64_howto_table): Likewise.
 509         (xcoff64_reloc_type_lookup): Likewise.
 510
 511 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 512
 513         * coff-rs6000.c (xcoff_calculate_relocation): Correct and
 514         add new relocations.
 515         (xcoff_howto_table): Likewise.
 516         (xcoff_rtype2howto): Increase r_type maximum value.
 517         (xcoff_ppc_relocate_section): Reuse predefined HOWTOs instead
 518         of create a new one from scratch.  Enable only some relocations
 519         to have a changing r_size.
 520         * coff64-rs6000.c (xcoff64_calculate_relocation): Likewise.
 521         (xcoff64_howto_table): Likewise.
 522         (xcoff64_rtype2howto): Likewise.
 523         (xcoff64_ppc_relocate_section): Likewise.
 524         * libxcoff.h (XCOFF_MAX_CALCULATE_RELOCATION): Fix value.
 525
 526 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 527
 528         * coff64-rs6000.c (xcoff64_ppc_relocate_section): Move.
 529
 530 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 531
 532         * coff64-rs6000.c (xcoff64_write_object_contents): Remove.
 533         * coffcode.h (coff_write_object_contents): Add bfd_mach_ppc_620
 534         support for o_cputype field.  Avoid creating an empty a.out header
 535         for XCOFF64.
 536
 537 2021-03-12  Clément Chigot  <clement.chigot@atos.net>
 538
 539         * coff64-rs6000.c (xcoff64_create_csect_from_smclas): Add
 540         missing smclass.
 541
 542 2021-03-11  Nelson Chu  <nelson.chu@sifive.com>
 543
 544         * elfnn-riscv.c (riscv_elf_link_hash_table): New boolean
 545         restart_relax, used to check if we need to run the whole
 546         relaxations from relax pass 0 to 2 again.
 547         (riscv_elf_link_hash_table_create): Init restart_relax to FALSE.
 548         (_bfd_riscv_relax_align): Remove obsolete sec_flg0 set.
 549         (_bfd_riscv_relax_delete): Set again to TRUE if we do delete the code.
 550         (bfd_elfNN_riscv_restart_relax_sections): New function.  Called by
 551         after_allocation to check if we need to run the whole relaxations again.
 552         (_bfd_riscv_relax_section): We will only enter into the relax pass 3
 553         when the restart_relax is FALSE; At last set restart_relax to TRUE if
 554         again is TRUE, too.
 555         * elfxx-riscv.h (bfd_elf32_riscv_restart_relax_sections): Declaration.
 556         (bfd_elf64_riscv_restart_relax_sections): Likewise.
 557
 558 2021-03-10  Jan Beulich  <jbeulich@suse.com>
 559
 560         * cofflink.c (_bfd_coff_write_global_sym): Range-check symbol
 561         offset.
 562
 563 2021-03-10  Alan Modra  <amodra@gmail.com>
 564             Jan Beulich  <jbeulich@suse.com>
 565
 566         * elf.c (bfd_elf_generic_reloc): Make references between debug
 567         sections use section relative values.
 568
 569 2021-03-09  Jan Beulich  <jbeulich@suse.com>
 570
 571         * peXXigen.c (_bfd_XXi_swap_scnhdr_out): Diagnose out of range RVA.
 572
 573 2021-03-05  H.J. Lu  <hongjiu.lu@intel.com>
 574
 575         PR ld/27425
 576         PR ld/27432
 577         * bfd.c (_bfd_get_link_info): New function.
 578         * elf-bfd.h (output_elf_obj_tdata): Add link_info.
 579         (elf_link_info): New.
 580         * libbfd-in.h (_bfd_get_link_info): New prototype.
 581         * coff-x86_64.c (coff_amd64_reloc): Also subtract __ImageBase for
 582         R_AMD64_IMAGEBASE when generating x86-64 ELF executable.
 583         * pe-x86_64.c: Include "coff/internal.h" and "libcoff.h".
 584         (pex64_link_add_symbols): New function.
 585         (coff_bfd_link_add_symbols): New macro.
 586         * libbfd.h: Regenerated.
 587
 588 2021-03-05  Craig Blackmore  <craig.blackmore@embecosm.com>
 589             Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * elf-bfd.h (elfcore_write_riscv_csr): Declare.
 592         * elf.c (elfcore_grok_riscv_csr): New function.
 593         (elfcore_grok_note): Handle NT_RISCV_CSR.
 594         (elfcore_write_riscv_csr): New function.
 595         (elfcore_write_register_note): Handle '.reg-riscv-csr'.
 596
 597 2021-03-05  Craig Blackmore  <craig.blackmore@embecosm.com>
 598             Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * elfnn-riscv.c (PRPSINFO_PR_FNAME_LENGTH): Define.
 601         (PRPSINFO_PR_PSARGS_LENGTH): Define.
 602         (riscv_write_core_note): New function.
 603         (riscv_elf_grok_psinfo): Make use of two new length defines.
 604         (elf_backend_write_core_note): Define.
 605
 606 2021-03-05  Craig Blackmore  <craig.blackmore@embecosm.com>
 607             Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * elf-bfd.h (elfcore_write_gdb_tdesc): Declare new function.
 610         * elf.c (elfcore_grok_gdb_tdesc): New function.
 611         (elfcore_grok_note): Handle NT_GDB_TDESC.
 612         (elfcore_write_gdb_tdesc): New function.
 613         (elfcore_write_register_note): Handle NT_GDB_TDESC.
 614
 615 2021-03-05  Nick Clifton  <nickc@redhat.com>
 616
 617         PR 27521
 618         * dwarf2.c (is_str_attr): Add DW_FORM_strx* forms.
 619         (read_indexed_string): Placeholder function.
 620         (read_attribute_value): Handle DW_FORM_strx* and DW_FORM_addrx*
 621         forms.
 622
 623 2021-03-05  Alan Modra  <amodra@gmail.com>
 624
 625         * reloc.c (bfd_perform_relocation): Revert 2021-01-12 and
 626         2020-09-16 changes.
 627         * coff-x86_64.c (coff_amd64_reloc): Do more or less the same
 628         adjustments here instead.  Separate pc-relative adjustments
 629         from symbol related adjustments.  Tidy comments and formatting.
 630
 631 2021-03-04  Jan Beulich  <jbeulich@suse.com>
 632
 633         * coffcode.h (sec_to_styp_flags): Don't set IMAGE_SCN_LNK_* in
 634         final PE images.
 635
 636 2021-03-04  Alan Modra  <amodra@gmail.com>
 637
 638         * rs6000-core.c (rs6000coff_core_p): Correct prototype.
 639
 640 2021-03-03  Alan Modra  <amodra@gmail.com>
 641
 642         PR 27500
 643         * elflink.c (_bfd_elf_gc_mark_rsec): Do special start/stop
 644         processing not when start/stop symbol section is unmarked but
 645         on first time a start/stop symbol is processed.
 646
 647 2021-03-03  Alan Modra  <amodra@gmail.com>
 648
 649         * reloc.c: Include x86_64.h rather than internal.h.
 650
 651 2021-03-02  Nick Clifton  <nickc@redhat.com>
 652
 653         PR 27484
 654         * dwarf2.c (scan_unit_for_symbols): Scan twice, once to accumulate
 655         function and variable tags and a second time to resolve their
 656         attributes.
 657
 658 2021-03-02  Nick Alcock  <nick.alcock@oracle.com>
 659
 660         * elf-strtab.c (_bfd_elf_strtab_str): Skip strings with zero refcount.
 661
 662 2021-03-02  Alan Modra  <amodra@gmail.com>
 663
 664         PR 27451
 665         * elf64-ppc.c (ppc64_elf_gc_mark_dynamic_ref): Ignore synthesized
 666         linker defined start/stop symbols when start_stop_gc.
 667
 668 2021-03-02  Alan Modra  <amodra@gmail.com>
 669
 670         * elf64-ppc.c (ppc64_elf_relocate_section): Don't optimise got
 671         indirect to pc-relative or toc-relative for undefined symbols.
 672
 673 2021-03-01  Alan Modra  <amodra@gmail.com>
 674             Fangrui Song <maskray@google.com>
 675
 676         * elflink.c (_bfd_elf_gc_mark_rsec): Ignore synthesized linker
 677         defined start/stop symbols when start_stop_gc.
 678         (bfd_elf_gc_mark_dynamic_ref_symbol): Likewise.
 679         (bfd_elf_define_start_stop): Don't modify ldscript_def syms.
 680         * linker.c (bfd_generic_define_start_stop): Likewise.
 681
 682 2021-02-25  Alan Modra  <amodra@gmail.com>
 683
 684         PR 27441
 685         * elf-bfd.h (struct elf_link_hash_entry): Add ref_ir_nonweak.
 686         * elflink.c (elf_link_add_object_symbols): Set ref_ir_nonweak and
 687         use when deciding an as-needed library should be loaded instead
 688         of using the binding of the library definition.
 689
 690 2021-02-24  Alan Modra  <amodra@gmail.com>
 691
 692         PR 27459
 693         * coff-stgo32.c (go32exe_check_format): Sanity check size of
 694         header to avoid a buffer overflow.
 695
 696 2021-02-22  Alan Modra  <amodra@gmail.com>
 697
 698         * coff-rs6000.c (_bfd_xcoff_reloc_type_lookup): Remove BFD_RELOC_16.
 699         * coff64-rs6000.c (xcoff64_reloc_type_lookup): Likewise.
 700
 701 2021-02-19  Nelson Chu  <nelson.chu@sifive.com>
 702
 703         PR 27158
 704         * elfnn-riscv.c (perform_relocation): Updated encoding macros.
 705         (_bfd_riscv_relax_call): Likewise.
 706         (_bfd_riscv_relax_lui): Likewise.
 707         * elfxx-riscv.c (howto_table): Likewise.
 708
 709 2021-02-18  Nelson Chu  <nelson.chu@sifive.com>
 710
 711         * Makefile.am: Added cpu-riscv.h.
 712         * Makefile.in: Regenerated.
 713         * po/SRC-POTFILES.in: Regenerated.
 714         * cpu-riscv.h: Added to support spec versions controlling.
 715         Also added extern arrays and functions for cpu-riscv.c.
 716         (enum riscv_spec_class): Define all spec classes here uniformly.
 717         (struct riscv_spec): Added for all specs.
 718         (RISCV_GET_SPEC_CLASS): Added to reduce repeated code.
 719         (RISCV_GET_SPEC_NAME): Likewise.
 720         (RISCV_GET_ISA_SPEC_CLASS): Added to get ISA spec class.
 721         (RISCV_GET_PRIV_SPEC_CLASS): Added to get privileged spec class.
 722         (RISCV_GET_PRIV_SPEC_NAME): Added to get privileged spec name.
 723         * cpu-riscv.c (struct priv_spec_t): Replaced with struct riscv_spec.
 724         (riscv_get_priv_spec_class): Replaced with RISCV_GET_PRIV_SPEC_CLASS.
 725         (riscv_get_priv_spec_name): Replaced with RISCV_GET_PRIV_SPEC_NAME.
 726         (riscv_priv_specs): Moved below.
 727         (riscv_get_priv_spec_class_from_numbers): Likewise, updated.
 728         (riscv_isa_specs): Moved from include/opcode/riscv.h.
 729         * elfnn-riscv.c: Included cpu-riscv.h.
 730         (riscv_merge_attributes): Initialize in_priv_spec and out_priv_spec.
 731         * elfxx-riscv.c: Included cpu-riscv.h and opcode/riscv.h.
 732         (RISCV_UNKNOWN_VERSION): Moved from include/opcode/riscv.h.
 733         * elfxx-riscv.h: Removed extern functions to cpu-riscv.h.
 734
 735 2021-02-17  Alan Modra  <amodra@gmail.com>
 736
 737         * wasm-module.c: Guard include of limits.h.
 738         (CHAR_BIT): Provide backup define.
 739         (wasm_read_leb128): Use CHAR_BIT to size "result" in bits.
 740         Correct signed overflow checking.
 741
 742 2021-02-17  Nelson Chu  <nelson.chu@sifive.com>
 743
 744         PR 27200
 745         * elfnn-riscv.c (_bfd_riscv_elf_merge_private_bfd_data): Delay
 746         copying the elf flags from input BFD to output BFD, until we have
 747         checked if the input BFD has no code section or not.  Also fix the
 748         problem that we only check the first section rather than the entire
 749         sections for input BFD.
 750
 751 2021-02-16  Alan Modra  <amodra@gmail.com>
 752
 753         * libbfd.c (_bfd_read_unsigned_leb128): Avoid excessive shift.
 754         (_bfd_safe_read_leb128, _bfd_read_signed_leb128): Likewise.
 755
 756 2021-02-15  Jan Beulich  <jbeulich@suse.com>
 757
 758         * doc/Makefile.am: Replace "cp -p" by "$(LN_S)".
 759         * doc/Makefile.in: Re-generate.
 760
 761 2021-02-15  Alan Modra  <amodra@gmail.com>
 762
 763         * elf32-nds32.c (nds32_get_section_contents): Replace
 764         bfd_malloc_and_get_section with bfd_get_full_section_contents.
 765         (nds32_elf_relax_delete_blanks): Init contents.
 766         (nds32_elf_relax_section, nds32_relax_fp_as_gp): Likewise.
 767
 768 2021-02-15  Alan Modra  <amodra@gmail.com>
 769
 770         * coff-alpha.c (alpha_ecoff_get_relocated_section_contents): Use
 771         bfd_get_full_section_contents.
 772
 773 2021-02-14  Alan Modra  <amodra@gmail.com>
 774
 775         * elfxx-mips.c (_bfd_elf_mips_get_relocated_section_contents): Apply
 776         all fixes to bfd_generic_get_relocated_section_contents since this
 777         function was split out.
 778
 779 2021-02-11  Alan Modra  <amodra@gmail.com>
 780
 781         * config.bfd: Remove ia64 from obsolete list.
 782
 783 2021-02-11  Alan Modra  <amodra@gmail.com>
 784
 785         PR ld/22269
 786         * elfnn-ia64.c: Revert 2017-10-14 git commit db41f6eb5234.
 787
 788 2021-02-11  Alan Modra  <amodra@gmail.com>
 789
 790         PR 27294
 791         * elf32-avr.c (avr_elf32_load_records_from_section): Use
 792         bfd_malloc_and_get_section.  Use bfd_byte* vars and remove then
 793         unnecessary casts.
 794
 795 2021-02-11  Alan Modra  <amodra@gmail.com>
 796
 797         PR 27291
 798         * section.c (bfd_get_section_contents): Avoid possible overflow
 799         when range checking offset and count.
 800         (bfd_set_section_contents): Likewise.
 801
 802 2021-02-03  Nick Alcock  <nick.alcock@oracle.com>
 803
 804         * configure.ac (SHARED_LIBADD): Remove explicit -lintl population in
 805         favour of LIBINTL.
 806         * configure: Regenerated.
 807
 808 2021-02-09  Alan Modra  <amodra@gmail.com>
 809
 810         * config.bfd (arm*-*-symbianelf*): Move from obsolete to removed.
 811         * configure.ac: Delete symbian entries.
 812         * elf-bfd.h (enum elf_target_os): Delete is_symbian.
 813         * elf32-arm.c: Remove symbian support.  Formatting.
 814         * targets.c: Delete symbian entries.
 815         * configure: Regenerate.
 816
 817 2021-02-04  H.J. Lu  <hongjiu.lu@intel.com>
 818
 819         PR ld/19609
 820         * elf64-x86-64.c (elf_x86_64_relocate_section): Provide more
 821         info when failed to convert GOTPCREL relocation.
 822
 823 2021-02-04  Nelson Chu  <nelson.chu@sifive.com>
 824
 825         * elfxx-riscv.c (riscv_parse_prefixed_ext): Removed zb*.
 826
 827 2021-02-04  Alan Modra  <amodra@gmail.com>
 828
 829         PR 27311
 830         * elflink.c (elf_link_add_object_symbols): Don't pull in as-needed
 831         libraries for IR references on pass over libraries after LTO
 832         recompilation.
 833
 834 2021-02-03  Alan Modra  <amodra@gmail.com>
 835
 836         PR 27311
 837         * elflink.c (_bfd_elf_add_default_symbol): Revert last two changes.
 838         (elf_link_add_object_symbols): Here too.  Don't pull in as-needed
 839         libraries when H is an indirect symbol after calling
 840         _bfd_elf_add_default_symbol.
 841
 842 2021-02-03  Alan Modra  <amodra@gmail.com>
 843
 844         PR 27311
 845         * elflink.c (_bfd_elf_add_default_symbol): Clear override when
 846         undecorated symbol will have a different version.
 847
 848 2021-02-02  Alan Modra  <amodra@gmail.com>
 849
 850         PR 27311
 851         * elflink.c (_bfd_elf_add_default_symbol): Add override parameter.
 852         Use when handling default versioned symbol.  Rename existing
 853         override variable to nondef_override and use for non-default
 854         versioned symbol.
 855         (elf_link_add_object_symbols): Adjust call to suit.  Don't
 856         pull in as-needed libraries when override is set.
 857
 858 2021-02-01  Emery Hemingway  <ehmry@posteo.net>
 859
 860         * config.bfd: Add *-*-genode* as a target for AArch64 and x86.
 861
 862 2021-02-01  Egor Vishnyakov  <lenvampir@yandex.ru>
 863
 864         PR 27254
 865         * elf32-rl78.c (rl78_elf_relocate_section): Fix calculation of
 866         offset for the R_RL78_RH_SADDR relocation.
 867
 868 2021-01-29  Alan Modra  <amodra@gmail.com>
 869
 870         PR 27271
 871         * elflink.c (bfd_elf_link_record_dynamic_symbol): Don't segfault
 872         on symbols defined in absolute or other special sections.
 873
 874 2021-01-28  Alan Modra  <amodra@gmail.com>
 875
 876         PR 27259
 877         * elflink.c (_bfd_elf_gc_mark_extra_sections): Use linker_mark to
 878         prevent endless looping of linked-to sections.
 879
 880 2020-12-17  Mihails Strasuns  <mihails.strasuns@intel.com>
 881
 882         * bfd-elf.h (elfcore_write_file_note): New function.
 883         * elf.c (elfcore_write_file_note): New function.
 884
 885 2021-01-26  Alan Modra  <amodra@gmail.com>
 886
 887         * elf32-ft32.c (ft32_reloc_type_lookup): Don't miss ft32_reloc_map[0].
 888
 889 2021-01-24  H.J. Lu  <hongjiu.lu@intel.com>
 890
 891         PR binutils/27231
 892         * dwarf2.c (read_rnglists): Ignore empty range when parsing line
 893         number tables.
 894
 895 2021-01-23  H.J. Lu  <hongjiu.lu@intel.com>
 896
 897         PR binutils/27231
 898         * dwarf2.c (read_rnglists): Advance rngs_ptr after
 899         _bfd_safe_read_leb128 when parsing DW_RLE_offset_pair.
 900
 901 2021-01-20  Alan Modra  <amodra@gmail.com>
 902
 903         * elf32-ppc.c: Delete outdated comment.
 904         (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): Define.
 905         * elf64-ppc.c (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): Define.
 906
 907 2021-01-20  Alan Modra  <amodra@gmail.com>
 908
 909         * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't assume
 910         section symbols are present.
 911
 912 2021-01-19  Alan Modra  <amodra@gmail.com>
 913
 914         * elf64-ppc.c (elf_hash_entry): New inline function.  Use
 915         throughout to replace casts.
 916         (branch_reloc_hash_match): Remove const from params.
 917         (use_local_plt): New function.
 918         (allocate_dynrelocs, ppc_build_one_stub, ppc_size_one_stub),
 919         (build_global_entry_stubs_and_plt, ppc64_elf_relocate_section):
 920         Use use_local_plt.
 921         * elf32-ppc.c (use_local_plt): New function.
 922         (allocate_dynrelocs, ppc_elf_relocate_section),
 923         (write_global_sym_plt): Use use_local_plt.
 924
 925 2021-01-17  H.J. Lu  <hongjiu.lu@intel.com>
 926
 927         PR ld/27193
 928         * elflink.c (elf_create_symbuf): Also ignore section symbols.
 929
 930 2021-01-16  H.J. Lu  <hongjiu.lu@intel.com>
 931
 932         PR ld/23169
 933         * elfxx-x86.c (_bfd_x86_elf_link_fixup_ifunc_symbol): Don't
 934         check pointer_equality_needed.
 935
 936 2021-01-15  H.J. Lu  <hongjiu.lu@intel.com>
 937
 938         * elf-linker-x86.h (elf_linker_x86_params): Add
 939         report_relative_reloc.
 940         * elf32-i386.c (elf_i386_relocate_section): Call
 941         _bfd_x86_elf_link_report_relative_reloc to report relative
 942         relocations for -z report-relative-reloc.
 943         (elf_i386_finish_dynamic_symbol): Likewse.
 944         * elf64-x86-64.c (elf_x86_64_relocate_section): Likewse.
 945         (elf_x86_64_finish_dynamic_symbol): Likewse.
 946         * elfxx-x86.c (_bfd_x86_elf_link_report_relative_reloc): New
 947         function.
 948         * elfxx-x86.h (_bfd_x86_elf_link_report_relative_reloc): New
 949         prototype.
 950
 951 2021-01-16  Alan Modra  <amodra@gmail.com>
 952
 953         * compress.c (decompress_contents): Tidy inflateEnd result test.
 954
 955 2021-01-16  Alan Modra  <amodra@gmail.com>
 956
 957         PR 26002
 958         * elflink.c (elf_link_output_extsym): Use version 1 in
 959         .gnu.version for undefined unversioned symbols.
 960
 961 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 962
 963         * elfnn-riscv.c (riscv_relax_delete_bytes): Fixed the indent that
 964         caused the by previous commit accidentally.
 965
 966 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 967
 968         * elfnn-riscv.c: Indent, labels and GNU coding standards tidy,
 969         also aligned the code.
 970
 971 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 972
 973         * elfnn-riscv.c (riscv_merge_attributes): Fix typos of messages.
 974
 975 2021-01-15  Nelson Chu  <nelson.chu@sifive.com>
 976
 977         * elfnn-riscv.c: Comments tidy and improvement.
 978         * elfxx-riscv.c: Likewise.
 979         * elfxx-riscv.h: Likewise.
 980
 981 2021-01-14  H.J. Lu  <hongjiu.lu@intel.com>
 982
 983         PR ld/26688
 984         * elf32-bfin.c (bfinfdpic_relocate_section): Skip non SEC_ALLOC
 985         section for R_BFIN_FUNCDESC.
 986
 987 2021-01-14  Nick Clifton  <nickc@redhat.com>
 988
 989         * elf.c (elfcore_grok_win32pstatus): Check for a note type of 0.
 990
 991 2021-01-13  Alan Modra  <amodra@gmail.com>
 992
 993         * Makefile.in: Regenerate.
 994         * doc/Makefile.in: Regenerate.
 995
 996 2021-01-13  Alan Modra  <amodra@gmail.com>
 997
 998         PR 27160
 999         * section.c (struct bfd_section): Remove pattern field.
1000         (BFD_FAKE_SECTION): Adjust to suit.
1001         * bfd-in2.h: Regenerate.
1002         * elflink.c (compare_link_order, elf_fixup_link_order): Delete.
1003         (bfd_elf_final_link): Don't call elf_fixup_link_order.
1004
1005 2021-01-12  H.J. Lu  <hongjiu.lu@intel.com>
1006
1007         PR binutils/26792
1008         * configure.ac: Use GNU_MAKE_JOBSERVER.
1009         * aclocal.m4: Regenerated.
1010         * configure: Likewise.
1011
1012 2021-01-12  H.J. Lu  <hongjiu.lu@intel.com>
1013
1014         PR ld/27171
1015         * reloc.c (bfd_perform_relocation): Adjust R_AMD64_DIR64 and
1016         R_AMD64_DIR32 relocations for PE/x86-64 inputs.
1017
1018 2021-01-11  H.J. Lu  <hongjiu.lu@intel.com>
1019
1020         PR ld/27173
1021         * configure: Regenerated.
1022
1023 2021-01-11  Nick Clifton  <nickc@redhat.com>
1024
1025         * po/fr.po: Updated French translation.
1026         * po/pt.po: Updated Portuguese translation.
1027         * po/sr.po: Updated Serbian translation.
1028         * po/uk.po: Updated Ukranian translation.
1029
1030 2021-01-09  H.J. Lu  <hongjiu.lu@intel.com>
1031
1032         * configure: Regenerated.
1033
1034 2021-01-09  H.J. Lu  <hongjiu.lu@intel.com>
1035
1036         PR ld/27166
1037         * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Handle
1038         -z lam-u48 and -z lam-u57.
1039
1040 2021-01-09  Nick Clifton  <nickc@redhat.com>
1041
1042         * version.m4: Change to 2.36.50.
1043         * configure: Regenerate.
1044         * po/bfd.pot: Regenerate.
1045
1046 2021-01-09  Nick Clifton  <nickc@redhat.com>
1047
1048         * 2.36 release branch crated.
1049
1050 2021-01-08  H.J. Lu  <hongjiu.lu@intel.com>
1051
1052         * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Also set
1053         LAM_U57 when setting LAM_U48.
1054
1055 2021-01-08  H.J. Lu  <hongjiu.lu@intel.com>
1056
1057         PR ld/26256
1058         PR ld/27160
1059         * elflink.c (elf_fixup_link_order): Verify that fixing up
1060         SHF_LINK_ORDER doesn't increase the output section size.
1061
1062 2021-01-09  Alan Modra  <amodra@gmail.com>
1063
1064         * configure: Regenerate.
1065
1066 2021-01-07  Samuel Thibault  <samuel.thibault@gnu.org>
1067
1068         * configure: Regenerate.
1069
1070 2021-01-07  H.J. Lu  <hongjiu.lu@intel.com>
1071
1072         PR 27109
1073         * aix386-core.c (core_aix386_vec): Initialize
1074         keep_unused_section_symbol to TARGET_KEEP_UNUSED_SECTION_SYMBOLS.
1075         * aout-target.h (MY (vec)): Likewise.
1076         * binary.c (binary_vec): Likewise.
1077         * cisco-core.c (core_cisco_be_vec): Likewise.
1078         (core_cisco_le_vec): Likewise.
1079         * coff-alpha.c (alpha_ecoff_le_vec): Likewise.
1080         * coff-i386.c (TARGET_SYM): Likewise.
1081         (TARGET_SYM_BIG): Likewise.
1082         * coff-ia64.c (TARGET_SYM): Likewise.
1083         * coff-mips.c (mips_ecoff_le_vec): Likewise.
1084         (mips_ecoff_be_vec): Likewise.
1085         (mips_ecoff_bele_vec): Likewise.
1086         * coff-rs6000.c (rs6000_xcoff_vec): Likewise.
1087         (powerpc_xcoff_vec): Likewise.
1088         * coff-sh.c (sh_coff_small_vec): Likewise.
1089         (sh_coff_small_le_vec): Likewise.
1090         * coff-tic30.c (tic30_coff_vec): Likewise.
1091         * coff-tic54x.c (tic54x_coff0_vec): Likewise.
1092         (tic54x_coff0_beh_vec): Likewise.
1093         (tic54x_coff1_vec): Likewise.
1094         (tic54x_coff1_beh_vec): Likewise.
1095         (tic54x_coff2_vec): Likewise.
1096         (tic54x_coff2_beh_vec): Likewise.
1097         * coff-x86_64.c (TARGET_SYM): Likewise.
1098         (TARGET_SYM_BIG): Likewise.
1099         * coff64-rs6000.c (rs6000_xcoff64_vec): Likewise.
1100         (rs6000_xcoff64_aix_vec): Likewise.
1101         * coffcode.h (CREATE_BIG_COFF_TARGET_VEC): Likewise.
1102         (CREATE_BIGHDR_COFF_TARGET_VEC): Likewise.
1103         (CREATE_LITTLE_COFF_TARGET_VEC): Likewise.
1104         * elfxx-target.h (TARGET_BIG_SYM): Likewise.
1105         (TARGET_LITTLE_SYM): Likewise.
1106         * hppabsd-core.c (core_hppabsd_vec): Likewise.
1107         * hpux-core.c (core_hpux_vec): Likewise.
1108         * i386msdos.c (i386_msdos_vec): Likewise.
1109         * ihex.c (ihex_vec): Likewise.
1110         * irix-core.c (core_irix_vec): Likewise.
1111         * mach-o-target.c (TARGET_NAME): Likewise.
1112         * mmo.c (mmix_mmo_vec): Likewise.
1113         * netbsd-core.c (core_netbsd_vec): Likewise.
1114         * osf-core.c (core_osf_vec): Likewise.
1115         * pdp11.c (MY (vec)): Likewise.
1116         * pef.c (pef_vec): Likewise.
1117         (pef_xlib_vec): Likewise.
1118         * plugin.c (plugin_vec): Likewise.
1119         * ppcboot.c (powerpc_boot_vec): Likewise.
1120         * ptrace-core.c (core_ptrace_vec): Likewise.
1121         * sco5-core.c (core_sco5_vec): Likewise.
1122         * som.c (hppa_som_vec): Likewise.
1123         * srec.c (srec_vec): Likewise.
1124         (symbolsrec_vec): Likewise.
1125         * tekhex.c (tekhex_vec): Likewise.
1126         * trad-core.c (core_trad_vec): Likewise.
1127         * verilog.c (verilog_vec): Likewise.
1128         * vms-alpha.c (alpha_vms_vec): Likewise.
1129         * vms-lib.c (alpha_vms_lib_txt_vec): Likewise.
1130         * wasm-module.c (wasm_vec): Likewise.
1131         * xsym.c (sym_vec): Likewise.
1132         * elf.c (ignore_section_sym): Return TRUE if BSF_SECTION_SYM_USED
1133         isn't set.
1134         (elf_map_symbols): Don't include ignored section symbols.
1135         * elfcode.h (elf_slurp_symbol_table): Also set
1136         BSF_SECTION_SYM_USED on STT_SECTION symbols.
1137         * elflink.c (bfd_elf_final_link): Generated section symbols only
1138         when emitting relocations or reqired.
1139         * elfxx-x86.h (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): New.
1140         * syms.c (BSF_SECTION_SYM_USED): New.
1141         * targets.c (TARGET_KEEP_UNUSED_SECTION_SYMBOLS): New.
1142         (bfd_target): Add keep_unused_section_symbols.
1143         (bfd_keep_unused_section_symbols): New.
1144         * bfd-in2.h: Regenerated.
1145
1146 2021-01-07  Nick Clifton  <nickc@redhat.com>
1147
1148         PR 25713
1149         * bfdio.c (_bfd_real_fopen): For Win32 convert relative paths to
1150         absolute paths and check to see if they are longer than MAX_PATH.
1151
1152 2021-01-07  Philipp Tomsich  <prt@gnu.org>
1153
1154         * elfxx-riscv.c (riscv_std_z_ext_strtab): Added zihintpause.
1155
1156 2021-01-07  Claire Xenia Wolf  <claire@symbioticeda.com>
1157             Jim Wilson  <jimw@sifive.com>
1158             Andrew Waterman  <andrew@sifive.com>
1159             Maxim Blinov  <maxim.blinov@embecosm.com>
1160             Kito Cheng  <kito.cheng@sifive.com>
1161             Nelson Chu  <nelson.chu@sifive.com>
1162
1163         * elfxx-riscv.c (riscv_std_z_ext_strtab): Added zba, zbb and zbc.
1164
1165 2021-01-06  H.J. Lu  <hongjiu.lu@intel.com>
1166
1167         * elf32-bfin.c (bfin_check_relocs): Check bfd_link_hash_indirect.
1168         (bfinfdpic_check_relocs): Likewise.
1169
1170 2021-01-06  Alan Modra  <amodra@gmail.com>
1171
1172         * elf32-score.c (s3_bfd_score_info_to_howto): Report an error
1173         on unknown r_type.
1174         * elf32-score7.c (s7_bfd_score_info_to_howto): Likewise.
1175
1176 2021-01-06  Alan Modra  <amodra@gmail.com>
1177
1178         * config.bfd (sparc-*-solaris2*): Add sparc_elf32_vec.
1179         (sparc64-*-solaris2*): Add sparc_elf64_vec and
1180         sparc_elf32_vec.
1181
1182 2021-01-06  Marcus Comstedt  <marcus@mc.pp.se>
1183
1184         * config.bfd: Added targets riscv64be*-*-*, riscv32be*-*-* and
1185         riscvbe*-*-*.  Also added riscv_elf[32|64]_be_vec.
1186         * configure.ac: Handle riscv_elf[32|64]_be_vec.
1187         * configure: Regenerate.
1188         * elfnn-riscv.c: Include <limits.h> and define CHAR_BIT for
1189         riscv_is_insn_reloc.
1190         (riscv_get_insn): RISC-V instructions are always little endian, but
1191         bfd_get may be used for big-endian, so add new riscv_get_insn to handle
1192         the insturctions.
1193         (riscv_put_insn): Likewsie.
1194         (riscv_is_insn_reloc): Check if we are relocaing an instruction.
1195         (perform_relocation): Call riscv_is_insn_reloc to decide if we should
1196         use riscv_[get|put]_insn or bfd_[get|put].
1197         (riscv_zero_pcrel_hi_reloc): Use riscv_[get|put]_insn, bfd_[get|put]l32
1198         or bfd_[get|put]l16 for code.
1199         (riscv_elf_relocate_section): Likewise.
1200         (riscv_elf_finish_dynamic_symbol): Likewise.
1201         (riscv_elf_finish_dynamic_sections): Likewise.
1202         (_bfd_riscv_relax_call): Likewise.
1203         (_bfd_riscv_relax_lui): Likewise.
1204         (_bfd_riscv_relax_align): Likewise.
1205         (_bfd_riscv_relax_pc): Likewise.
1206         (riscv_elf_object_p): Handled for big endian.
1207         (TARGET_BIG_SYM, TARGET_BIG_NAME): Defined.
1208         * targets.c: Add riscv_elf[32|64]_be_vec.
1209         (_bfd_target_vector): Likewise.
1210
1211 2021-01-05  Alan Modra  <amodra@gmail.com>
1212
1213         * elflink.c (bfd_elf_link_record_dynamic_symbol): Handle no_export
1214         for relocatable executable.
1215
1216 2021-01-05  Alan Modra  <amodra@gmail.com>
1217
1218         * vms-alpha.c (_bfd_vms_slurp_egsd): Read flags after size check.
1219
1220 2021-01-05  Nelson Chu  <nelson.chu@sifive.com>
1221
1222         * elfnn-riscv.c (allocate_dynrelocs): When we are generating pde,
1223         make sure gp symbol is output as a dynamic symbol.
1224
1225 2021-01-04  H.J. Lu  <hongjiu.lu@intel.com>
1226
1227         PR ld/26256
1228         * elflink.c (compare_link_order): Place unordered sections before
1229         ordered sections.
1230         (elf_fixup_link_order): Add a link info argument.  Allow mixed
1231         ordered and unordered input sections for non-relocatable link.
1232         Sort the consecutive bfd_indirect_link_order sections with the
1233         same pattern.  Change the offsets of the bfd_indirect_link_order
1234         sections only.
1235         (bfd_elf_final_link): Pass info to elf_fixup_link_order.
1236         * section.c (bfd_section): Add pattern.
1237         (BFD_FAKE_SECTION): Initialize pattern to NULL.
1238         * bfd-in2.h: Regenerated.
1239
1240 2021-01-04  Alexander Fedotov  <alfedotov@gmail.com>
1241
1242         * elf32-arm.c (elf32_arm_print_private_bfd_data): Prefix hex value
1243         of private flags with 0x.
1244         * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
1245
1246 2021-01-04  Alan Modra  <amodra@gmail.com>
1247
1248         PR 26822
1249         * elflink.c (elf_link_input_bfd): Use the file base name in
1250         linker generated STT_FILE symbols.
1251
1252 2021-01-04  Nelson Chu  <nelson.chu@sifive.com>
1253
1254         * elfxx-riscv.c (riscv_compare_subsets): Removed static.
1255         * elfxx-riscv.h: Add declaration.
1256         * elfnn-riscv.c (riscv_merge_multi_letter_ext): Use
1257         riscv_compare_subsets to check the orders.
1258         (riscv_skip_prefix): Removed.
1259         (riscv_prefix_cmp): Removed.
1260
1261 2021-01-04  Alan Modra  <amodra@gmail.com>
1262
1263         PR 26741
1264         * elfxx-riscv.c (riscv_parse_prefixed_ext): Free subset after
1265         calculating subset version length.
1266
1267 2021-01-01  Nicolas Boulenguez  <nicolas@debian.org>
1268
1269         * xcofflink.c: Correct spelling in comments.
1270
1271 2021-01-01  Alan Modra  <amodra@gmail.com>
1272
1273         Update year range in copyright notice of all files.
1274
1275 For older changes see ChangeLog-2020
1276 \f
1277 Copyright (C) 2021 Free Software Foundation, Inc.
1278
1279 Copying and distribution of this file, with or without modification,
1280 are permitted in any medium without royalty provided the copyright
1281 notice and this notice are preserved.
1282
1283 Local Variables:
1284 mode: change-log
1285 left-margin: 8
1286 fill-column: 74
1287 version-control: never
1288 End: