]> git.ipfire.org Git - thirdparty/git.git/commitdiff
do_for_each_ref_helper(): mark unused repository parameter
authorJeff King <peff@peff.net>
Mon, 3 Jul 2023 06:44:02 +0000 (02:44 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Jul 2023 00:23:59 +0000 (17:23 -0700)
This function gets a repository parameter because it's a callback for
do_for_each_repo_ref_iterator(). But it's just a wrapper that passes
along each call to a regular each_ref_fn callback, and the latter
doesn't accept a repository argument.

Probably in the long run all of the each_ref_fn callbacks should get a
repository parameter, too. But changing that now would require updates
all over the code base. Until that happens, let's annotate this wrapper
callback to quiet the compiler's -Wunused-parameter warning.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c

diff --git a/refs.c b/refs.c
index c029f64982f2308ebef8e199e9ab926f36d32ae2..edeae90ebb532a071485e0812d66db0637304c47 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -1588,7 +1588,7 @@ struct do_for_each_ref_help {
        void *cb_data;
 };
 
-static int do_for_each_ref_helper(struct repository *r,
+static int do_for_each_ref_helper(struct repository *r UNUSED,
                                  const char *refname,
                                  const struct object_id *oid,
                                  int flags,