]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t5318: use 'test_must_be_empty'
authorTaylor Blau <me@ttaylorr.com>
Wed, 3 Jun 2020 22:21:07 +0000 (16:21 -0600)
committerJunio C Hamano <gitster@pobox.com>
Thu, 4 Jun 2020 14:52:54 +0000 (07:52 -0700)
A handful of tests in t5318 use 'test_line_count = 0 ...' to make sure
that some command does not write any output. While correct, it is more
idiomatic to use 'test_must_be_empty' instead. Switch the former
invocations to use the latter instead.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5318-commit-graph.sh

index 424599959c9c31a1392ef584b924a787895906bb..31cbff56776d198bef262f70caed3a69640cdd10 100755 (executable)
@@ -140,7 +140,7 @@ test_expect_success 'Add more commits' '
 test_expect_success 'commit-graph write progress off for redirected stderr' '
        cd "$TRASH_DIRECTORY/full" &&
        git commit-graph write 2>err &&
-       test_line_count = 0 err
+       test_must_be_empty err
 '
 
 test_expect_success 'commit-graph write force progress on for stderr' '
@@ -152,13 +152,13 @@ test_expect_success 'commit-graph write force progress on for stderr' '
 test_expect_success 'commit-graph write with the --no-progress option' '
        cd "$TRASH_DIRECTORY/full" &&
        git commit-graph write --no-progress 2>err &&
-       test_line_count = 0 err
+       test_must_be_empty err
 '
 
 test_expect_success 'commit-graph verify progress off for redirected stderr' '
        cd "$TRASH_DIRECTORY/full" &&
        git commit-graph verify 2>err &&
-       test_line_count = 0 err
+       test_must_be_empty err
 '
 
 test_expect_success 'commit-graph verify force progress on for stderr' '
@@ -170,7 +170,7 @@ test_expect_success 'commit-graph verify force progress on for stderr' '
 test_expect_success 'commit-graph verify with the --no-progress option' '
        cd "$TRASH_DIRECTORY/full" &&
        git commit-graph verify --no-progress 2>err &&
-       test_line_count = 0 err
+       test_must_be_empty err
 '
 
 # Current graph structure: