t: local VAR="VAL" (quote command substitution)

Future-proof test scripts that do

	local VAR=VAL

without quoting VAL (which is OK in POSIX but broken in some shells)
that is a $(command substitution).

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t4011-diff-symlink.sh b/t/t4011-diff-symlink.sh
index d7a5f7ae780c0319514fd949dacac98cfe6ce23b..bc8ba887191fac4fd602fe5c2406f3e66a4becfa 100755 (executable)
--- a/t/t4011-diff-symlink.sh
+++ b/t/t4011-diff-symlink.sh
@@ -13,13 +13,13 @@ TEST_PASSES_SANITIZE_LEAK=true
 
 # Print the short OID of a symlink with the given name.
 symlink_oid () {
-       local oid=$(printf "%s" "$1" | git hash-object --stdin) &&
+       local oid="$(printf "%s" "$1" | git hash-object --stdin)" &&
        git rev-parse --short "$oid"
 }
 
 # Print the short OID of the given file.
 short_oid () {
-       local oid=$(git hash-object "$1") &&
+       local oid="$(git hash-object "$1")" &&
        git rev-parse --short "$oid"
 }
 

diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index fc607084717a5084d6ad0f61bf6cab8f375bf7a3..4cc7d74f110808222d8e6cf39f82c849f4751006 100644 (file)
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1840,7 +1840,7 @@ test_subcommand () {
                shift
        fi
 
-       local expr=$(printf '"%s",' "$@")
+       local expr="$(printf '"%s",' "$@")"
        expr="${expr%,}"
 
        if test -n "$negate"