]> git.ipfire.org Git - thirdparty/git.git/commitdiff
verify-tag: drop signal.h include
authorJeff King <peff@peff.net>
Tue, 18 Jun 2019 15:54:09 +0000 (11:54 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 19 Jun 2019 15:19:21 +0000 (08:19 -0700)
There's no reason verify-tag.c needs to include signal.h. It's already
in git-compat-util.h, which we properly include as the first header.
And there doesn't seem to be a particular reason for this include; it's
just an artifact from the file creation in 2ae68fcb78 (Make verify-tag a
builtin., 2007-07-27).

Likewise verify-commit.c has the same issue, probably because it was
created using verify-tag as a template in d07b00b7f3 (verify-commit:
scriptable commit signature verification, 2014-06-23).

These includes are probably just redundant, and not hurting anything by
circumventing the order that git-compat-util.h tries to impose, since
we'll always have loaded git-compat-util by the time we get to these. So
this is just a cleanup, and shouldn't fix or break any platforms.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/verify-commit.c
builtin/verify-tag.c

index 7772c07ed7a1e13e3b6ecabc4642cefd6d16b333..4e93914e593bdc751dd2ca5496097ecffbc1d41f 100644 (file)
@@ -12,7 +12,6 @@
 #include "repository.h"
 #include "commit.h"
 #include "run-command.h"
-#include <signal.h>
 #include "parse-options.h"
 #include "gpg-interface.h"
 
index 6fa04b751ac1d6ae18b8a42e700e2cefa6427a41..f45136a06ba76077891d9e5fae545ee8c297ddff 100644 (file)
@@ -10,7 +10,6 @@
 #include "builtin.h"
 #include "tag.h"
 #include "run-command.h"
-#include <signal.h>
 #include "parse-options.h"
 #include "gpg-interface.h"
 #include "ref-filter.h"