]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t1401: stop treating FETCH_HEAD as real reference
authorPatrick Steinhardt <ps@pks.im>
Wed, 29 Nov 2023 07:24:49 +0000 (08:24 +0100)
committerJunio C Hamano <gitster@pobox.com>
Sun, 3 Dec 2023 02:50:23 +0000 (11:50 +0900)
One of the tests in t1401 asserts that we can create a symref from a
symbolic reference to a top-level reference, which is done by linking
from `refs/heads/top-level` to `FETCH_HEAD`. But `FETCH_HEAD` is not a
proper reference and doesn't even follow the loose reference format, so
it is not a good candidate for the logic under test.

Refactor the test to use `ORIG_HEAD` instead of `FETCH_HEAD`. This also
works with other backends than the reffiles one.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t1401-symbolic-ref.sh

index c7745e1bf69e910c2d66a61bb8bef36b45473a56..3241d3591799415e423e4f6155e4111de778a964 100755 (executable)
@@ -171,8 +171,8 @@ test_expect_success 'symbolic-ref refuses invalid target for non-HEAD' '
 '
 
 test_expect_success 'symbolic-ref allows top-level target for non-HEAD' '
-       git symbolic-ref refs/heads/top-level FETCH_HEAD &&
-       git update-ref FETCH_HEAD HEAD &&
+       git symbolic-ref refs/heads/top-level ORIG_HEAD &&
+       git update-ref ORIG_HEAD HEAD &&
        test_cmp_rev top-level HEAD
 '