]> git.ipfire.org Git - thirdparty/git.git/commitdiff
grep API: plug memory leaks by freeing "header_list"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Mon, 6 Feb 2023 23:07:51 +0000 (00:07 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 6 Feb 2023 23:34:39 +0000 (15:34 -0800)
When the "header_list" struct member was added in [1], freeing this
field was neglected. Fix that now, so that commands like

./git -P log -1 --color=always --author=A origin/master

will run leak-free.

1. 80235ba79ef ("log --author=me --grep=it" should find intersection,
   not union, 2010-01-17)

Helped-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
grep.c

diff --git a/grep.c b/grep.c
index f8708e1fd20842868e717a9684feee6854a5fe8c..92ece4b7fa34a3ffb2a0c61b973b7cac33aa5b35 100644 (file)
--- a/grep.c
+++ b/grep.c
@@ -795,6 +795,7 @@ static void free_grep_pat(struct grep_pat *pattern)
 void free_grep_patterns(struct grep_opt *opt)
 {
        free_grep_pat(opt->pattern_list);
+       free_grep_pat(opt->header_list);
 
        if (opt->pattern_expression)
                free_pattern_expr(opt->pattern_expression);