modprobe: Write error messages to syslog if stderr is unavailable

The man page modprobe(8) states for the --syslog option:
"This is also automatically enabled when stderr is unavailable."
but it wasn't happening.

This commit now makes modprobe write to syslog if stderr is closed.

diff --git a/tools/modprobe.c b/tools/modprobe.c
index 2a2ae21f537051cab47f433106277dec63583d9d..3240c2b72edd2a996a905918f090f4f05c9f888c 100644 (file)
--- a/tools/modprobe.c
+++ b/tools/modprobe.c
@@ -819,6 +819,7 @@ static int do_modprobe(int argc, char **orig_argv)
        int do_show_modversions = 0;
        int do_show_exports = 0;
        int err;
+       struct stat stat_buf;
 
        argv = prepend_options_from_env(&argc, orig_argv);
        if (argv == NULL) {
@@ -947,6 +948,12 @@ static int do_modprobe(int argc, char **orig_argv)
        args = argv + optind;
        nargs = argc - optind;
 
+       if (!use_syslog &&
+           (!stderr ||
+            fileno(stderr) == -1 ||
+            fstat(fileno(stderr), &stat_buf)))
+               use_syslog = 1;
+
        log_open(use_syslog);
 
        if (!do_show_config) {