]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Grow: block -n on external volumes.
authorMateusz Kusiak <mateusz.kusiak@intel.com>
Thu, 19 May 2022 07:16:08 +0000 (09:16 +0200)
committerJes Sorensen <jsorensen@fb.com>
Thu, 9 Jun 2022 22:13:11 +0000 (18:13 -0400)
Performing --raid-devices on external metadata volume should be blocked
as it causes unwanted behaviour.

Eg. Performing
mdadm -G /dev/md/volume -l10 -n4
on r0_d2 inside 4 disk container, returns
mdadm: Need 2 spares to avoid degraded array, only have 0.

Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Grow.c

diff --git a/Grow.c b/Grow.c
index 8a242b0f8725e2a3add42b26720e2cbc764e005d..f6efbc48dafd53c149c2664d5808e356f3bf6b62 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -1892,6 +1892,14 @@ int Grow_reshape(char *devname, int fd,
 
                if (retval) {
                        pr_err("Cannot read superblock for %s\n", devname);
+                       close(cfd);
+                       free(subarray);
+                       return 1;
+               }
+
+               if (s->raiddisks && subarray) {
+                       pr_err("--raid-devices operation can be performed on a container only\n");
+                       close(cfd);
                        free(subarray);
                        return 1;
                }