]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Monitor: don't complain about non-monitorable arrays in mdadm.conf
authorNeilBrown <neilb@suse.de>
Wed, 24 Oct 2012 02:09:09 +0000 (13:09 +1100)
committerNeilBrown <neilb@suse.de>
Wed, 24 Oct 2012 02:09:23 +0000 (13:09 +1100)
If we are asked to monitor a RAID0 or Linear - which cannot be
monitored - we complain with "Device Disappeared .... Wrong-Level".

However if the RAID0 or Linear is being requested because it is
in mdadm.conf then the message is inappropriate and confusing.

So track which arrays are added from the config file, and suppress
that message in that case.

Reported-by: "Johnson Yan" <johnson_yan@usish.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Monitor.c

index e6b054b51c7fa219bb0cc27246ec72ab52eb4ef3..a53a18cf73e8e69ff9ba1fc944dad2da87026af9 100644 (file)
--- a/Monitor.c
+++ b/Monitor.c
@@ -42,6 +42,7 @@ struct state {
        int err;
        char *spare_group;
        int active, working, failed, spare, raid;
+       int from_config;
        int expected_spares;
        int devstate[MaxDisks];
        dev_t devid[MaxDisks];
@@ -184,6 +185,7 @@ int Monitor(struct mddev_dev *devlist,
                        st->next = statelist;
                        st->devnum = INT_MAX;
                        st->percent = RESYNC_UNKNOWN;
+                       st->from_config = 1;
                        st->expected_spares = mdlist->spare_disks;
                        if (mdlist->spare_group)
                                st->spare_group = strdup(mdlist->spare_group);
@@ -483,7 +485,7 @@ static int check_array(struct state *st, struct mdstat_ent *mdstat,
         * have a device disappear than all of them that can
         */
        if (array.level == 0 || array.level == -1) {
-               if (!st->err)
+               if (!st->err && !st->from_config)
                        alert("DeviceDisappeared", dev, "Wrong-Level", ainfo);
                st->err = 1;
                close(fd);