]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Incremental: Remove unnecesary NULL pointer checks when calling sysfs_free()
authorJes Sorensen <Jes.Sorensen@redhat.com>
Mon, 7 Mar 2016 17:07:45 +0000 (12:07 -0500)
committerJes Sorensen <Jes.Sorensen@redhat.com>
Tue, 8 Mar 2016 17:19:03 +0000 (12:19 -0500)
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Incremental.c

index 24fd8276a49b00539b123752ec76bdf749f66119..ba97b008187975681fb2dd65b4378878f2a735ea 100644 (file)
@@ -644,8 +644,7 @@ out:
                close(mdfd);
        if (policy)
                dev_policy_free(policy);
-       if (sra)
-               sysfs_free(sra);
+       sysfs_free(sra);
        return rv;
 out_unlock:
        map_unlock(&map);
@@ -989,8 +988,7 @@ static int array_try_spare(char *devname, int *dfdp, struct dev_policy *pol,
                                   sizeof(target->uuid)) == 0 &&
                            sra->array.failed_disks > 0) {
                                /* This is our target!! */
-                               if (chosen)
-                                       sysfs_free(chosen);
+                               sysfs_free(chosen);
                                chosen = sra;
                                sra = NULL;
                                /* skip to end so we don't check any more */
@@ -1022,8 +1020,7 @@ static int array_try_spare(char *devname, int *dfdp, struct dev_policy *pol,
                        sra = NULL;
                }
        next:
-               if (sra)
-                       sysfs_free(sra);
+               sysfs_free(sra);
                if (st != st2)
                        free(st2);
                if (dl)