Detected by Coverity. CID
1529581: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).
* determined by the user
*/
int
-clientBeginRequest(const HttpRequestMethod& method, char const *url, CSCB * streamcallback,
- CSD * streamdetach, ClientStreamData streamdata, HttpHeader const *header,
+clientBeginRequest(const HttpRequestMethod &method, char const *url, CSCB *streamcallback,
+ CSD *streamdetach, const ClientStreamData &streamdata, const HttpHeader *header,
char *tailbuf, size_t taillen, const MasterXaction::Pointer &mx)
{
size_t url_sz;
class MemObject;
/* client_side_request.c - client side request related routines (pure logic) */
-int clientBeginRequest(const HttpRequestMethod&, char const *, CSCB *, CSD *, ClientStreamData, HttpHeader const *, char *, size_t, const MasterXactionPointer &);
+int clientBeginRequest(const HttpRequestMethod &, char const *, CSCB *, CSD *, const ClientStreamData &, const HttpHeader *, char *, size_t, const MasterXactionPointer &);
class ClientHttpRequest
#if USE_ADAPTATION
debugs(86, 5, "ESIIncludeStart: Starting subrequest with url '" << tempUrl << "'");
const auto mx = MasterXaction::MakePortless<XactionInitiator::initEsi>();
- if (clientBeginRequest(Http::METHOD_GET, tempUrl, esiBufferRecipient, esiBufferDetach, stream.getRaw(), &tempheaders, stream->localbuffer->buf, HTTP_REQBUF_SZ, mx)) {
+ if (clientBeginRequest(Http::METHOD_GET, tempUrl, esiBufferRecipient, esiBufferDetach, stream, &tempheaders, stream->localbuffer->buf, HTTP_REQBUF_SZ, mx)) {
debugs(86, DBG_CRITICAL, "ERROR: starting new ESI subrequest failed");
}