]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/core/smack-setup.c
tree-wide: use -EBADF for fd initialization
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 19 Dec 2022 12:07:42 +0000 (13:07 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 19 Dec 2022 14:00:57 +0000 (15:00 +0100)
commit254d1313ae5a69c08c9b93032aaaf3d6083cfc07
tree067102a36abe6bf597c26a42d79018a1060c9007
parentcbff793ffb280d9d11e5d7b1dc3964276491bee8
tree-wide: use -EBADF for fd initialization

-1 was used everywhere, but -EBADF or -EBADFD started being used in various
places. Let's make things consistent in the new style.

Note that there are two candidates:
EBADF 9 Bad file descriptor
EBADFD 77 File descriptor in bad state

Since we're initializating the fd, we're just assigning a value that means
"no fd yet", so it's just a bad file descriptor, and the first errno fits
better. If instead we had a valid file descriptor that became invalid because
of some operation or state change, the other errno would fit better.

In some places, initialization is dropped if unnecessary.
284 files changed:
coccinelle/safe_close.cocci
docs/BLOCK_DEVICE_LOCKING.md
src/activate/activate.c
src/analyze/analyze-inspect-elf.c
src/basic/chase-symlinks.c
src/basic/chattr-util.c
src/basic/efivars.c
src/basic/fd-util.c
src/basic/fd-util.h
src/basic/fileio.c
src/basic/fs-util.c
src/basic/locale-util.c
src/basic/log.c
src/basic/memfd-util.c
src/basic/mkdir.c
src/basic/mountpoint-util.c
src/basic/namespace-util.c
src/basic/os-util.c
src/basic/path-util.c
src/basic/random-util.c
src/basic/recurse-dir.c
src/basic/socket-util.c
src/basic/stat-util.c
src/basic/sync-util.c
src/basic/terminal-util.c
src/basic/time-util.c
src/basic/tmpfile-util.c
src/basic/xattr-util.c
src/boot/bless-boot.c
src/boot/bootctl-install.c
src/boot/bootctl-random-seed.c
src/boot/bootctl-status.c
src/boot/measure.c
src/cgroups-agent/cgroups-agent.c
src/core/automount.c
src/core/bpf-firewall.c
src/core/bpf-lsm.c
src/core/bpf-socket-bind.c
src/core/dbus-manager.c
src/core/dbus-path.c
src/core/dbus-socket.c
src/core/dbus.c
src/core/dynamic-user.c
src/core/efi-random.c
src/core/execute.c
src/core/ima-setup.c
src/core/import-creds.c
src/core/load-fragment.c
src/core/main.c
src/core/manager-serialize.c
src/core/manager.c
src/core/mount.c
src/core/namespace.c
src/core/path.c
src/core/restrict-ifaces.c
src/core/service.c
src/core/show-status.c
src/core/smack-setup.c
src/core/socket.c
src/core/swap.c
src/core/unit.c
src/coredump/coredump.c
src/coredump/coredumpctl.c
src/creds/creds.c
src/dissect/dissect.c
src/fsck/fsck.c
src/fuzz/fuzz-bootspec.c
src/fuzz/fuzz-catalog.c
src/getty-generator/getty-generator.c
src/home/homectl.c
src/home/homed-home-bus.c
src/home/homed-home.c
src/home/homed-manager.c
src/home/homed-operation.c
src/home/homework-directory.c
src/home/homework-fscrypt.c
src/home/homework-luks.c
src/home/homework-mount.c
src/home/homework.c
src/home/homework.h
src/home/pam_systemd_home.c
src/import/export-raw.c
src/import/export-tar.c
src/import/export.c
src/import/import-fs.c
src/import/import-raw.c
src/import/import-tar.c
src/import/import.c
src/import/importd.c
src/import/pull-job.c
src/import/pull-raw.c
src/import/test-qcow2.c
src/journal-remote/fuzz-journal-remote.c
src/journal-remote/journal-gatewayd.c
src/journal-remote/journal-remote.c
src/journal/cat.c
src/journal/fuzz-journald-native-fd.c
src/journal/fuzz-journald.c
src/journal/journalctl.c
src/journal/journald-console.c
src/journal/journald-kmsg.c
src/journal/journald-server.c
src/journal/journald-stream.c
src/libsystemd-network/lldp-network.c
src/libsystemd-network/sd-dhcp-client.c
src/libsystemd-network/sd-dhcp-server.c
src/libsystemd-network/sd-dhcp6-client.c
src/libsystemd-network/sd-ipv4acd.c
src/libsystemd-network/sd-lldp-rx.c
src/libsystemd-network/sd-lldp-tx.c
src/libsystemd-network/sd-ndisc.c
src/libsystemd-network/sd-radv.c
src/libsystemd/sd-bus/bus-container.c
src/libsystemd/sd-bus/bus-message.c
src/libsystemd/sd-bus/sd-bus.c
src/libsystemd/sd-bus/test-bus-watch-bind.c
src/libsystemd/sd-daemon/sd-daemon.c
src/libsystemd/sd-device/device-util.c
src/libsystemd/sd-device/sd-device.c
src/libsystemd/sd-device/test-sd-device.c
src/libsystemd/sd-event/event-util.c
src/libsystemd/sd-event/sd-event.c
src/libsystemd/sd-event/test-event.c
src/libsystemd/sd-id128/id128-util.c
src/libsystemd/sd-journal/catalog.c
src/libsystemd/sd-journal/journal-authenticate.c
src/libsystemd/sd-journal/journal-send.c
src/libsystemd/sd-journal/journal-vacuum.c
src/libsystemd/sd-journal/journal-verify.c
src/libsystemd/sd-journal/sd-journal.c
src/libsystemd/sd-journal/test-catalog.c
src/libsystemd/sd-login/sd-login.c
src/libsystemd/sd-netlink/netlink-util.c
src/libsystemd/sd-netlink/sd-netlink.c
src/libsystemd/sd-network/sd-network.c
src/libsystemd/sd-resolve/sd-resolve.c
src/libudev/libudev-queue.c
src/login/inhibit.c
src/login/logind-button.c
src/login/logind-core.c
src/login/logind-dbus.c
src/login/logind-inhibit.c
src/login/logind-seat.c
src/login/logind-session-dbus.c
src/login/logind-session-device.c
src/login/logind-session.c
src/login/logind.c
src/login/pam_systemd.c
src/machine/image-dbus.c
src/machine/machine-dbus.c
src/machine/machinectl.c
src/machine/machined-dbus.c
src/machine/operation.c
src/network/netdev/tuntap.c
src/network/networkctl.c
src/network/networkd-manager.c
src/nspawn/nspawn-cgroup.c
src/nspawn/nspawn-expose-ports.c
src/nspawn/nspawn-patch-uid.c
src/nspawn/nspawn-setuid.c
src/nspawn/nspawn.c
src/oom/oomctl.c
src/oom/oomd-manager-bus.c
src/oom/test-oomd-util.c
src/partition/growfs.c
src/partition/makefs.c
src/partition/repart.c
src/portable/portable.c
src/portable/portabled-bus.c
src/portable/portabled-image-bus.c
src/portable/portabled-operation.c
src/pstore/pstore.c
src/random-seed/random-seed.c
src/reply-password/reply-password.c
src/resolve/resolved-dns-scope.c
src/resolve/resolved-dns-stream.c
src/resolve/resolved-dns-stub.c
src/resolve/resolved-dns-transaction.c
src/resolve/resolved-manager.c
src/resolve/test-resolved-stream.c
src/shared/acpi-fpdt.c
src/shared/ask-password-api.c
src/shared/base-filesystem.c
src/shared/blockdev-util.c
src/shared/bootspec.c
src/shared/bpf-program.c
src/shared/btrfs-util.c
src/shared/cgroup-show.c
src/shared/chown-recursive.c
src/shared/clock-util.c
src/shared/copy.c
src/shared/creds-util.c
src/shared/data-fd-util.c
src/shared/discover-image.c
src/shared/dissect-image.c
src/shared/dissect-image.h
src/shared/dm-util.c
src/shared/ethtool-util.c
src/shared/exec-util.c
src/shared/fdset.c
src/shared/find-esp.c
src/shared/install-file.c
src/shared/install.c
src/shared/local-addresses.c
src/shared/lockfile-util.c
src/shared/lockfile-util.h
src/shared/logs-show.c
src/shared/loop-util.c
src/shared/machine-id-setup.c
src/shared/mkfs-util.c
src/shared/mount-util.c
src/shared/nscd-flush.c
src/shared/ptyfwd.c
src/shared/reboot-util.c
src/shared/selinux-util.c
src/shared/sleep-config.c
src/shared/smack-util.c
src/shared/socket-label.c
src/shared/specifier.c
src/shared/switch-root.c
src/shared/tests.c
src/shared/udev-util.c
src/shared/utmp-wtmp.c
src/shared/varlink.c
src/shared/watchdog.c
src/shutdown/umount.c
src/sleep/sleep.c
src/socket-proxy/socket-proxyd.c
src/systemctl/fuzz-systemctl-parse-argv.c
src/systemctl/systemctl-sysv-compat.c
src/sysupdate/sysupdate-resource.c
src/test/test-acl-util.c
src/test/test-chase-symlinks.c
src/test/test-copy.c
src/test/test-data-fd-util.c
src/test/test-fd-util.c
src/test/test-fdset.c
src/test/test-fileio.c
src/test/test-fs-util.c
src/test/test-glob-util.c
src/test/test-id128.c
src/test/test-io-util.c
src/test/test-loop-block.c
src/test/test-mountpoint-util.c
src/test/test-namespace.c
src/test/test-path-util.c
src/test/test-process-util.c
src/test/test-psi-util.c
src/test/test-seccomp.c
src/test/test-selinux.c
src/test/test-sigbus.c
src/test/test-sleep.c
src/test/test-socket-util.c
src/test/test-stat-util.c
src/test/test-tmpfiles.c
src/test/test-varlink.c
src/test/test-xattr-util.c
src/timesync/timesyncd.c
src/timesync/wait-sync.c
src/tmpfiles/offline-passwd.c
src/tmpfiles/tmpfiles.c
src/tty-ask-password-agent/tty-ask-password-agent.c
src/udev/ata_id/ata_id.c
src/udev/cdrom_id/cdrom_id.c
src/udev/fido_id/fido_id.c
src/udev/mtd_probe/mtd_probe.c
src/udev/net/link-config.c
src/udev/scsi_id/scsi_serial.c
src/udev/udev-builtin-blkid.c
src/udev/udev-builtin-btrfs.c
src/udev/udev-builtin-input_id.c
src/udev/udev-builtin-keyboard.c
src/udev/udev-builtin-usb_id.c
src/udev/udev-node.c
src/udev/udev-watch.c
src/udev/udevadm-lock.c
src/udev/udevd.c
src/udev/v4l_id/v4l_id.c
src/update-utmp/update-utmp.c
src/userdb/userdbctl.c
src/userdb/userdbd-manager.c
src/userdb/userwork.c
src/vconsole/vconsole-setup.c
src/xdg-autostart-generator/fuzz-xdg-desktop.c