sd-device,libudev: make an argument for *_set_sysattr_value() const

diff --git a/TODO b/TODO
index 65dc51b22502533f265a421434013077316ca36f..4dcd102ec58c161579974b38f8da9f5acad8a178 100644 (file)
--- a/TODO
+++ b/TODO
@@ -438,8 +438,6 @@ Features:
 
 * hostnamectl: show root image uuid
 
-* sysfs set api in libudev is not const
-
 * Find a solution for SMACK capabilities stuff:
   http://lists.freedesktop.org/archives/systemd-devel/2014-December/026188.html
 

diff --git a/src/libsystemd/sd-device/sd-device.c b/src/libsystemd/sd-device/sd-device.c
index c61e98fe7264238557c52940fcb06dd2da525236..b020e0d55aeb6b94fe8c5d602ffee6655784e92e 100644 (file)
--- a/src/libsystemd/sd-device/sd-device.c
+++ b/src/libsystemd/sd-device/sd-device.c
@@ -1822,7 +1822,7 @@ static void device_remove_sysattr_value(sd_device *device, const char *_key) {
 
 /* set the attribute and save it in the cache. If a NULL value is passed the
  * attribute is cleared from the cache */
-_public_ int sd_device_set_sysattr_value(sd_device *device, const char *sysattr, char *_value) {
+_public_ int sd_device_set_sysattr_value(sd_device *device, const char *sysattr, const char *_value) {
         _cleanup_close_ int fd = -1;
         _cleanup_free_ char *value = NULL;
         const char *syspath;

diff --git a/src/libudev/libudev-device.c b/src/libudev/libudev-device.c
index 95ad5ced57229251d10e00bc274ccf71736e4c3f..2cd5b48feaa6438e6a08704061257fcbfdfdbe41 100644 (file)
--- a/src/libudev/libudev-device.c
+++ b/src/libudev/libudev-device.c
@@ -763,7 +763,7 @@ _public_ const char *udev_device_get_sysattr_value(struct udev_device *udev_devi
  *
  * Returns: Negative error code on failure or 0 on success.
  **/
-_public_ int udev_device_set_sysattr_value(struct udev_device *udev_device, const char *sysattr, char *value) {
+_public_ int udev_device_set_sysattr_value(struct udev_device *udev_device, const char *sysattr, const char *value) {
         int r;
 
         assert_return(udev_device, -EINVAL);

diff --git a/src/libudev/libudev.h b/src/libudev/libudev.h
index fa4eaeb9690f84240a1366a41b9c7f58deebc17b..fa2a35d1f93397346bb41ac71eebcb9f26b0e158 100644 (file)
--- a/src/libudev/libudev.h
+++ b/src/libudev/libudev.h
@@ -90,7 +90,7 @@ const char *udev_device_get_action(struct udev_device *udev_device);
 unsigned long long int udev_device_get_seqnum(struct udev_device *udev_device);
 unsigned long long int udev_device_get_usec_since_initialized(struct udev_device *udev_device);
 const char *udev_device_get_sysattr_value(struct udev_device *udev_device, const char *sysattr);
-int udev_device_set_sysattr_value(struct udev_device *udev_device, const char *sysattr, char *value);
+int udev_device_set_sysattr_value(struct udev_device *udev_device, const char *sysattr, const char *value);
 int udev_device_has_tag(struct udev_device *udev_device, const char *tag);
 
 /*

diff --git a/src/systemd/sd-device.h b/src/systemd/sd-device.h
index 3a51c135d4fea3e21819d866f1aeeed537ab17f1..406db8866dc7247a8032729a69db80acf6478bd6 100644 (file)
--- a/src/systemd/sd-device.h
+++ b/src/systemd/sd-device.h
@@ -68,7 +68,7 @@ int sd_device_has_tag(sd_device *device, const char *tag);
 int sd_device_get_property_value(sd_device *device, const char *key, const char **value);
 int sd_device_get_sysattr_value(sd_device *device, const char *sysattr, const char **_value);
 
-int sd_device_set_sysattr_value(sd_device *device, const char *sysattr, char *value);
+int sd_device_set_sysattr_value(sd_device *device, const char *sysattr, const char *value);
 
 /* device enumerator */