]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: drop unused flag and counter 22619/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 24 Feb 2022 02:06:29 +0000 (11:06 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 25 Feb 2022 20:49:52 +0000 (05:49 +0900)
src/network/netdev/netdev.c
src/network/networkd-link.c
src/network/networkd-link.h

index 6087e3334c78569cdadcd6e2862e2be643ace5fe..10df9a27dac7d0785d9810388cc7eeb8cb9a07c8 100644 (file)
@@ -707,19 +707,6 @@ static int link_create_stacked_netdev_handler(sd_netlink *rtnl, sd_netlink_messa
 }
 
 static int link_create_stacked_netdev_after_configured_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
-        assert(link);
-        assert(link->create_stacked_netdev_after_configured_messages > 0);
-
-        link->create_stacked_netdev_after_configured_messages--;
-
-        if (link_create_stacked_netdev_handler_internal(rtnl, m, link) <= 0)
-                return 0;
-
-        if (link->create_stacked_netdev_after_configured_messages == 0) {
-                link->stacked_netdevs_after_configured_created = true;
-                log_link_debug(link, "Stacked netdevs created.");
-        }
-
         return 0;
 }
 
@@ -741,13 +728,9 @@ int link_request_stacked_netdev(Link *link, NetDev *netdev) {
                                        &link->create_stacked_netdev_messages,
                                        link_create_stacked_netdev_handler,
                                        NULL);
-        } else {
-                link->stacked_netdevs_after_configured_created = false;
+        } else
                 r = link_queue_request(link, REQUEST_TYPE_NETDEV_STACKED, netdev_ref(netdev), true,
-                                       &link->create_stacked_netdev_after_configured_messages,
-                                       link_create_stacked_netdev_after_configured_handler,
-                                       NULL);
-        }
+                                       NULL, link_create_stacked_netdev_after_configured_handler, NULL);
         if (r < 0)
                 return log_link_error_errno(link, r, "Failed to request stacked netdev '%s': %m",
                                             netdev->ifname);
index 121b4d5e0a10f3c55b94ca892d1a5b84c84d5644..e46f209e7aecaf86170f1922371f3e43b8c1a378 100644 (file)
@@ -562,7 +562,6 @@ static int link_request_stacked_netdevs(Link *link) {
         assert(link);
 
         link->stacked_netdevs_created = false;
-        link->stacked_netdevs_after_configured_created = false;
 
         HASHMAP_FOREACH(netdev, link->network->stacked_netdevs) {
                 r = link_request_stacked_netdev(link, netdev);
@@ -574,8 +573,6 @@ static int link_request_stacked_netdevs(Link *link) {
                 link->stacked_netdevs_created = true;
                 link_check_ready(link);
         }
-        if (link->create_stacked_netdev_after_configured_messages == 0)
-                link->stacked_netdevs_after_configured_created = true;
 
         return 0;
 }
index 1a3231efc0e6867f51f96c5539ed9f154a9d4030..645a8e7147888a4165844d18a699b44e2d283ff3 100644 (file)
@@ -108,7 +108,6 @@ typedef struct Link {
         unsigned set_link_messages;
         unsigned set_flags_messages;
         unsigned create_stacked_netdev_messages;
-        unsigned create_stacked_netdev_after_configured_messages;
 
         Set *addresses;
         Set *neighbors;
@@ -142,7 +141,6 @@ typedef struct Link {
         bool activated:1;
         bool master_set:1;
         bool stacked_netdevs_created:1;
-        bool stacked_netdevs_after_configured_created:1;
 
         sd_dhcp_server *dhcp_server;