]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: always progress DS queries
authorRonan Pigott <ronan@rjp.ie>
Mon, 29 Apr 2024 09:17:23 +0000 (02:17 -0700)
committerLuca Boccassi <luca.boccassi@gmail.com>
Mon, 29 Apr 2024 17:04:11 +0000 (19:04 +0200)
If we request a DS and the resolver offers an unsigned SOA, a new
auxiliary transaction for the DS will be rejected as a loop, and we
might not make any progress toward finding the DS we need. Let's ensure
that we at least always check the parent in this case.

Fixes: 47690634f157 ("resolved: don't request the SOA for every dns label")
src/resolve/resolved-dns-transaction.c

index f6ce3e38db451f3a71975d5cdf10f33f72e3983a..b2817031b54417f0d4adb6629ce0f1a64ee8481f 100644 (file)
@@ -2618,6 +2618,10 @@ int dns_transaction_request_dnssec_keys(DnsTransaction *t) {
                                         return r;
                                 if (r == 0)
                                         continue;
+
+                                /* If we were looking for the DS RR, don't request it again. */
+                                if (dns_transaction_key(t)->type == DNS_TYPE_DS)
+                                        continue;
                         }
 
                         r = dnssec_has_rrsig(t->answer, rr->key);