]> git.ipfire.org Git - thirdparty/gcc.git/blame - gcc/tree-ssa-uninit.c
Correct a function pre/postcondition [PR102403].
[thirdparty/gcc.git] / gcc / tree-ssa-uninit.c
CommitLineData
34f97b94 1/* Predicate aware uninitialized variable warning.
99dee823 2 Copyright (C) 2001-2021 Free Software Foundation, Inc.
34f97b94
XDL
3 Contributed by Xinliang David Li <davidxl@google.com>
4
5This file is part of GCC.
6
7GCC is free software; you can redistribute it and/or modify
8it under the terms of the GNU General Public License as published by
9the Free Software Foundation; either version 3, or (at your option)
10any later version.
11
12GCC is distributed in the hope that it will be useful,
13but WITHOUT ANY WARRANTY; without even the implied warranty of
14MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15GNU General Public License for more details.
16
17You should have received a copy of the GNU General Public License
18along with GCC; see the file COPYING3. If not see
19<http://www.gnu.org/licenses/>. */
20
72be80e4 21#define INCLUDE_STRING
34f97b94
XDL
22#include "config.h"
23#include "system.h"
24#include "coretypes.h"
c7131fb2 25#include "backend.h"
34f97b94 26#include "tree.h"
c7131fb2 27#include "gimple.h"
957060b5 28#include "tree-pass.h"
c7131fb2 29#include "ssa.h"
957060b5
AM
30#include "gimple-pretty-print.h"
31#include "diagnostic-core.h"
40e23961 32#include "fold-const.h"
5be5c238 33#include "gimple-iterator.h"
442b4905 34#include "tree-ssa.h"
666e8e06 35#include "tree-cfg.h"
11ef0b22 36#include "cfghooks.h"
b825a228
MS
37#include "attribs.h"
38#include "builtins.h"
39#include "calls.h"
45f4e2b0 40#include "gimple-range.h"
34f97b94 41
94c12ffa
MS
42#include "gimple-predicate-analysis.h"
43
34f97b94 44/* This implements the pass that does predicate aware warning on uses of
ac0e4fde
ML
45 possibly uninitialized variables. The pass first collects the set of
46 possibly uninitialized SSA names. For each such name, it walks through
47 all its immediate uses. For each immediate use, it rebuilds the condition
48 expression (the predicate) that guards the use. The predicate is then
34f97b94
XDL
49 examined to see if the variable is always defined under that same condition.
50 This is done either by pruning the unrealizable paths that lead to the
51 default definitions or by checking if the predicate set that guards the
52 defining paths is a superset of the use predicate. */
53
34f97b94
XDL
54/* Pointer set of potentially undefined ssa names, i.e.,
55 ssa names that are defined by phi with operands that
56 are not defined or potentially undefined. */
6e2830c3 57static hash_set<tree> *possibly_undefined_names = 0;
34f97b94 58
34f97b94 59/* Returns the first bit position (starting from LSB)
ac0e4fde 60 in mask that is non zero. Returns -1 if the mask is empty. */
34f97b94
XDL
61static int
62get_mask_first_set_bit (unsigned mask)
63{
64 int pos = 0;
65 if (mask == 0)
66 return -1;
67
68 while ((mask & (1 << pos)) == 0)
69 pos++;
70
71 return pos;
72}
73#define MASK_FIRST_SET_BIT(mask) get_mask_first_set_bit (mask)
74
34f97b94 75/* Return true if T, an SSA_NAME, has an undefined value. */
c152901f
AM
76static bool
77has_undefined_value_p (tree t)
34f97b94 78{
c152901f 79 return (ssa_undefined_value_p (t)
5e48d8a0
ML
80 || (possibly_undefined_names
81 && possibly_undefined_names->contains (t)));
34f97b94
XDL
82}
83
e9e2bad7
MS
84/* Return true if EXPR should suppress either uninitialized warning. */
85
86static inline bool
87get_no_uninit_warning (tree expr)
88{
89 return warning_suppressed_p (expr, OPT_Wuninitialized);
90}
91
92/* Suppress both uninitialized warnings for EXPR. */
93
94static inline void
95set_no_uninit_warning (tree expr)
96{
97 suppress_warning (expr, OPT_Wuninitialized);
98}
99
100/* Like has_undefined_value_p, but don't return true if the no-warning
101 bit is set on SSA_NAME_VAR for either uninit warning. */
ba7e83f8
JJ
102
103static inline bool
ac0e4fde
ML
104uninit_undefined_value_p (tree t)
105{
c152901f 106 if (!has_undefined_value_p (t))
ba7e83f8 107 return false;
e9e2bad7
MS
108 if (!SSA_NAME_VAR (t))
109 return true;
110 return !get_no_uninit_warning (SSA_NAME_VAR (t));
ba7e83f8
JJ
111}
112
c152901f
AM
113/* Emit warnings for uninitialized variables. This is done in two passes.
114
115 The first pass notices real uses of SSA names with undefined values.
116 Such uses are unconditionally uninitialized, and we can be certain that
117 such a use is a mistake. This pass is run before most optimizations,
118 so that we catch as many as we can.
119
120 The second pass follows PHI nodes to find uses that are potentially
121 uninitialized. In this case we can't necessarily prove that the use
122 is really uninitialized. This pass is run after most optimizations,
123 so that we thread as many jumps and possible, and delete as much dead
124 code as possible, in order to reduce false positives. We also look
125 again for plain uninitialized variables, since optimization may have
126 changed conditionally uninitialized to unconditionally uninitialized. */
127
4e84e381
MS
128/* Emit warning OPT for variable VAR at the point in the program where
129 the SSA_NAME T is being used uninitialized. The warning text is in
130 MSGID and STMT is the statement that does the uninitialized read.
131 PHI_ARG_LOC is the location of the PHI argument if T and VAR are one,
132 or UNKNOWN_LOCATION otherwise. */
c152901f
AM
133
134static void
4e84e381
MS
135warn_uninit (opt_code opt, tree t, tree var, const char *gmsgid,
136 gimple *context, location_t phi_arg_loc = UNKNOWN_LOCATION)
c152901f 137{
4e84e381
MS
138 /* Bail if the value isn't provably uninitialized. */
139 if (!has_undefined_value_p (t))
140 return;
c152901f 141
e1ec47c4
TP
142 /* Ignore COMPLEX_EXPR as initializing only a part of a complex
143 turns in a COMPLEX_EXPR with the not initialized part being
144 set to its previous (undefined) value. */
145 if (is_gimple_assign (context)
146 && gimple_assign_rhs_code (context) == COMPLEX_EXPR)
147 return;
a25e0b5e 148
149 /* Ignore REALPART_EXPR or IMAGPART_EXPR if its operand is a call to
150 .DEFERRED_INIT. This is for handling the following case correctly:
151
152 1 typedef _Complex float C;
153 2 C foo (int cond)
154 3 {
155 4 C f;
156 5 __imag__ f = 0;
157 6 if (cond)
158 7 {
159 8 __real__ f = 1;
160 9 return f;
161 10 }
162 11 return f;
163 12 }
164
165 with -ftrivial-auto-var-init, compiler will insert the following
166 artificial initialization at line 4:
167 f = .DEFERRED_INIT (f, 2);
168 _1 = REALPART_EXPR <f>;
169
170 without the following special handling, _1 = REALPART_EXPR <f> will
171 be treated as the uninitialized use point, which is incorrect. (the
172 real uninitialized use point is at line 11). */
173 if (is_gimple_assign (context)
174 && (gimple_assign_rhs_code (context) == REALPART_EXPR
175 || gimple_assign_rhs_code (context) == IMAGPART_EXPR))
176 {
177 tree v = gimple_assign_rhs1 (context);
178 if (TREE_CODE (TREE_OPERAND (v, 0)) == SSA_NAME
179 && gimple_call_internal_p (SSA_NAME_DEF_STMT (TREE_OPERAND (v, 0)),
180 IFN_DEFERRED_INIT))
181 return;
182 }
183
50aa64d5 184 /* Anonymous SSA_NAMEs shouldn't be uninitialized, but ssa_undefined_value_p
4e84e381 185 can return true if the def stmt of an anonymous SSA_NAME is COMPLEX_EXPR
50aa64d5
JJ
186 created for conversion from scalar to complex. Use the underlying var of
187 the COMPLEX_EXPRs real part in that case. See PR71581. */
4e84e381
MS
188 if (!var && !SSA_NAME_VAR (t))
189 {
190 gimple *def_stmt = SSA_NAME_DEF_STMT (t);
191 if (is_gimple_assign (def_stmt)
192 && gimple_assign_rhs_code (def_stmt) == COMPLEX_EXPR)
50aa64d5 193 {
4e84e381
MS
194 tree v = gimple_assign_rhs1 (def_stmt);
195 if (TREE_CODE (v) == SSA_NAME
196 && has_undefined_value_p (v)
197 && zerop (gimple_assign_rhs2 (def_stmt)))
198 var = SSA_NAME_VAR (v);
50aa64d5
JJ
199 }
200 }
201
4e84e381 202 if (var == NULL_TREE)
50aa64d5
JJ
203 return;
204
4e84e381
MS
205 /* Avoid warning if we've already done so or if the warning has been
206 suppressed. */
207 if (((warning_suppressed_p (context, OPT_Wuninitialized)
208 || (gimple_assign_single_p (context)
209 && get_no_uninit_warning (gimple_assign_rhs1 (context)))))
210 || get_no_uninit_warning (var))
c152901f
AM
211 return;
212
4e84e381
MS
213 /* Use either the location of the read statement or that of the PHI
214 argument, or that of the uninitialized variable, in that order,
215 whichever is valid. */
216 location_t location;
217 if (gimple_has_location (context))
e1ec47c4 218 location = gimple_location (context);
4e84e381
MS
219 else if (phi_arg_loc != UNKNOWN_LOCATION)
220 location = phi_arg_loc;
e1ec47c4
TP
221 else
222 location = DECL_SOURCE_LOCATION (var);
c152901f 223 location = linemap_resolve_location (line_table, location,
ac0e4fde 224 LRK_SPELLING_LOCATION, NULL);
4e84e381 225
097f82ec 226 auto_diagnostic_group d;
4e84e381
MS
227 if (!warning_at (location, opt, gmsgid, var))
228 return;
229
230 /* Avoid subsequent warnings for reads of the same variable again. */
231 suppress_warning (var, opt);
232
233 /* Issue a note pointing to the read variable unless the warning
234 is at the same location. */
235 location_t var_loc = DECL_SOURCE_LOCATION (var);
236 if (location == var_loc)
237 return;
c152901f 238
9695e1c2 239 inform (var_loc, "%qD was declared here", var);
c152901f
AM
240}
241
e80facb4
RB
242struct check_defs_data
243{
244 /* If we found any may-defs besides must-def clobbers. */
245 bool found_may_defs;
246};
247
6aacd901
MS
248/* Return true if STMT is a call to built-in function all of whose
249 by-reference arguments are const-qualified (i.e., the function can
250 be assumed not to modify them). */
251
252static bool
253builtin_call_nomodifying_p (gimple *stmt)
254{
255 if (!gimple_call_builtin_p (stmt, BUILT_IN_NORMAL))
256 return false;
257
258 tree fndecl = gimple_call_fndecl (stmt);
259 if (!fndecl)
260 return false;
261
262 tree fntype = TREE_TYPE (fndecl);
263 if (!fntype)
264 return false;
265
266 /* Check the called function's signature for non-constc pointers.
267 If one is found, return false. */
268 unsigned argno = 0;
269 tree argtype;
270 function_args_iterator it;
271 FOREACH_FUNCTION_ARGS (fntype, argtype, it)
272 {
273 if (VOID_TYPE_P (argtype))
274 return true;
275
276 ++argno;
277
278 if (!POINTER_TYPE_P (argtype))
279 continue;
280
281 if (TYPE_READONLY (TREE_TYPE (argtype)))
282 continue;
283
284 return false;
285 }
286
287 /* If the number of actual arguments to the call is less than or
288 equal to the number of parameters, return false. */
289 unsigned nargs = gimple_call_num_args (stmt);
290 if (nargs <= argno)
291 return false;
292
293 /* Check arguments passed through the ellipsis in calls to variadic
294 functions for pointers. If one is found that's a non-constant
295 pointer, return false. */
296 for (; argno < nargs; ++argno)
297 {
298 tree arg = gimple_call_arg (stmt, argno);
299 argtype = TREE_TYPE (arg);
300 if (!POINTER_TYPE_P (argtype))
301 continue;
302
303 if (TYPE_READONLY (TREE_TYPE (argtype)))
304 continue;
305
306 return false;
307 }
308
309 return true;
310}
311
fb85d6eb
MS
312/* If ARG is a FNDECL parameter declared with attribute access none or
313 write_only issue a warning for its read access via PTR. */
314
315static void
316maybe_warn_read_write_only (tree fndecl, gimple *stmt, tree arg, tree ptr)
317{
318 if (!fndecl)
319 return;
320
321 if (get_no_uninit_warning (arg))
322 return;
323
324 tree fntype = TREE_TYPE (fndecl);
325 if (!fntype)
326 return;
327
328 /* Initialize a map of attribute access specifications for arguments
329 to the function function call. */
330 rdwr_map rdwr_idx;
331 init_attr_rdwr_indices (&rdwr_idx, TYPE_ATTRIBUTES (fntype));
332
333 unsigned argno = 0;
334 tree parms = DECL_ARGUMENTS (fndecl);
335 for (tree parm = parms; parm; parm = TREE_CHAIN (parm), ++argno)
336 {
337 if (parm != arg)
338 continue;
339
340 const attr_access* access = rdwr_idx.get (argno);
341 if (!access)
342 break;
343
344 if (access->mode != access_none
345 && access->mode != access_write_only)
346 continue;
347
348 location_t stmtloc
349 = linemap_resolve_location (line_table, gimple_location (stmt),
350 LRK_SPELLING_LOCATION, NULL);
351
352 if (!warning_at (stmtloc, OPT_Wmaybe_uninitialized,
353 "%qE may be used uninitialized", ptr))
354 break;
355
356 suppress_warning (arg, OPT_Wmaybe_uninitialized);
357
358 const char* const access_str =
359 TREE_STRING_POINTER (access->to_external_string ());
360
361 location_t parmloc = DECL_SOURCE_LOCATION (parm);
362 inform (parmloc, "accessing argument %u of a function declared with "
363 "attribute %<%s%>",
364 argno + 1, access_str);
365
366 break;
367 }
368}
369
e80facb4
RB
370/* Callback for walk_aliased_vdefs. */
371
372static bool
373check_defs (ao_ref *ref, tree vdef, void *data_)
374{
375 check_defs_data *data = (check_defs_data *)data_;
376 gimple *def_stmt = SSA_NAME_DEF_STMT (vdef);
2efe245b 377
a25e0b5e 378 /* Ignore the vdef if the definition statement is a call
379 to .DEFERRED_INIT function. */
380 if (gimple_call_internal_p (def_stmt, IFN_DEFERRED_INIT))
381 return false;
382
2efe245b 383 /* The ASAN_MARK intrinsic doesn't modify the variable. */
e07d30fd
MS
384 if (is_gimple_call (def_stmt))
385 {
94c12ffa 386 /* The ASAN_MARK intrinsic doesn't modify the variable. */
e07d30fd
MS
387 if (gimple_call_internal_p (def_stmt)
388 && gimple_call_internal_fn (def_stmt) == IFN_ASAN_MARK)
94c12ffa 389 return false;
e07d30fd
MS
390
391 if (tree fndecl = gimple_call_fndecl (def_stmt))
94c12ffa
MS
392 {
393 /* Some sanitizer calls pass integer arguments to built-ins
394 that expect pointets. Avoid using gimple_call_builtin_p()
395 which fails for such calls. */
396 if (DECL_BUILT_IN_CLASS (fndecl) == BUILT_IN_NORMAL)
397 {
398 built_in_function fncode = DECL_FUNCTION_CODE (fndecl);
399 if (fncode > BEGIN_SANITIZER_BUILTINS
400 && fncode < END_SANITIZER_BUILTINS)
401 return false;
402 }
403 }
e07d30fd 404 }
2efe245b
MS
405
406 /* End of VLA scope is not a kill. */
407 if (gimple_call_builtin_p (def_stmt, BUILT_IN_STACK_RESTORE))
408 return false;
409
e80facb4
RB
410 /* If this is a clobber then if it is not a kill walk past it. */
411 if (gimple_clobber_p (def_stmt))
412 {
413 if (stmt_kills_ref_p (def_stmt, ref))
414 return true;
415 return false;
416 }
2efe245b 417
6aacd901
MS
418 if (builtin_call_nomodifying_p (def_stmt))
419 return false;
420
e80facb4
RB
421 /* Found a may-def on this path. */
422 data->found_may_defs = true;
423 return true;
424}
425
b825a228
MS
426/* Counters and limits controlling the the depth of analysis and
427 strictness of the warning. */
428struct wlimits
429{
430 /* Number of VDEFs encountered. */
431 unsigned int vdef_cnt;
432 /* Number of statements examined by walk_aliased_vdefs. */
433 unsigned int oracle_cnt;
434 /* Limit on the number of statements visited by walk_aliased_vdefs. */
435 unsigned limit;
436 /* Set when basic block with statement is executed unconditionally. */
437 bool always_executed;
438 /* Set to issue -Wmaybe-uninitialized. */
439 bool wmaybe_uninit;
440};
441
442/* Determine if REF references an uninitialized operand and diagnose
fb85d6eb
MS
443 it if so. STMS is the referencing statement. LHS is the result
444 of the access and may be null. RHS is the variable referenced by
445 the access; it may not be null. */
b825a228
MS
446
447static tree
448maybe_warn_operand (ao_ref &ref, gimple *stmt, tree lhs, tree rhs,
449 wlimits &wlims)
450{
451 bool has_bit_insert = false;
452 use_operand_p luse_p;
453 imm_use_iterator liter;
454
e9e2bad7 455 if (get_no_uninit_warning (rhs))
b825a228
MS
456 return NULL_TREE;
457
458 /* Do not warn if the base was marked so or this is a
459 hard register var. */
460 tree base = ao_ref_base (&ref);
461 if ((VAR_P (base)
462 && DECL_HARD_REGISTER (base))
e9e2bad7 463 || get_no_uninit_warning (base))
b825a228
MS
464 return NULL_TREE;
465
1121e495
MS
466 /* Do not warn if the access is zero size or if it's fully outside
467 the object. */
b825a228 468 poly_int64 decl_size;
1121e495
MS
469 if (known_size_p (ref.size)
470 && known_eq (ref.max_size, ref.size)
471 && (known_eq (ref.size, 0)
472 || known_le (ref.offset + ref.size, 0)))
473 return NULL_TREE;
474
b825a228 475 if (DECL_P (base)
1121e495
MS
476 && known_ge (ref.offset, 0)
477 && DECL_SIZE (base)
478 && poly_int_tree_p (DECL_SIZE (base), &decl_size)
479 && known_le (decl_size, ref.offset))
b825a228
MS
480 return NULL_TREE;
481
482 /* Do not warn if the result of the access is then used for
483 a BIT_INSERT_EXPR. */
484 if (lhs && TREE_CODE (lhs) == SSA_NAME)
485 FOR_EACH_IMM_USE_FAST (luse_p, liter, lhs)
486 {
487 gimple *use_stmt = USE_STMT (luse_p);
488 /* BIT_INSERT_EXPR first operand should not be considered
489 a use for the purpose of uninit warnings. */
490 if (gassign *ass = dyn_cast <gassign *> (use_stmt))
491 {
492 if (gimple_assign_rhs_code (ass) == BIT_INSERT_EXPR
493 && luse_p->use == gimple_assign_rhs1_ptr (ass))
494 {
495 has_bit_insert = true;
496 break;
497 }
498 }
499 }
500
501 if (has_bit_insert)
502 return NULL_TREE;
503
504 /* Limit the walking to a constant number of stmts after
505 we overcommit quadratic behavior for small functions
506 and O(n) behavior. */
507 if (wlims.oracle_cnt > 128 * 128
508 && wlims.oracle_cnt > wlims.vdef_cnt * 2)
509 wlims.limit = 32;
510
511 check_defs_data data;
512 bool fentry_reached = false;
513 data.found_may_defs = false;
514 tree use = gimple_vuse (stmt);
515 if (!use)
516 return NULL_TREE;
517 int res = walk_aliased_vdefs (&ref, use,
518 check_defs, &data, NULL,
519 &fentry_reached, wlims.limit);
520 if (res == -1)
521 {
522 wlims.oracle_cnt += wlims.limit;
523 return NULL_TREE;
524 }
525
526 wlims.oracle_cnt += res;
527 if (data.found_may_defs)
528 return NULL_TREE;
529
530 bool found_alloc = false;
531
532 if (fentry_reached)
533 {
534 if (TREE_CODE (base) == MEM_REF)
535 base = TREE_OPERAND (base, 0);
536
537 /* Follow the chain of SSA_NAME assignments looking for an alloca
538 call (or VLA) or malloc/realloc, or for decls. If any is found
539 (and in the latter case, the operand is a local variable) issue
540 a warning. */
541 while (TREE_CODE (base) == SSA_NAME)
542 {
543 gimple *def_stmt = SSA_NAME_DEF_STMT (base);
544
545 if (is_gimple_call (def_stmt)
546 && gimple_call_builtin_p (def_stmt))
547 {
548 /* Detect uses of uninitialized alloca/VLAs. */
549 tree fndecl = gimple_call_fndecl (def_stmt);
550 const built_in_function fncode = DECL_FUNCTION_CODE (fndecl);
551 if (fncode == BUILT_IN_ALLOCA
552 || fncode == BUILT_IN_ALLOCA_WITH_ALIGN
553 || fncode == BUILT_IN_MALLOC)
554 found_alloc = true;
555 break;
556 }
557
558 if (!is_gimple_assign (def_stmt))
559 break;
560
561 tree_code code = gimple_assign_rhs_code (def_stmt);
562 if (code != ADDR_EXPR && code != POINTER_PLUS_EXPR)
563 break;
564
565 base = gimple_assign_rhs1 (def_stmt);
566 if (TREE_CODE (base) == ADDR_EXPR)
567 base = TREE_OPERAND (base, 0);
568
569 if (DECL_P (base)
570 || TREE_CODE (base) == COMPONENT_REF)
571 rhs = base;
572
573 if (TREE_CODE (base) == MEM_REF)
574 base = TREE_OPERAND (base, 0);
575
576 if (tree ba = get_base_address (base))
577 base = ba;
578 }
579
580 /* Replace the RHS expression with BASE so that it
581 refers to it in the diagnostic (instead of to
582 '<unknown>'). */
583 if (DECL_P (base)
584 && EXPR_P (rhs)
585 && TREE_CODE (rhs) != COMPONENT_REF)
586 rhs = base;
587 }
588
589 /* Do not warn if it can be initialized outside this function.
590 If we did not reach function entry then we found killing
591 clobbers on all paths to entry. */
fb85d6eb
MS
592 if (!found_alloc && fentry_reached)
593 {
594 if (TREE_CODE (base) == SSA_NAME)
595 {
596 tree var = SSA_NAME_VAR (base);
597 if (var && TREE_CODE (var) == PARM_DECL)
598 {
599 maybe_warn_read_write_only (cfun->decl, stmt, var, rhs);
600 return NULL_TREE;
601 }
602 }
603
604 if (!VAR_P (base)
605 || is_global_var (base))
606 /* ??? We'd like to use ref_may_alias_global_p but that
607 excludes global readonly memory and thus we get bogus
608 warnings from p = cond ? "a" : "b" for example. */
609 return NULL_TREE;
610 }
b825a228
MS
611
612 /* Strip the address-of expression from arrays passed to functions. */
613 if (TREE_CODE (rhs) == ADDR_EXPR)
614 rhs = TREE_OPERAND (rhs, 0);
615
616 /* Check again since RHS may have changed above. */
e9e2bad7 617 if (get_no_uninit_warning (rhs))
b825a228
MS
618 return NULL_TREE;
619
620 /* Avoid warning about empty types such as structs with no members.
621 The first_field() test is important for C++ where the predicate
622 alone isn't always sufficient. */
623 tree rhstype = TREE_TYPE (rhs);
8b75204b
MS
624 if (POINTER_TYPE_P (rhstype))
625 rhstype = TREE_TYPE (rhstype);
3072125a 626 if (is_empty_type (rhstype))
b825a228
MS
627 return NULL_TREE;
628
629 bool warned = false;
630 /* We didn't find any may-defs so on all paths either
631 reached function entry or a killing clobber. */
632 location_t location
633 = linemap_resolve_location (line_table, gimple_location (stmt),
634 LRK_SPELLING_LOCATION, NULL);
635 if (wlims.always_executed)
636 {
637 if (warning_at (location, OPT_Wuninitialized,
6d3bab5d 638 "%qE is used uninitialized", rhs))
b825a228
MS
639 {
640 /* ??? This is only effective for decls as in
641 gcc.dg/uninit-B-O0.c. Avoid doing this for maybe-uninit
642 uses or accesses by functions as it may hide important
643 locations. */
644 if (lhs)
e9e2bad7 645 set_no_uninit_warning (rhs);
b825a228
MS
646 warned = true;
647 }
648 }
649 else if (wlims.wmaybe_uninit)
650 warned = warning_at (location, OPT_Wmaybe_uninitialized,
6d3bab5d 651 "%qE may be used uninitialized", rhs);
b825a228
MS
652
653 return warned ? base : NULL_TREE;
654}
655
656
657/* Diagnose passing addresses of uninitialized objects to either const
658 pointer arguments to functions, or to functions declared with attribute
659 access implying read access to those objects. */
660
661static void
0c9687d0 662maybe_warn_pass_by_reference (gcall *stmt, wlimits &wlims)
b825a228
MS
663{
664 if (!wlims.wmaybe_uninit)
665 return;
666
667 unsigned nargs = gimple_call_num_args (stmt);
668 if (!nargs)
669 return;
670
671 tree fndecl = gimple_call_fndecl (stmt);
672 tree fntype = gimple_call_fntype (stmt);
673 if (!fntype)
674 return;
675
0c9687d0
JH
676 /* Const function do not read their arguments. */
677 if (gimple_call_flags (stmt) & ECF_CONST)
678 return;
679
b825a228
MS
680 const built_in_function fncode
681 = (fndecl && gimple_call_builtin_p (stmt, BUILT_IN_NORMAL)
682 ? DECL_FUNCTION_CODE (fndecl) : (built_in_function)BUILT_IN_LAST);
683
684 if (fncode == BUILT_IN_MEMCPY || fncode == BUILT_IN_MEMMOVE)
685 /* Avoid diagnosing calls to raw memory functions (this is overly
686 permissive; consider tightening it up). */
687 return;
688
689 /* Save the current warning setting and replace it either a "maybe"
690 when passing addresses of uninitialized variables to const-qualified
691 pointers or arguments declared with attribute read_write, or with
692 a "certain" when passing them to arguments declared with attribute
693 read_only. */
694 const bool save_always_executed = wlims.always_executed;
695
72be80e4
MS
696 /* Initialize a map of attribute access specifications for arguments
697 to the function function call. */
b825a228 698 rdwr_map rdwr_idx;
6450f073 699 init_attr_rdwr_indices (&rdwr_idx, TYPE_ATTRIBUTES (fntype));
b825a228
MS
700
701 tree argtype;
702 unsigned argno = 0;
703 function_args_iterator it;
704
705 FOREACH_FUNCTION_ARGS (fntype, argtype, it)
706 {
707 ++argno;
708
709 if (!POINTER_TYPE_P (argtype))
710 continue;
711
712 tree access_size = NULL_TREE;
72be80e4 713 const attr_access* access = rdwr_idx.get (argno - 1);
b825a228
MS
714 if (access)
715 {
d14c547a
MS
716 if (access->mode == access_none
717 || access->mode == access_write_only)
b825a228 718 continue;
72be80e4
MS
719
720 if (access->mode == access_deferred
721 && !TYPE_READONLY (TREE_TYPE (argtype)))
722 continue;
723
d14c547a 724 if (save_always_executed && access->mode == access_read_only)
b825a228
MS
725 /* Attribute read_only arguments imply read access. */
726 wlims.always_executed = true;
727 else
728 /* Attribute read_write arguments are documented as requiring
729 initialized objects but it's expected that aggregates may
730 be only partially initialized regardless. */
731 wlims.always_executed = false;
732
733 if (access->sizarg < nargs)
734 access_size = gimple_call_arg (stmt, access->sizarg);
735 }
736 else if (!TYPE_READONLY (TREE_TYPE (argtype)))
737 continue;
738 else if (save_always_executed && fncode != BUILT_IN_LAST)
739 /* Const-qualified arguments to built-ins imply read access. */
740 wlims.always_executed = true;
741 else
742 /* Const-qualified arguments to ordinary functions imply a likely
743 (but not definitive) read access. */
744 wlims.always_executed = false;
745
0c9687d0 746 /* Ignore args we are not going to read from. */
e12946df 747 if (gimple_call_arg_flags (stmt, argno - 1) & (EAF_UNUSED | EAF_NOREAD))
0c9687d0
JH
748 continue;
749
b825a228 750 tree arg = gimple_call_arg (stmt, argno - 1);
9816f509
MS
751 if (!POINTER_TYPE_P (TREE_TYPE (arg)))
752 /* Avoid actual arguments with invalid types. */
753 continue;
b825a228
MS
754
755 ao_ref ref;
756 ao_ref_init_from_ptr_and_size (&ref, arg, access_size);
757 tree argbase = maybe_warn_operand (ref, stmt, NULL_TREE, arg, wlims);
758 if (!argbase)
759 continue;
760
72be80e4 761 if (access && access->mode != access_deferred)
b825a228 762 {
72be80e4
MS
763 const char* const access_str =
764 TREE_STRING_POINTER (access->to_external_string ());
b825a228
MS
765
766 if (fndecl)
767 {
768 location_t loc = DECL_SOURCE_LOCATION (fndecl);
72be80e4
MS
769 inform (loc, "in a call to %qD declared with "
770 "attribute %<%s%> here", fndecl, access_str);
b825a228
MS
771 }
772 else
773 {
774 /* Handle calls through function pointers. */
775 location_t loc = gimple_location (stmt);
776 inform (loc, "in a call to %qT declared with "
72be80e4 777 "attribute %<%s%>", fntype, access_str);
b825a228
MS
778 }
779 }
b825a228
MS
780 else
781 {
72be80e4
MS
782 /* For a declaration with no relevant attribute access create
783 a dummy object and use the formatting function to avoid
784 having to complicate things here. */
785 attr_access ptr_access = { };
786 if (!access)
787 access = &ptr_access;
788 const std::string argtypestr = access->array_as_string (argtype);
789 if (fndecl)
790 {
791 location_t loc (DECL_SOURCE_LOCATION (fndecl));
baad4c48 792 inform (loc, "by argument %u of type %s to %qD "
72be80e4
MS
793 "declared here",
794 argno, argtypestr.c_str (), fndecl);
795 }
796 else
797 {
798 /* Handle calls through function pointers. */
799 location_t loc (gimple_location (stmt));
baad4c48 800 inform (loc, "by argument %u of type %s to %qT",
72be80e4
MS
801 argno, argtypestr.c_str (), fntype);
802 }
b825a228
MS
803 }
804
805 if (DECL_P (argbase))
806 {
807 location_t loc = DECL_SOURCE_LOCATION (argbase);
808 inform (loc, "%qD declared here", argbase);
809 }
810 }
811
812 wlims.always_executed = save_always_executed;
813}
814
66030d68
RB
815/* Warn about an uninitialized PHI argument on the fallthru path to
816 an always executed block BB. */
817
818static void
819warn_uninit_phi_uses (basic_block bb)
820{
821 edge_iterator ei;
822 edge e, found = NULL, found_back = NULL;
823 /* Look for a fallthru and possibly a single backedge. */
824 FOR_EACH_EDGE (e, ei, bb->preds)
825 {
826 /* Ignore backedges. */
827 if (dominated_by_p (CDI_DOMINATORS, e->src, bb))
828 {
829 if (found_back)
830 {
831 found = NULL;
832 break;
833 }
834 found_back = e;
835 continue;
836 }
837 if (found)
838 {
839 found = NULL;
840 break;
841 }
842 found = e;
843 }
844 if (!found)
845 return;
846
847 basic_block succ = single_succ (ENTRY_BLOCK_PTR_FOR_FN (cfun));
848 for (gphi_iterator si = gsi_start_phis (bb); !gsi_end_p (si);
849 gsi_next (&si))
850 {
851 gphi *phi = si.phi ();
852 tree def = PHI_ARG_DEF_FROM_EDGE (phi, found);
853 if (TREE_CODE (def) != SSA_NAME
854 || !SSA_NAME_IS_DEFAULT_DEF (def)
855 || virtual_operand_p (def))
856 continue;
857 /* If there's a default def on the fallthru edge PHI
858 value and there's a use that post-dominates entry
859 then that use is uninitialized and we can warn. */
860 imm_use_iterator iter;
861 use_operand_p use_p;
862 gimple *use_stmt = NULL;
863 FOR_EACH_IMM_USE_FAST (use_p, iter, gimple_phi_result (phi))
864 {
865 use_stmt = USE_STMT (use_p);
866 if (gimple_location (use_stmt) != UNKNOWN_LOCATION
867 && dominated_by_p (CDI_POST_DOMINATORS, succ,
868 gimple_bb (use_stmt))
869 /* If we found a non-fallthru edge make sure the
870 use is inside the loop, otherwise the backedge
871 can serve as initialization. */
872 && (!found_back
873 || dominated_by_p (CDI_DOMINATORS, found_back->src,
874 gimple_bb (use_stmt))))
875 break;
876 use_stmt = NULL;
877 }
878 if (use_stmt)
879 warn_uninit (OPT_Wuninitialized, def, SSA_NAME_VAR (def),
4e84e381 880 "%qD is used uninitialized", use_stmt);
66030d68
RB
881 }
882}
b825a228 883
4e84e381
MS
884/* Issue warnings about reads of uninitialized variables. WMAYBE_UNINIT
885 is true to issue -Wmaybe-uninitialized, otherwise -Wuninitialized. */
886
887static void
b825a228 888warn_uninitialized_vars (bool wmaybe_uninit)
c152901f 889{
b825a228
MS
890 /* Counters and limits controlling the the depth of the warning. */
891 wlimits wlims = { };
892 wlims.wmaybe_uninit = wmaybe_uninit;
893
c152901f
AM
894 gimple_stmt_iterator gsi;
895 basic_block bb;
11cd3bed 896 FOR_EACH_BB_FN (bb, cfun)
c152901f 897 {
ac0e4fde 898 basic_block succ = single_succ (ENTRY_BLOCK_PTR_FOR_FN (cfun));
b825a228 899 wlims.always_executed = dominated_by_p (CDI_POST_DOMINATORS, succ, bb);
66030d68
RB
900
901 if (wlims.always_executed)
902 warn_uninit_phi_uses (bb);
903
c152901f
AM
904 for (gsi = gsi_start_bb (bb); !gsi_end_p (gsi); gsi_next (&gsi))
905 {
355fe088 906 gimple *stmt = gsi_stmt (gsi);
a25e0b5e 907
908 /* The call is an artificial use, will not provide meaningful
909 error message. If the result of the call is used somewhere
910 else, we warn there instead. */
911 if (gimple_call_internal_p (stmt, IFN_DEFERRED_INIT))
912 continue;
913
c152901f
AM
914 if (is_gimple_debug (stmt))
915 continue;
916
917 /* We only do data flow with SSA_NAMEs, so that's all we
918 can warn about. */
4e84e381
MS
919 use_operand_p use_p;
920 ssa_op_iter op_iter;
c152901f
AM
921 FOR_EACH_SSA_USE_OPERAND (use_p, stmt, op_iter, SSA_OP_USE)
922 {
d07f8c59
RB
923 /* BIT_INSERT_EXPR first operand should not be considered
924 a use for the purpose of uninit warnings. */
925 if (gassign *ass = dyn_cast <gassign *> (stmt))
926 {
927 if (gimple_assign_rhs_code (ass) == BIT_INSERT_EXPR
928 && use_p->use == gimple_assign_rhs1_ptr (ass))
929 continue;
930 }
4e84e381 931 tree use = USE_FROM_PTR (use_p);
b825a228 932 if (wlims.always_executed)
ac0e4fde 933 warn_uninit (OPT_Wuninitialized, use, SSA_NAME_VAR (use),
4e84e381 934 "%qD is used uninitialized", stmt);
b825a228 935 else if (wmaybe_uninit)
ac0e4fde 936 warn_uninit (OPT_Wmaybe_uninitialized, use, SSA_NAME_VAR (use),
4e84e381 937 "%qD may be used uninitialized", stmt);
c152901f
AM
938 }
939
e80facb4
RB
940 /* For limiting the alias walk below we count all
941 vdefs in the function. */
942 if (gimple_vdef (stmt))
b825a228 943 wlims.vdef_cnt++;
e80facb4 944
0c9687d0
JH
945 if (gcall *call = dyn_cast <gcall *> (stmt))
946 maybe_warn_pass_by_reference (call, wlims);
b825a228
MS
947 else if (gimple_assign_load_p (stmt)
948 && gimple_has_location (stmt))
c152901f
AM
949 {
950 tree rhs = gimple_assign_rhs1 (stmt);
6d20bf18 951 tree lhs = gimple_assign_lhs (stmt);
e80facb4
RB
952
953 ao_ref ref;
954 ao_ref_init (&ref, rhs);
b825a228
MS
955 tree var = maybe_warn_operand (ref, stmt, lhs, rhs, wlims);
956 if (!var)
d21a8e3b 957 continue;
c152901f 958
b825a228 959 if (DECL_P (var))
e80facb4 960 {
b825a228
MS
961 location_t loc = DECL_SOURCE_LOCATION (var);
962 inform (loc, "%qD declared here", var);
e80facb4 963 }
c152901f
AM
964 }
965 }
966 }
c152901f
AM
967}
968
927734cf
XDL
969/* Checks if the operand OPND of PHI is defined by
970 another phi with one operand defined by this PHI,
ac0e4fde 971 but the rest operands are all defined. If yes,
026c3cfd 972 returns true to skip this operand as being
ac0e4fde 973 redundant. Can be enhanced to be more general. */
34f97b94
XDL
974
975static bool
355fe088 976can_skip_redundant_opnd (tree opnd, gimple *phi)
34f97b94 977{
4e84e381
MS
978 tree phi_def = gimple_phi_result (phi);
979 gimple *op_def = SSA_NAME_DEF_STMT (opnd);
34f97b94
XDL
980 if (gimple_code (op_def) != GIMPLE_PHI)
981 return false;
4e84e381
MS
982
983 unsigned n = gimple_phi_num_args (op_def);
984 for (unsigned i = 0; i < n; ++i)
34f97b94
XDL
985 {
986 tree op = gimple_phi_arg_def (op_def, i);
987 if (TREE_CODE (op) != SSA_NAME)
5e48d8a0 988 continue;
ba7e83f8 989 if (op != phi_def && uninit_undefined_value_p (op))
5e48d8a0 990 return false;
34f97b94
XDL
991 }
992
993 return true;
994}
995
94c12ffa
MS
996/* Return a bitset holding the positions of arguments in PHI with empty
997 (or possibly empty) definitions. */
34f97b94
XDL
998
999static unsigned
538dd0b7 1000compute_uninit_opnds_pos (gphi *phi)
34f97b94 1001{
34f97b94
XDL
1002 unsigned uninit_opnds = 0;
1003
4e84e381 1004 unsigned n = gimple_phi_num_args (phi);
98d30e4f 1005 /* Bail out for phi with too many args. */
94c12ffa 1006 if (n > predicate::func_t::max_phi_args)
98d30e4f 1007 return 0;
34f97b94 1008
4e84e381 1009 for (unsigned i = 0; i < n; ++i)
34f97b94
XDL
1010 {
1011 tree op = gimple_phi_arg_def (phi, i);
1012 if (TREE_CODE (op) == SSA_NAME
5e48d8a0
ML
1013 && uninit_undefined_value_p (op)
1014 && !can_skip_redundant_opnd (op, phi))
e7d764f3 1015 {
5e48d8a0 1016 if (cfun->has_nonlocal_label || cfun->calls_setjmp)
e7d764f3 1017 {
aea0101d
RB
1018 /* Ignore SSA_NAMEs that appear on abnormal edges
1019 somewhere. */
1020 if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (op))
1021 continue;
e7d764f3
JJ
1022 }
1023 MASK_SET_BIT (uninit_opnds, i);
1024 }
34f97b94
XDL
1025 }
1026 return uninit_opnds;
1027}
1028
94c12ffa
MS
1029/* Function object type used to determine whether an expression
1030 is of interest to the predicate analyzer. */
34f97b94 1031
94c12ffa 1032struct uninit_undef_val_t: public predicate::func_t
34f97b94 1033{
94c12ffa
MS
1034 virtual bool operator()(tree) override;
1035 virtual unsigned phi_arg_set (gphi *) override;
1036};
34f97b94 1037
94c12ffa 1038/* Return true if the argument is an expression of interest. */
34f97b94 1039
94c12ffa
MS
1040bool
1041uninit_undef_val_t::operator()(tree val)
34f97b94 1042{
94c12ffa
MS
1043 if (TREE_CODE (val) == SSA_NAME)
1044 return uninit_undefined_value_p (val);
34f97b94 1045
94c12ffa 1046 return false;
34f97b94
XDL
1047}
1048
94c12ffa 1049/* Return a bitset of PHI arguments of interest. */
34f97b94 1050
94c12ffa
MS
1051unsigned
1052uninit_undef_val_t::phi_arg_set (gphi *phi)
34f97b94 1053{
94c12ffa 1054 return compute_uninit_opnds_pos (phi);
34f97b94
XDL
1055}
1056
94c12ffa
MS
1057/* Searches through all uses of a potentially
1058 uninitialized variable defined by PHI and returns a use
1059 statement if the use is not properly guarded. It returns
1060 NULL if all uses are guarded. UNINIT_OPNDS is a bitvector
1061 holding the position(s) of uninit PHI operands. WORKLIST
1062 is the vector of candidate phis that may be updated by this
1063 function. ADDED_TO_WORKLIST is the pointer set tracking
1064 if the new phi is already in the worklist. */
34f97b94 1065
94c12ffa
MS
1066static gimple *
1067find_uninit_use (gphi *phi, unsigned uninit_opnds,
1068 vec<gphi *> *worklist, hash_set<gphi *> *added_to_worklist)
34f97b94 1069{
94c12ffa
MS
1070 /* The Boolean predicate guarding the PHI definition. Initialized
1071 lazily from PHI in the first call to is_use_guarded() and cached
1072 for subsequent iterations. */
1073 uninit_undef_val_t eval;
1074 predicate def_preds (eval);
34f97b94 1075
94c12ffa
MS
1076 use_operand_p use_p;
1077 imm_use_iterator iter;
1078 tree phi_result = gimple_phi_result (phi);
1079 FOR_EACH_IMM_USE_FAST (use_p, iter, phi_result)
34f97b94 1080 {
94c12ffa
MS
1081 gimple *use_stmt = USE_STMT (use_p);
1082 if (is_gimple_debug (use_stmt))
5e48d8a0 1083 continue;
34f97b94 1084
94c12ffa
MS
1085 basic_block use_bb;
1086 if (gphi *use_phi = dyn_cast<gphi *> (use_stmt))
1087 use_bb = gimple_phi_arg_edge (use_phi,
1088 PHI_ARG_INDEX_FROM_USE (use_p))->src;
1089 else
1090 use_bb = gimple_bb (use_stmt);
5e48d8a0 1091
94c12ffa
MS
1092 if (def_preds.is_use_guarded (use_stmt, use_bb, phi, uninit_opnds))
1093 continue;
34f97b94 1094
94c12ffa
MS
1095 if (dump_file && (dump_flags & TDF_DETAILS))
1096 {
1097 fprintf (dump_file, "Found unguarded use in bb %u: ",
1098 use_bb->index);
1099 print_gimple_stmt (dump_file, use_stmt, 0);
5e48d8a0 1100 }
94c12ffa
MS
1101 /* Found one real use, return. */
1102 if (gimple_code (use_stmt) != GIMPLE_PHI)
1103 return use_stmt;
c375a3a4 1104
94c12ffa
MS
1105 /* Found a phi use that is not guarded,
1106 add the phi to the worklist. */
1107 if (!added_to_worklist->add (as_a<gphi *> (use_stmt)))
5e48d8a0 1108 {
94c12ffa 1109 if (dump_file && (dump_flags & TDF_DETAILS))
e7c6abad 1110 {
94c12ffa
MS
1111 fprintf (dump_file, "[WORKLIST]: Update worklist with phi: ");
1112 print_gimple_stmt (dump_file, use_stmt, 0);
e7c6abad 1113 }
5e48d8a0 1114
94c12ffa
MS
1115 worklist->safe_push (as_a<gphi *> (use_stmt));
1116 possibly_undefined_names->add (phi_result);
5e48d8a0 1117 }
34f97b94
XDL
1118 }
1119
94c12ffa 1120 return NULL;
34f97b94
XDL
1121}
1122
94c12ffa
MS
1123/* Look for inputs to PHI that are SSA_NAMEs that have empty definitions
1124 and gives warning if there exists a runtime path from the entry to a
1125 use of the PHI def that does not contain a definition. In other words,
1126 the warning is on the real use. The more dead paths that can be pruned
1127 by the compiler, the fewer false positives the warning is. WORKLIST
1128 is a vector of candidate phis to be examined. ADDED_TO_WORKLIST is
1129 a pointer set tracking if the new phi is added to the worklist or not. */
34f97b94
XDL
1130
1131static void
94c12ffa
MS
1132warn_uninitialized_phi (gphi *phi, vec<gphi *> *worklist,
1133 hash_set<gphi *> *added_to_worklist)
34f97b94 1134{
94c12ffa
MS
1135 /* Don't look at virtual operands. */
1136 if (virtual_operand_p (gimple_phi_result (phi)))
1137 return;
34f97b94 1138
94c12ffa
MS
1139 unsigned uninit_opnds = compute_uninit_opnds_pos (phi);
1140 if (MASK_EMPTY (uninit_opnds))
34f97b94
XDL
1141 return;
1142
94c12ffa 1143 if (dump_file && (dump_flags & TDF_DETAILS))
34f97b94 1144 {
94c12ffa
MS
1145 fprintf (dump_file, "Examining phi: ");
1146 print_gimple_stmt (dump_file, phi, 0);
34f97b94 1147 }
34f97b94 1148
94c12ffa
MS
1149 gimple *uninit_use_stmt = find_uninit_use (phi, uninit_opnds,
1150 worklist, added_to_worklist);
34f97b94 1151
94c12ffa
MS
1152 /* All uses are properly guarded but a new PHI may have been added
1153 to WORKLIST. */
1154 if (!uninit_use_stmt)
1155 return;
34f97b94 1156
94c12ffa
MS
1157 unsigned phiarg_index = MASK_FIRST_SET_BIT (uninit_opnds);
1158 tree uninit_op = gimple_phi_arg_def (phi, phiarg_index);
1159 if (SSA_NAME_VAR (uninit_op) == NULL_TREE)
1160 return;
34f97b94 1161
94c12ffa
MS
1162 location_t loc = UNKNOWN_LOCATION;
1163 if (gimple_phi_arg_has_location (phi, phiarg_index))
1164 loc = gimple_phi_arg_location (phi, phiarg_index);
1165 else
34f97b94 1166 {
94c12ffa
MS
1167 tree arg_def = gimple_phi_arg_def (phi, phiarg_index);
1168 if (TREE_CODE (arg_def) == SSA_NAME)
5e48d8a0 1169 {
94c12ffa
MS
1170 gimple *def_stmt = SSA_NAME_DEF_STMT (arg_def);
1171 if (gphi *arg_phi = dyn_cast<gphi *> (def_stmt))
1172 {
1173 unsigned uop = compute_uninit_opnds_pos (arg_phi);
1174 unsigned idx = MASK_FIRST_SET_BIT (uop);
1175 if (idx < gimple_phi_num_args (arg_phi)
1176 && gimple_phi_arg_has_location (arg_phi, idx))
1177 loc = gimple_phi_arg_location (arg_phi, idx);
1178 }
5e48d8a0 1179 }
34f97b94
XDL
1180 }
1181
94c12ffa
MS
1182 warn_uninit (OPT_Wmaybe_uninitialized, uninit_op,
1183 SSA_NAME_VAR (uninit_op),
1184 "%qD may be used uninitialized in this function",
1185 uninit_use_stmt, loc);
34f97b94
XDL
1186}
1187
94c12ffa
MS
1188static bool
1189gate_warn_uninitialized (void)
11ef0b22 1190{
94c12ffa 1191 return warn_uninitialized || warn_maybe_uninitialized;
11ef0b22
AH
1192}
1193
94c12ffa 1194namespace {
11ef0b22 1195
94c12ffa 1196const pass_data pass_data_late_warn_uninitialized =
11ef0b22 1197{
94c12ffa
MS
1198 GIMPLE_PASS, /* type */
1199 "uninit", /* name */
1200 OPTGROUP_NONE, /* optinfo_flags */
1201 TV_NONE, /* tv_id */
1202 PROP_ssa, /* properties_required */
1203 0, /* properties_provided */
1204 0, /* properties_destroyed */
1205 0, /* todo_flags_start */
1206 0, /* todo_flags_finish */
1207};
34f97b94 1208
94c12ffa 1209class pass_late_warn_uninitialized : public gimple_opt_pass
34f97b94 1210{
94c12ffa
MS
1211public:
1212 pass_late_warn_uninitialized (gcc::context *ctxt)
1213 : gimple_opt_pass (pass_data_late_warn_uninitialized, ctxt)
1214 {}
1215
1216 /* opt_pass methods: */
1217 opt_pass *clone () { return new pass_late_warn_uninitialized (m_ctxt); }
1218 virtual bool gate (function *) { return gate_warn_uninitialized (); }
1219 virtual unsigned int execute (function *);
34f97b94 1220
94c12ffa 1221}; // class pass_late_warn_uninitialized
34f97b94
XDL
1222
1223static void
94c12ffa 1224execute_late_warn_uninitialized (function *fun)
34f97b94 1225{
94c12ffa
MS
1226 basic_block bb;
1227 gphi_iterator gsi;
1228 vec<gphi *> worklist = vNULL;
34f97b94 1229
94c12ffa
MS
1230 calculate_dominance_info (CDI_DOMINATORS);
1231 calculate_dominance_info (CDI_POST_DOMINATORS);
1232 /* Re-do the plain uninitialized variable check, as optimization may have
1233 straightened control flow. Do this first so that we don't accidentally
1234 get a "may be" warning when we'd have seen an "is" warning later. */
1235 warn_uninitialized_vars (/*warn_maybe_uninitialized=*/1);
34f97b94 1236
94c12ffa 1237 timevar_push (TV_TREE_UNINIT);
34f97b94 1238
94c12ffa
MS
1239 possibly_undefined_names = new hash_set<tree>;
1240 hash_set<gphi *> added_to_worklist;
34f97b94 1241
94c12ffa
MS
1242 /* Initialize worklist */
1243 FOR_EACH_BB_FN (bb, fun)
1244 for (gsi = gsi_start_phis (bb); !gsi_end_p (gsi); gsi_next (&gsi))
1245 {
1246 gphi *phi = gsi.phi ();
be55bfe6
TS
1247
1248 /* Don't look at virtual operands. */
1249 if (virtual_operand_p (gimple_phi_result (phi)))
1250 continue;
1251
94c12ffa
MS
1252 unsigned n = gimple_phi_num_args (phi);
1253 for (unsigned i = 0; i < n; ++i)
be55bfe6
TS
1254 {
1255 tree op = gimple_phi_arg_def (phi, i);
ac0e4fde 1256 if (TREE_CODE (op) == SSA_NAME && uninit_undefined_value_p (op))
be55bfe6
TS
1257 {
1258 worklist.safe_push (phi);
6e2830c3 1259 added_to_worklist.add (phi);
be55bfe6
TS
1260 if (dump_file && (dump_flags & TDF_DETAILS))
1261 {
94c12ffa
MS
1262 fprintf (dump_file, "[WORKLIST]: add to initial list "
1263 "for operand %u of: ", i);
ef6cb4c7 1264 print_gimple_stmt (dump_file, phi, 0);
be55bfe6
TS
1265 }
1266 break;
1267 }
1268 }
34f97b94
XDL
1269 }
1270
9771b263 1271 while (worklist.length () != 0)
34f97b94 1272 {
538dd0b7 1273 gphi *cur_phi = 0;
9771b263 1274 cur_phi = worklist.pop ();
6e2830c3 1275 warn_uninitialized_phi (cur_phi, &worklist, &added_to_worklist);
34f97b94 1276 }
e74780a3 1277
9771b263 1278 worklist.release ();
6e2830c3 1279 delete possibly_undefined_names;
34f97b94
XDL
1280 possibly_undefined_names = NULL;
1281 free_dominance_info (CDI_POST_DOMINATORS);
1282 timevar_pop (TV_TREE_UNINIT);
94c12ffa
MS
1283}
1284
1285unsigned int
1286pass_late_warn_uninitialized::execute (function *fun)
1287{
1288 execute_late_warn_uninitialized (fun);
34f97b94
XDL
1289 return 0;
1290}
1291
27a4cd48
DM
1292} // anon namespace
1293
1294gimple_opt_pass *
1295make_pass_late_warn_uninitialized (gcc::context *ctxt)
1296{
1297 return new pass_late_warn_uninitialized (ctxt);
1298}
c152901f 1299
c152901f
AM
1300static unsigned int
1301execute_early_warn_uninitialized (void)
1302{
1303 /* Currently, this pass runs always but
ac0e4fde 1304 execute_late_warn_uninitialized only runs with optimization. With
c152901f
AM
1305 optimization we want to warn about possible uninitialized as late
1306 as possible, thus don't do it here. However, without
927734cf 1307 optimization we need to warn here about "may be uninitialized". */
66030d68 1308 calculate_dominance_info (CDI_DOMINATORS);
c152901f
AM
1309 calculate_dominance_info (CDI_POST_DOMINATORS);
1310
b825a228 1311 warn_uninitialized_vars (/*warn_maybe_uninitialized=*/!optimize);
c152901f 1312
67914693 1313 /* Post-dominator information cannot be reliably updated. Free it
c152901f
AM
1314 after the use. */
1315
1316 free_dominance_info (CDI_POST_DOMINATORS);
1317 return 0;
1318}
1319
c152901f
AM
1320namespace {
1321
1322const pass_data pass_data_early_warn_uninitialized =
1323{
1324 GIMPLE_PASS, /* type */
1325 "*early_warn_uninitialized", /* name */
1326 OPTGROUP_NONE, /* optinfo_flags */
c152901f
AM
1327 TV_TREE_UNINIT, /* tv_id */
1328 PROP_ssa, /* properties_required */
1329 0, /* properties_provided */
1330 0, /* properties_destroyed */
1331 0, /* todo_flags_start */
1332 0, /* todo_flags_finish */
1333};
1334
1335class pass_early_warn_uninitialized : public gimple_opt_pass
1336{
1337public:
c3284718
RS
1338 pass_early_warn_uninitialized (gcc::context *ctxt)
1339 : gimple_opt_pass (pass_data_early_warn_uninitialized, ctxt)
c152901f
AM
1340 {}
1341
1342 /* opt_pass methods: */
1a3d085c 1343 virtual bool gate (function *) { return gate_warn_uninitialized (); }
be55bfe6 1344 virtual unsigned int execute (function *)
ac0e4fde
ML
1345 {
1346 return execute_early_warn_uninitialized ();
1347 }
c152901f
AM
1348
1349}; // class pass_early_warn_uninitialized
1350
1351} // anon namespace
1352
1353gimple_opt_pass *
1354make_pass_early_warn_uninitialized (gcc::context *ctxt)
1355{
1356 return new pass_early_warn_uninitialized (ctxt);
1357}