]>
Commit | Line | Data |
---|---|---|
00e5a55c BS |
1 | From: Ingo Molnar <mingo@elte.hu> |
2 | commit 180b65df7ba1e700e28aabfbddbad84b7beebe4b | |
3 | Author: Ingo Molnar <mingo@elte.hu> | |
4 | Date: Tue Nov 25 16:51:45 2008 -0800 | |
5 | Subject: fix warning in fs/dlm/netlink.c | |
6 | ||
7 | this warning: | |
8 | ||
9 | fs/dlm/netlink.c: In function ‘dlm_timeout_warn’: | |
10 | fs/dlm/netlink.c:131: warning: ‘send_skb’ may be used uninitialized in this function | |
11 | ||
12 | triggers because GCC does not recognize the (correct) error flow | |
13 | between prepare_data() and send_skb. | |
14 | ||
15 | Annotate it. | |
16 | ||
17 | Signed-off-by: Ingo Molnar <mingo@elte.hu> | |
18 | Signed-off-by: David S. Miller <davem@davemloft.net> | |
19 | Signed-off-by: Coly Li <coly.li@suse.de> | |
20 | ||
21 | diff --git a/fs/dlm/netlink.c b/fs/dlm/netlink.c | |
22 | index 18bda83..aa2a577 100644 | |
23 | --- a/fs/dlm/netlink.c | |
24 | +++ b/fs/dlm/netlink.c | |
25 | @@ -127,8 +127,8 @@ static void fill_data(struct dlm_lock_data *data, struct dlm_lkb *lkb) | |
26 | ||
27 | void dlm_timeout_warn(struct dlm_lkb *lkb) | |
28 | { | |
29 | + struct sk_buff *uninitialized_var(send_skb); | |
30 | struct dlm_lock_data *data; | |
31 | - struct sk_buff *send_skb; | |
32 | size_t size; | |
33 | int rv; | |
34 |