]>
Commit | Line | Data |
---|---|---|
2cb7cef9 BS |
1 | From: Gerald Schaefer <geraldsc@de.ibm.com> |
2 | Subject: lcs: invalid return codes from hard_start_xmit. | |
3 | References: bnc#484767,LTC#52201 | |
4 | ||
5 | Symptom: Messages about invalid return codes in /var/log/messages. The data | |
6 | transmission works ok. | |
7 | Problem: LCS hard_start_xmit returns non-standard Return Codes. | |
8 | Solution: Now lcs returns only either NETDEV_TX_OK or NETDEV_TX_BUSY. | |
9 | ||
10 | Acked-by: John Jolly <jjolly@suse.de> | |
11 | --- | |
12 | Index: linux-sles11/drivers/s390/net/lcs.c | |
13 | =================================================================== | |
14 | --- linux-sles11.orig/drivers/s390/net/lcs.c | |
15 | +++ linux-sles11/drivers/s390/net/lcs.c | |
16 | @@ -1553,7 +1553,7 @@ __lcs_start_xmit(struct lcs_card *card, | |
17 | if (skb == NULL) { | |
18 | card->stats.tx_dropped++; | |
19 | card->stats.tx_errors++; | |
20 | - return -EIO; | |
21 | + return 0; | |
22 | } | |
23 | if (card->state != DEV_STATE_UP) { | |
24 | dev_kfree_skb(skb); | |
25 | @@ -1578,7 +1578,7 @@ __lcs_start_xmit(struct lcs_card *card, | |
26 | card->tx_buffer = lcs_get_buffer(&card->write); | |
27 | if (card->tx_buffer == NULL) { | |
28 | card->stats.tx_dropped++; | |
29 | - rc = -EBUSY; | |
30 | + rc = NETDEV_TX_BUSY; | |
31 | goto out; | |
32 | } | |
33 | card->tx_buffer->callback = lcs_txbuffer_cb; |