]>
Commit | Line | Data |
---|---|---|
4d1e5b62 AF |
1 | From: Jay Lan <jlan@sgi.com> |
2 | Subject: Fix CONFIG_KDB_KDUMP on xSeries | |
3 | Patch-mainline: not yet | |
4 | References: bnc#436454 | |
5 | ||
6 | This patch fixes a problem that the capture kernel crashes with various | |
7 | backtraces after the machine has been crashed (both sysrq-trigger and panic()). | |
8 | Machines were that problem could reproduced at SUSE were molitor.suse.de and | |
9 | korner.suse.de. | |
10 | ||
11 | KDB was turned off in that scenarios. | |
12 | ||
13 | That patch succeeds in following scenarios: | |
14 | ||
15 | a) kdb=0 | |
16 | modprobe crasher call_panic | |
17 | ||
18 | b) kdb=1/0 | |
19 | echo c > /proc/sysrq-trigger | |
20 | ||
21 | b) kdb=1 | |
22 | ESC KDB | |
23 | kdb> kdump | |
24 | ||
25 | But it fails in: | |
26 | ||
27 | kdb=1 | |
28 | modprobe crasher call_panic | |
29 | ||
30 | That has to be investigated. But I think that's unrelated to that patch, | |
31 | and it's no regression. | |
32 | ||
33 | ||
34 | Signed-off-by: Jay Lan <jlan@sgi.com> | |
35 | Signed-off-by: Bernhard Walle <bwalle@suse.de> | |
36 | ||
37 | --- | |
38 | arch/x86/kdb/kdba_support.c | 4 +--- | |
39 | 1 file changed, 1 insertion(+), 3 deletions(-) | |
40 | ||
41 | --- a/arch/x86/kdb/kdba_support.c | |
42 | +++ b/arch/x86/kdb/kdba_support.c | |
43 | @@ -35,8 +35,6 @@ void kdba_kdump_prepare(struct pt_regs * | |
44 | if (regs == NULL) | |
45 | regs = &r; | |
46 | ||
47 | - machine_crash_shutdown_begin(); | |
48 | - | |
49 | for (i = 1; i < NR_CPUS; ++i) { | |
50 | if (!cpu_online(i)) | |
51 | continue; | |
52 | @@ -44,7 +42,7 @@ void kdba_kdump_prepare(struct pt_regs * | |
53 | KDB_STATE_SET_CPU(KEXEC, i); | |
54 | } | |
55 | ||
56 | - machine_crash_shutdown_end(regs); | |
57 | + machine_crash_shutdown(regs); | |
58 | } | |
59 | ||
60 | extern void halt_current_cpu(struct pt_regs *); |