/*
- * AUTHOR: Pedro Lineu Orso orso@brturbo.com.br
- * 1998, 2005
- * SARG Squid Analysis Report Generator http://sarg-squid.org
+ * SARG Squid Analysis Report Generator http://sarg.sourceforge.net
+ * 1998, 2010
*
* SARG donations:
* please look at http://sarg.sourceforge.net/donations.php
+ * Support:
+ * http://sourceforge.net/projects/sarg/forums/forum/363374
* ---------------------------------------------------------------------
*
* This program is free software; you can redistribute it and/or modify
*/
#include "include/conf.h"
+#include "include/defs.h"
-void smartfilter_report()
+void smartfilter_report(void)
{
FILE *fp_in = NULL, *fp_ou = NULL, *fp_user = NULL;
-
+
char url[MAXLEN];
- char html[MAXLEN];
- char html2[MAXLEN];
char csort[255];
char smart_in[MAXLEN];
char smart_ou[MAXLEN];
char per[MAXLEN];
char sites[MAXLEN];
char report[MAXLEN];
- char periodo[100];
+ char period[100];
char ip[MAXLEN];
char user[MAXLEN];
char ouser[MAXLEN];
char smartuser[MAXLEN];
char *str;
int fuser=0;
+ int cstatus;
+ struct getwordstruct gwarea;
ouser[0]='\0';
strup(smartheader);
sprintf(smart_in,"%s/smartfilter.unsort",dirname);
- sprintf(sites,"%s/sites",dirname);
+ sprintf(sites,"%s/sarg-sites",dirname);
sprintf(smart_ou,"%s/smartfilter.log",dirname);
- sprintf(per,"%s/periodo",dirname);
+ sprintf(per,"%s/sarg-period",dirname);
sprintf(report,"%s/smartfilter.html",dirname);
if ((fp_in = fopen(per, "r")) == 0) {
exit(1);
}
- fgets(periodo,sizeof(periodo),fp_in);
+ if (!fgets(period,sizeof(period),fp_in)) {
+ fprintf(stderr,"SARG: (smartfilter) read error in %s\n",per);
+ exit(1);
+ }
fclose(fp_in);
- sprintf(csort,"sort -n -k 1,1 -k 2,2 -k 3,3 -o %s %s",smart_ou,smart_in);
- system(csort);
- unlink(smart_in);
-
+ if (snprintf(csort,sizeof(csort),"sort -n -k 1,1 -k 2,2 -k 3,3 -o \"%s\" \"%s\"",smart_ou,smart_in)>=sizeof(csort)) {
+ fprintf(stderr,"SARG: cannot sort file %s\n",smart_in);
+ exit(1);
+ }
+ cstatus=system(csort);
+ if (!WIFEXITED(cstatus) || WEXITSTATUS(cstatus)) {
+ fprintf(stderr, "SARG: sort command return status %d\n",WEXITSTATUS(cstatus));
+ fprintf(stderr, "SARG: sort command: %s\n",csort);
+ exit(1);
+ }
if((fp_in=fopen(smart_ou,"r"))==NULL) {
- fprintf(stderr, "SARG: (smartfilter) %s: %s\n",text[8],smart_ou);
- exit(1);
+ fprintf(stderr, "SARG: (smartfilter) %s: %s\n",text[8],smart_ou);
+ fprintf(stderr, "SARG: sort command: %s\n",csort);
+ exit(1);
}
+ unlink(smart_in);
if((fp_ou=fopen(report,"w"))==NULL) {
fprintf(stderr, "SARG: (smartfilter) %s: %s\n",text[8],report);
exit(1);
}
- fputs("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\"",fp_ou);
- fputs(" \"http://www.w3.org/TR/html4/loose.dtd\">\n",fp_ou);
- fputs("<html>\n",fp_ou);
- fputs("<head>\n",fp_ou);
- sprintf(html," <meta http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">\n",CharSet);
- fputs(html,fp_ou);
+ fprintf(fp_ou, "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\" \"http://www.w3.org/TR/html4/loose.dtd\">\n<html>\n<head>\n <meta http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">\n",CharSet);
fputs("</head>\n",fp_ou);
+ if(strlen(FontFace) > 0) fprintf(fp_ou,"<font face=%s>\n",FontFace);
+ fprintf(fp_ou,"<body bgcolor=\"%s\" text=\"%s\" background=\"%s\">\n",BgColor,TxColor,BgImage);
+ fputs("<div align=\"center\"><table cellpadding=\"0\" cellspacing=\"0\">\n",fp_ou);
+ write_logo_image(fp_ou);
- if(strlen(FontFace) > 0) {
- sprintf(url,"<font face=%s>\n",FontFace);
- fputs(url,fp_ou);
- }
-
- sprintf(url,"<body bgcolor=%s text=%s background='%s'>\n",BgColor,TxColor,BgImage);
- fputs(url,fp_ou);
-
- fputs("<center><table cellpadding=0 cellspacing=0>\n",fp_ou);
-
- if(strlen(LogoImage) > 0) {
- sprintf(url,"<tr><th><img src='%s' border=0 align=absmiddle width=%s height=%s><font color=%s>%s</font>\n",LogoImage,Width,Height,LogoTextColor,LogoText);
- fputs(url,fp_ou);
- }
-
- sprintf(url,"<tr><th align=center><b><font color=%s size=+1>%s</font></b></th></tr>\n",TiColor,Title);
- fputs(url,fp_ou);
-
- sprintf(url,"<tr><td align=center bgcolor=%s><font size=%s>%s: %s</font></td></tr>\n",HeaderBgColor,FontSize,text[89],periodo);
- fputs(url,fp_ou);
- sprintf(url,"<tr><th bgcolor=%s align=center><font size=%s>%s %s</font></th></tr>\n",HeaderBgColor,FontSize,text[116],text[55]);
- fputs(url,fp_ou);
- fputs("</table></center>\n",fp_ou);
+ fprintf(fp_ou,"<tr><th align=\"center\"><b><font color=\"%s\" size=\"+1\">%s</font></b></th></tr>\n",TiColor,Title);
+ fprintf(fp_ou,"<tr><td align=\"center\" bgcolor=\"%s\"><font size=\"%s\">%s: %s</font></td></tr>\n",HeaderBgColor,FontSize,text[89],period);
+ fprintf(fp_ou,"<tr><th bgcolor=\"%s\" align=\"center\"><font size=\"%s\">%s</font></th></tr>\n",HeaderBgColor,FontSize,text[116]);
+ fputs("</table></div>\n",fp_ou);
- fputs("<center><table cellpadding=0 cellspacing=2>\n",fp_ou);
+ fputs("<div align=\"center\"><table cellpadding=\"0\" cellspacing=\"2\">\n",fp_ou);
fputs("<tr><td></td></tr>\n",fp_ou);
fputs("<tr><td></td></tr>\n",fp_ou);
fputs("<tr><td></td></tr>\n",fp_ou);
- sprintf(url,"<tr><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th></tr>\n",HeaderBgColor,FontSize,text[98],HeaderBgColor,FontSize,text[111],HeaderBgColor,FontSize,text[110],HeaderBgColor,FontSize,text[91],HeaderBgColor,FontSize,smartheader);
- fputs(url,fp_ou);
+ fprintf(fp_ou,"<tr><th bgcolor=%s><font size=\"%s\">%s</font></th><th bgcolor=\"%s\"><font size=\"%s\">%s</font></th><th bgcolor=\"%s\"><font size=\"%s\">%s</font></th><th bgcolor=\"%s\"><font size=\"%s\">%s</font></th><th bgcolor=\"%s\"><font size=\"%s\">%s</font></th></tr>\n",HeaderBgColor,FontSize,text[98],HeaderBgColor,FontSize,text[111],HeaderBgColor,FontSize,text[110],HeaderBgColor,FontSize,text[91],HeaderBgColor,FontSize,smartheader);
while(fgets(buf,sizeof(buf),fp_in)!=NULL) {
- getword(user,buf,' ');
- getword(data,buf,' ');
- getword(hora,buf,' ');
- getword(ip,buf,' ');
- getword(url,buf,' ');
- getword(smartcat,buf,'\n');
+ getword_start(&gwarea,buf);
+ if (getword(user,sizeof(user),&gwarea,'\t')<0 || getword(data,sizeof(data),&gwarea,'\t')<0 ||
+ getword(hora,sizeof(hora),&gwarea,'\t')<0 || getword(ip,sizeof(ip),&gwarea,'\t')<0 ||
+ getword(url,sizeof(url),&gwarea,'\t')<0 || getword(smartcat,sizeof(smartcat),&gwarea,'\n')<0) {
+ printf("SARG: Maybe you have a broken record or garbage in your %s file.\n",smart_ou);
+ exit(1);
+ }
if((str=(char *) strstr(user, "_")) != (char *) NULL ) {
if((str=(char *) strstr(str+1, "_")) != (char *) NULL )
if(fuser) {
fuser=0;
fputs("</table>\n",fp_user);
- if(strcmp(ShowSargInfo,"yes") == 0) {
- zdate(ftime, DateFormat);
- sprintf(html2,"<br><br><center><font size=-2>%s <a href='%s'>%s-%s</a> %s %s</font></center>\n",text[108],URL,PGM,VERSION,text[109],ftime);
- fputs(html2,fp_user);
- }
+ if(ShowSargInfo) {
+ zdate(ftime, sizeof(ftime), DateFormat);
+ fprintf(fp_user,"<br><br><div align=\"center\"><font size=\"-2\">%s <a href=\"%s\">%s-%s</a> %s %s</font></div>\n",text[108],URL,PGM,VERSION,text[109],ftime);
+ }
fputs("</body>\n</html>\n",fp_user);
fclose(fp_user);
}
fputs(" \"http://www.w3.org/TR/html4/loose.dtd\">\n",fp_ou);
fputs("<html>\n",fp_user);
fputs("<head>\n",fp_user);
- sprintf(html," <meta http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">\n",CharSet);
- fputs(html,fp_user);
+ fprintf(fp_user," <meta http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">\n",CharSet);
fputs("</head>\n",fp_user);
- if(strlen(FontFace) > 0) {
+ if(FontFace[0] != 0) {
+ /*
+ Before merging the sprintf and the fputs, the code looked like this:
sprintf(html2,"<font face=%s>\n",FontFace);
fputs(url,fp_user);
+ The two lines don't use the same buffer so the string formated by sprintf is not the string
+ written to fp_user. I (fmarchal) assumed it was a typo and replaced it by a fprintf but
+ that font tag is not valid outside of the body. So, the generated html was likely
+ containing garbage not rendered by the browser.
+ */
+ fprintf(fp_user,"<font face=%s>\n",FontFace);
}
- sprintf(html2,"<body bgcolor=%s text=%s background='%s'>\n",BgColor,TxColor,BgImage);
- fputs(html2,fp_user);
- fputs("<center><table cellpadding=0 cellspacing=0>\n",fp_user);
- if(strlen(LogoImage) > 0) {
- sprintf(html2,"<tr><th align=left><img src='%s' border=0 align=absmiddle width=%s height=%s><font color=%s>%s</font>\n",LogoImage,Width,Height,LogoTextColor,LogoText);
- fputs(html2,fp_user);
- }
- sprintf(html2,"<tr><th align=center><b><font color=%s size=+1>%s</font></b></th></tr>\n",TiColor,Title);
- fputs(html2,fp_user);
- sprintf(html2,"<tr><td align=center bgcolor=%s><font size=%s>%s: %s</font></td></tr>\n",HeaderBgColor,FontSize,text[89],periodo);
- fputs(html2,fp_user);
- sprintf(html2,"<tr><td align=center bgcolor=%s><font size=%s>%s:</font><font size=%s> %s</font></td></tr>\n",HeaderBgColor,FontSize,text[90],FontSize,user);
- fputs(html2,fp_user);
- fputs("</table></center>\n",fp_user);
- fputs("<center><table cellpadding=0 cellspacing=2>\n",fp_user);
+ fprintf(fp_user,"<body bgcolor=\"%s\" text=\"%s\" background=\"%s\">\n",BgColor,TxColor,BgImage);
+ fputs("<div align=\"center\"><table cellpadding=\"0\" cellspacing=\"0\">\n",fp_user);
+ if(LogoImage[0]!='\0') fprintf(fp_user,"<tr><th align=left><img src=\"%s\" border=\"0\" align=\"absmiddle\" width=\"%s\" height=\"%s\"><font color=\"%s\">%s</font>\n",LogoImage,Width,Height,LogoTextColor,LogoText);
+ fprintf(fp_user,"<tr><th align=\"center\"><b><font color=\"%s\" size=\"+1\">%s</font></b></th></tr>\n",TiColor,Title);
+ fprintf(fp_user,"<tr><td align=center bgcolor=%s><font size=%s>%s: %s</font></td></tr>\n",HeaderBgColor,FontSize,text[89],period);
+ fprintf(fp_user,"<tr><td align=center bgcolor=%s><font size=%s>%s:</font><font size=%s> %s</font></td></tr>\n",HeaderBgColor,FontSize,text[90],FontSize,user);
+ fputs("</table></div>\n",fp_user);
+ fputs("<div align=\"center\"><table cellpadding=0 cellspacing=2>\n",fp_user);
fputs("<tr><td></td></tr>\n",fp_user);
fputs("<tr><td></td></tr>\n",fp_user);
fputs("<tr><td></td></tr>\n",fp_user);
- sprintf(html2,"<tr><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th></tr>\n",HeaderBgColor,FontSize,text[98],HeaderBgColor,FontSize,text[111],HeaderBgColor,FontSize,text[110],HeaderBgColor,FontSize,text[91],HeaderBgColor,FontSize,smartheader);
- fputs(html2,fp_user);
+ fprintf(fp_user,"<tr><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th><th bgcolor=%s><font size=%s>%s</font></th></tr>\n",HeaderBgColor,FontSize,text[98],HeaderBgColor,FontSize,text[111],HeaderBgColor,FontSize,text[110],HeaderBgColor,FontSize,text[91],HeaderBgColor,FontSize,smartheader);
}
- sprintf(html2,"<tr><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s-%s</font></td><td bgcolor=%s><font size=%s>%s</font></td><td bgcolor=%s><font size=%s>%s</font></td></th>\n",TxBgColor,FontSize,user,TxBgColor,FontSize,ip,TxBgColor,FontSize,data,hora,TxBgColor,FontSize,url,TxBgColor,FontSize,smartcat);
- fputs(html2,fp_user);
+ fprintf(fp_user,"<tr><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s-%s</font></td><td bgcolor=%s><font size=%s>%s</font></td><td bgcolor=%s><font size=%s>%s</font></td></th>\n",TxBgColor,FontSize,user,TxBgColor,FontSize,ip,TxBgColor,FontSize,data,hora,TxBgColor,FontSize,url,TxBgColor,FontSize,smartcat);
- sprintf(html,"<tr><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s-%s</font></td><td bgcolor=%s><font size=%s>%s</font></td><td bgcolor=%s><font size=%s>%s</font></td></th>\n",TxBgColor,FontSize,user,TxBgColor,FontSize,ip,TxBgColor,FontSize,data,hora,TxBgColor,FontSize,url,TxBgColor,FontSize,smartcat);
- fputs(html,fp_ou);
+ fprintf(fp_ou,"<tr><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s</font></td><td bgcolor=%s align=center><font size=%s>%s-%s</font></td><td bgcolor=%s><font size=%s>%s</font></td><td bgcolor=%s><font size=%s>%s</font></td></th>\n",TxBgColor,FontSize,user,TxBgColor,FontSize,ip,TxBgColor,FontSize,data,hora,TxBgColor,FontSize,url,TxBgColor,FontSize,smartcat);
}
fputs("</table>\n",fp_ou);
- if(strcmp(ShowSargInfo,"yes") == 0) {
- zdate(ftime, DateFormat);
- sprintf(html,"<br><br><center><font size=-2>%s <a href='%s'>%s-%s</a> %s %s</font></center>\n",text[108],URL,PGM,VERSION,text[109],ftime);
- fputs(html,fp_ou);
+ if(ShowSargInfo) {
+ zdate(ftime, sizeof(ftime), DateFormat);
+ fprintf(fp_ou,"<br><br><div align=\"center\"><font size=\"-2\">%s <a href=\"%s\">%s-%s</a> %s %s</font></div>\n",text[108],URL,PGM,VERSION,text[109],ftime);
}
fputs("</body>\n</html>\n",fp_user);
fclose(fp_ou);
if(fp_user) {
fputs("</table>\n",fp_user);
- if(strcmp(ShowSargInfo,"yes") == 0) {
- zdate(ftime, DateFormat);
- sprintf(html2,"<br><br><center><font size=-2>%s <a href='%s'>%s-%s</a> %s %s</font></center>\n",text[108],URL,PGM,VERSION,text[109],ftime);
- fputs(html2,fp_user);
+ if(ShowSargInfo) {
+ zdate(ftime, sizeof(ftime), DateFormat);
+ fprintf(fp_user,"<br><br><div align=\"center\"><font size=\"-2\">%s <a href=\"%s\">%s-%s</a> %s %s</font></div>\n",text[108],URL,PGM,VERSION,text[109],ftime);
}
fputs("</body>\n</html>\n",fp_user);
fclose(fp_user);