NULL
};
-static int system_chroot(const char* path, const char* cmd) {
+static int system_chroot(const char* output, const char* path, const char* cmd) {
char chroot_cmd[STRING_SIZE];
snprintf(chroot_cmd, sizeof(chroot_cmd), "/usr/sbin/chroot %s %s", path, cmd);
- return mysystem(chroot_cmd);
+ return mysystem(output, chroot_cmd);
}
struct hw* hw_init() {
}
int hw_umount(const char* target) {
- return umount2(target, MNT_DETACH);
+ return umount2(target, 0);
}
static int hw_test_source_medium(const char* path) {
return size;
}
-struct hw_disk** hw_find_disks(struct hw* hw) {
+struct hw_disk** hw_find_disks(struct hw* hw, const char* sourcedrive) {
struct hw_disk** ret = hw_create_disks();
struct hw_disk** disks = ret;
continue;
}
- // DEVTYPE must be disk (otherwise we will see all sorts of partitions here)
- const char* devtype = udev_device_get_property_value(dev, "DEVTYPE");
- if (devtype && (strcmp(devtype, "disk") != 0)) {
+ // Skip sourcedrive if we need to
+ if (sourcedrive && (strcmp(dev_path, sourcedrive) == 0)) {
udev_device_unref(dev);
continue;
}
- // Skip all source mediums
- if (hw_test_source_medium(dev_path) == 0) {
+ // DEVTYPE must be disk (otherwise we will see all sorts of partitions here)
+ const char* devtype = udev_device_get_property_value(dev, "DEVTYPE");
+ if (devtype && (strcmp(devtype, "disk") != 0)) {
udev_device_unref(dev);
continue;
}
disk->ref = 1;
strncpy(disk->path, dev_path, sizeof(disk->path));
+ const char* p = disk->path + 5;
disk->size = size;
vendor = udev_device_get_sysattr_value(dev, "vendor");
if (!vendor)
vendor = udev_device_get_sysattr_value(dev, "manufacturer");
- if (!vendor)
- vendor = "N/A";
- strncpy(disk->vendor, vendor, sizeof(disk->vendor));
+ if (vendor)
+ strncpy(disk->vendor, vendor, sizeof(disk->vendor));
+ else
+ *disk->vendor = '\0';
// Model
const char* model = udev_device_get_property_value(dev, "ID_MODEL");
model = udev_device_get_sysattr_value(dev, "model");
if (!model)
model = udev_device_get_sysattr_value(dev, "product");
- if (!model)
- model = "N/A";
- strncpy(disk->model, model, sizeof(disk->model));
+ if (model)
+ strncpy(disk->model, model, sizeof(disk->model));
+ else
+ *disk->model = '\0';
+
+ // Format description
+ char size_str[STRING_SIZE];
+ snprintf(size_str, sizeof(size_str), "%4.1fGB", (double)disk->size / pow(1024, 3));
+
+ if (*disk->vendor && *disk->model) {
+ snprintf(disk->description, sizeof(disk->description),
+ "%s - %s - %s - %s", size_str, p, disk->vendor, disk->model);
+
+ } else if (*disk->vendor || *disk->model) {
+ snprintf(disk->description, sizeof(disk->description),
+ "%s - %s - %s", size_str, p, (*disk->vendor) ? disk->vendor : disk->model);
- snprintf(disk->description, sizeof(disk->description),
- "%4.1fGB %s - %s", (double)disk->size / pow(1024, 3),
- disk->vendor, disk->model);
+ } else {
+ snprintf(disk->description, sizeof(disk->description),
+ "%s - %s", size_str, p);
+ }
*disks++ = disk;
unsigned int num_disks = hw_count_disks(disks);
for (unsigned int i = 0; i < num_disks; i++) {
- if (selection && selection[i]) {
+ if (!selection || selection[i]) {
struct hw_disk *selected_disk = disks[i];
selected_disk->ref++;
return MB2BYTES(64);
}
+static int hw_device_has_p_suffix(const struct hw_destination* dest) {
+ // All RAID devices have the p suffix.
+ if (dest->is_raid)
+ return 1;
+
+ // Devices with a number at the end have the p suffix, too.
+ // e.g. mmcblk0, cciss0
+ unsigned int last_char = strlen(dest->path);
+ if ((dest->path[last_char] >= '0') && (dest->path[last_char] <= '9'))
+ return 1;
+
+ return 0;
+}
+
static int hw_calculate_partition_table(struct hw_destination* dest) {
char path[DEV_SIZE];
int part_idx = 1;
- snprintf(path, sizeof(path), "%s%s", dest->path, (dest->is_raid) ? "p" : "");
+ snprintf(path, sizeof(path), "%s%s", dest->path,
+ hw_device_has_p_suffix(dest) ? "p" : "");
dest->part_boot_idx = 0;
// Determine the size of the target block device
return memory * 1024;
}
-int hw_create_partitions(struct hw_destination* dest) {
- char* cmd = NULL;
+static int hw_zero_out_device(const char* path, int bytes) {
+ char block[512];
+ memset(block, 0, sizeof(block));
+
+ int blocks = bytes / sizeof(block);
+ int fd = open(path, O_WRONLY);
+ if (fd < 0)
+ return -1;
+
+ unsigned int bytes_written = 0;
+ while (blocks-- > 0) {
+ bytes_written += write(fd, block, sizeof(block));
+ }
+
+ fsync(fd);
+ close(fd);
+
+ return bytes_written;
+}
+
+static int try_open(const char* path) {
+ FILE* f = fopen(path, "r");
+ if (f) {
+ fclose(f);
+ return 0;
+ }
+
+ return -1;
+}
+
+int hw_create_partitions(struct hw_destination* dest, const char* output) {
+ // Before we write a new partition table to the disk, we will erase
+ // the first couple of megabytes at the beginning of the device to
+ // get rid of all left other things like bootloaders and partition tables.
+ // This solves some problems when changing from MBR to GPT partitions or
+ // the other way around.
+ int r = hw_zero_out_device(dest->path, MB2BYTES(10));
+ if (r <= 0)
+ return r;
+
+ char* cmd = NULL;
asprintf(&cmd, "/usr/sbin/parted -s %s -a optimal", dest->path);
// Set partition type
part_start += dest->size_data;
}
- if (dest->part_table == HW_PART_TABLE_MSDOS && dest->part_boot_idx > 0) {
+ if (dest->part_boot_idx > 0)
asprintf(&cmd, "%s set %d boot on", cmd, dest->part_boot_idx);
- } else if (dest->part_table == HW_PART_TABLE_GPT) {
+ if (dest->part_table == HW_PART_TABLE_GPT) {
if (*dest->part_bootldr) {
asprintf(&cmd, "%s set %d bios_grub on", cmd, dest->part_boot_idx);
}
asprintf(&cmd, "%s disk_set pmbr_boot on", cmd);
}
- int r = mysystem(cmd);
+ r = mysystem(output, cmd);
// Wait until the system re-read the partition table
if (r == 0) {
while (counter-- > 0) {
sleep(1);
- if (*dest->part_bootldr && (access(dest->part_bootldr, R_OK) != 0))
+ if (*dest->part_bootldr && (try_open(dest->part_bootldr) != 0))
continue;
- if (*dest->part_boot && (access(dest->part_boot, R_OK) != 0))
+ if (*dest->part_boot && (try_open(dest->part_boot) != 0))
continue;
- if (*dest->part_swap && (access(dest->part_swap, R_OK) != 0))
+ if (*dest->part_swap && (try_open(dest->part_swap) != 0))
continue;
- if (*dest->part_root && (access(dest->part_root, R_OK) != 0))
+ if (*dest->part_root && (try_open(dest->part_root) != 0))
continue;
- if (*dest->part_data && (access(dest->part_data, R_OK) != 0))
+ if (*dest->part_data && (try_open(dest->part_data) != 0))
continue;
// All partitions do exist, exiting the loop.
return r;
}
-static int hw_format_filesystem(const char* path, int fs) {
+static int hw_format_filesystem(const char* path, int fs, const char* output) {
char cmd[STRING_SIZE] = "\0";
// Swap
assert(*cmd);
- int r = mysystem(cmd);
+ int r = mysystem(output, cmd);
return r;
}
-int hw_create_filesystems(struct hw_destination* dest) {
+int hw_create_filesystems(struct hw_destination* dest, const char* output) {
int r;
// boot
if (*dest->part_boot) {
- r = hw_format_filesystem(dest->part_boot, dest->filesystem);
+ r = hw_format_filesystem(dest->part_boot, dest->filesystem, output);
if (r)
return r;
}
// swap
if (*dest->part_swap) {
- r = hw_format_filesystem(dest->part_swap, HW_FS_SWAP);
+ r = hw_format_filesystem(dest->part_swap, HW_FS_SWAP, output);
if (r)
return r;
}
// root
- r = hw_format_filesystem(dest->part_root, dest->filesystem);
+ r = hw_format_filesystem(dest->part_root, dest->filesystem, output);
if (r)
return r;
// data
if (*dest->part_data) {
- r = hw_format_filesystem(dest->part_data, dest->filesystem);
+ r = hw_format_filesystem(dest->part_data, dest->filesystem, output);
if (r)
return r;
}
}
int hw_umount_filesystems(struct hw_destination* dest, const char* prefix) {
+ // Write all buffers to disk before umounting
+ hw_sync();
+
// boot
if (*dest->part_boot) {
hw_umount(dest->part_boot);
return 0;
}
-int hw_setup_raid(struct hw_destination* dest) {
+int hw_destroy_raid_superblocks(const struct hw_destination* dest, const char* output) {
+ char cmd[STRING_SIZE];
+
+ hw_stop_all_raid_arrays(output);
+ hw_stop_all_raid_arrays(output);
+
+ if (dest->disk1) {
+ snprintf(cmd, sizeof(cmd), "/sbin/mdadm --zero-superblock %s", dest->disk1->path);
+ mysystem(output, cmd);
+ }
+
+ if (dest->disk2) {
+ snprintf(cmd, sizeof(cmd), "/sbin/mdadm --zero-superblock %s", dest->disk2->path);
+ mysystem(output, cmd);
+ }
+
+ return 0;
+}
+
+int hw_setup_raid(struct hw_destination* dest, const char* output) {
char* cmd = NULL;
+ int r;
assert(dest->is_raid);
- asprintf(&cmd, "echo \"y\" | /sbin/mdadm --create --verbose --metadata=1.2 %s", dest->path);
+ // Stop all RAID arrays that might be around (again).
+ // It seems that there is some sort of race-condition with udev re-enabling
+ // the raid arrays and therefore locking the disks.
+ r = hw_destroy_raid_superblocks(dest, output);
+
+ asprintf(&cmd, "echo \"y\" | /sbin/mdadm --create --verbose --metadata=%s --auto=mdp %s",
+ RAID_METADATA, dest->path);
switch (dest->raid_level) {
case 1:
if (dest->disk1) {
asprintf(&cmd, "%s %s", cmd, dest->disk1->path);
+
+ // Clear all data at the beginning
+ r = hw_zero_out_device(dest->disk1->path, MB2BYTES(10));
+ if (r <= 0)
+ return r;
}
if (dest->disk2) {
asprintf(&cmd, "%s %s", cmd, dest->disk2->path);
+
+ // Clear all data at the beginning
+ r = hw_zero_out_device(dest->disk2->path, MB2BYTES(10));
+ if (r <= 0)
+ return r;
}
- int r = mysystem(cmd);
+ r = mysystem(output, cmd);
free(cmd);
// Wait a moment until the device has been properly brought up
// If the raid device has not yet been properly brought up,
// opening it will fail with the message: Device or resource busy
// Hence we will wait a bit until it becomes usable.
- FILE* f = fopen(dest->path, "r");
- if (f) {
- fclose(f);
+ if (try_open(dest->path) == 0)
break;
- }
}
}
return r;
}
-int hw_stop_all_raid_arrays() {
- return mysystem("/sbin/mdadm --stop --scan");
+int hw_stop_all_raid_arrays(const char* output) {
+ return mysystem(output, "/sbin/mdadm --stop --scan --verbose");
}
-int hw_install_bootloader(struct hw_destination* dest) {
+int hw_install_bootloader(struct hw_destination* dest, const char* output) {
char cmd[STRING_SIZE];
int r;
// Generate configuration file
snprintf(cmd, sizeof(cmd), "/usr/sbin/grub-mkconfig -o /boot/grub/grub.cfg");
- r = system_chroot(DESTINATION_MOUNT_PATH, cmd);
+ r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
if (r)
return r;
char cmd_grub[STRING_SIZE];
snprintf(cmd_grub, sizeof(cmd_grub), "/usr/sbin/grub-install --no-floppy --recheck");
- if (dest->is_raid && (dest->part_table == HW_PART_TABLE_MSDOS)) {
+ if (dest->is_raid) {
snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->disk1->path);
- r = system_chroot(DESTINATION_MOUNT_PATH, cmd);
+ r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
if (r)
return r;
snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->disk2->path);
- r = system_chroot(DESTINATION_MOUNT_PATH, cmd);
+ r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
} else {
snprintf(cmd, sizeof(cmd), "%s %s", cmd_grub, dest->path);
- r = system_chroot(DESTINATION_MOUNT_PATH, cmd);
+ r = system_chroot(output, DESTINATION_MOUNT_PATH, cmd);
}
return r;
return 0;
}
+
+void hw_sync() {
+ sync();
+ sync();
+ sync();
+}