]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing: Fix very unlikely race of registering two stat tracers
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 24 Jan 2020 22:47:49 +0000 (17:47 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 22 May 2020 20:19:34 +0000 (21:19 +0100)
commit153e1d6d38d491ada8f0a0205c51bdd790ccac2c
treeb3e329fea419f1f580f3a4dc74d8786f04df3d68
parent22725fee3d79718feccb5eee32beeb40583cc086
tracing: Fix very unlikely race of registering two stat tracers

commit dfb6cd1e654315168e36d947471bd2a0ccd834ae upstream.

Looking through old emails in my INBOX, I came across a patch from Luis
Henriques that attempted to fix a race of two stat tracers registering the
same stat trace (extremely unlikely, as this is done in the kernel, and
probably doesn't even exist). The submitted patch wasn't quite right as it
needed to deal with clean up a bit better (if two stat tracers were the
same, it would have the same files).

But to make the code cleaner, all we needed to do is to keep the
all_stat_sessions_mutex held for most of the registering function.

Link: http://lkml.kernel.org/r/1410299375-20068-1-git-send-email-luis.henriques@canonical.com
Fixes: 002bb86d8d42f ("tracing/ftrace: separate events tracing and stats tracing engine")
Reported-by: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/trace/trace_stat.c