]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
r8169: disable ASPM again
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 5 Apr 2019 18:46:46 +0000 (20:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 06:38:41 +0000 (08:38 +0200)
commit1e4a7e7869acc57987d0e0b2ecf53b9a74fb911a
treefc824969039c6c1641149e857dc17e6fea5d8c2b
parent84dc2f872d2d70bfd045b0ef716d5b55b5e1ae13
r8169: disable ASPM again

[ Upstream commit b75bb8a5b755d0c7bf1ac071e4df2349a7644a1e ]

There's a significant number of reports that re-enabling ASPM causes
different issues, ranging from decreased performance to system not
booting at all. This affects only a minority of users, but the number
of affected users is big enough that we better switch off ASPM again.

This will hurt notebook users who are not affected by the issues, they
may see decreased battery runtime w/o ASPM. With the PCI core folks is
being discussed to add generic sysfs attributes to control ASPM.
Once this is in place brave enough users can re-enable ASPM on their
system.

Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/realtek/r8169.c