]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commit
libext2fs: fix off-by-one bug in punch_extent_blocks
authorDarrick J. Wong <djwong@kernel.org>
Sun, 6 Jul 2025 18:31:00 +0000 (11:31 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 31 Jul 2025 14:36:15 +0000 (10:36 -0400)
commit509da98991e2a3f72042c6b29e538a5269357a80
treed2b1a8d34cc43484c90620649e304dc30e21884f
parentfb9b2e7c9cf90e2c4eabcf1cffbde443e8eeb360
libext2fs: fix off-by-one bug in punch_extent_blocks

punch_extent_blocks tries to validate its input parameters to make sure
that the physical range of blocks being punched do not go past the end
of the filesystem.  Unfortunately, there's an off-by-one bug in the
valiation, because start==0 count==10 is a perfectly valid range on a
10-block filesystem.

Cc: linux-ext4@vger.kernel.org # v1.46.6
Fixes: 6772d4969e9c90 ("libext2fs: check for invalid blocks in ext2fs_punch_blocks()")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lore.kernel.org/r/175182662987.1984706.5292286424808159532.stgit@frogsfrogsfrogs
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/punch.c