]> git.ipfire.org Git - thirdparty/qemu.git/commit
arm_gicv3_kvm: Fix compile warning
authorPranith Kumar <bobby.prani@gmail.com>
Mon, 4 Sep 2017 14:21:56 +0000 (15:21 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 15 Sep 2017 00:24:05 +0000 (19:24 -0500)
commit85cdc23e755f1f65a1820fb68a8ed91c1f7b3a1f
treea27247f9ca7e88b4ddfd548124321c7e1119f39c
parent168ff32c5d1e05d7e11db28d6bcc257783ba849a
arm_gicv3_kvm: Fix compile warning

Fix the following warning:

/home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
            if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                ^             ~
/home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses after the '!' to evaluate the bitwise operator first
            if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                ^
/home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses around left hand side expression to silence this warning
            if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                ^

This logic error meant we were not setting the PTZ
bit when we should -- luckily as the comment suggests
this wouldn't have had any effects beyond making GIC
initialization take a little longer.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Message-id: 20170829173226.7625-1-bobby.prani@gmail.com
Cc: qemu-stable@nongnu.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 7229ec5825df6b933f150b54a8a2bedd2de1864c)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/intc/arm_gicv3_kvm.c