]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
initscripts fkt: Check that readhash returns 1 on a missing file
authorJonatan Schlag <jonatan.schlag@ipfire.org>
Sun, 16 Jun 2024 16:02:45 +0000 (18:02 +0200)
committerMichael Tremer <michael.tremer@ipfire.org>
Sat, 24 Aug 2024 12:19:56 +0000 (12:19 +0000)
It already does that, so the function is not changed

Signed-off-by: Jonatan Schlag <jonatan.schlag@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
tests/src/initscripts/system/functions/test.sh

index e7f695f55fba7498ab670250b929f488b76f6b68..dbcbd45ef9ce66542518dc5d73fc744562cfebdf 100755 (executable)
@@ -10,6 +10,7 @@ ROOT="$(readlink -f "${SCRIPT_PATH}/../../../../..")"
 
 # read the date in
 readhash "CONFIG" "${SCRIPT_PATH}/data/1"
+test_command [ $? == 0 ]
 
 # test if we read the correct data
 test_value_in_array "CONFIG" "RED_DHCP_HOSTNAME" "ipfire"
@@ -27,6 +28,8 @@ test_that_output_is "${SCRIPT_PATH}/data/1_output_stderr" "2" readhash "CONFIG"
 
 # Check with invalid Lines (values and keys)
 readhash "CONFIG2" "${SCRIPT_PATH}/data/2" &> /dev/null
+test_command [ $? == 0 ]
+
 
 # test if we read the correct data
 test_value_in_array "CONFIG2" "RED_DHCP_HOSTNAME" "ipfire"
@@ -39,4 +42,6 @@ test_value_in_array "CONFIG2" "BLUE_MACADDR" "bc:30:7d:58:6b:e3"
 test_that_output_is "${SCRIPT_PATH}/data/2_output_stdout" "1" readhash "CONFIG2" "${SCRIPT_PATH}/data/2"
 test_that_output_is "${SCRIPT_PATH}/data/2_output_stderr" "2" readhash "CONFIG2" "${SCRIPT_PATH}/data/2"
 
-
+# Check non existent file
+readhash "CONFIG3" "${SCRIPT_PATH}/data/-1" &> /dev/null
+test_command [ $? == 1 ]