]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
hwclock: rely on kernel for RTC_UIE_ON on Aplha and Sparc
authorKarel Zak <kzak@redhat.com>
Fri, 3 Aug 2018 11:08:21 +0000 (13:08 +0200)
committerKarel Zak <kzak@redhat.com>
Fri, 3 Aug 2018 11:08:21 +0000 (13:08 +0200)
It's kernel business to return EINVAL for unsupported RTC_UIE_ON. We
(userspace) should not make decisions about things that we do not
control.

If kernel is wrong then fix the kernel, don't hide the problem by
crazy ifdefs in userspace.

Signed-off-by: Karel Zak <kzak@redhat.com>
sys-utils/hwclock-rtc.c

index 3b069d7aa37f206afe0879548edb0adae4de3b5f..32feb3504e88131797d2cb1f7722683cbaa6a27c 100644 (file)
@@ -253,18 +253,9 @@ static int synchronize_to_clock_tick_rtc(const struct hwclock_control *ctl)
                warn(_("cannot open rtc device"));
                return ret;
        } else {
-               int rc;         /* Return code from ioctl */
                /* Turn on update interrupts (one per second) */
-#if defined(__alpha__) || defined(__sparc__)
-               /*
-                * Not all alpha kernels reject RTC_UIE_ON, but probably
-                * they should.
-                */
-               rc = -1;
-               errno = EINVAL;
-#else
-               rc = ioctl(rtc_fd, RTC_UIE_ON, 0);
-#endif
+               int rc = ioctl(rtc_fd, RTC_UIE_ON, 0);
+
                if (rc != -1) {
                        /*
                         * Just reading rtc_fd fails on broken hardware: no