libmount: add comment, remove TODO item

Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/Documentation/TODO b/Documentation/TODO
index 6b4ee30207864fce028c5d6761d5ce00c33bca7d..22fa0e06f7f5336e837baa8b5f30bf39caa12c7d 100644 (file)
--- a/Documentation/TODO
+++ b/Documentation/TODO
@@ -1,10 +1,6 @@
 
  Note that items with (!) have high priority.
 
-canonicalize
-------------
-  - reimplement realpath(3) (for lib/canonicalize()) to use fstatat(AT_NO_AUTOMOUNT)
-
 lsblk
 -----
   - currently it does not show mountpoint for all devices in btrfs RAID. It's because

diff --git a/libmount/src/context_umount.c b/libmount/src/context_umount.c
index b67f48b918baea05ae3371bafc75cf053392af38..873dd06bf6655e490a079439fa6b8e3e2f1fef3f 100644 (file)
--- a/libmount/src/context_umount.c
+++ b/libmount/src/context_umount.c
@@ -162,6 +162,10 @@ err:
 
 /* Check if there is something important in the utab file. The parsed utab is
  * stored in context->utab and deallocated by mnt_free_context().
+ *
+ * This function exists to avoid (if possible) /proc/self/mountinfo usage, so
+ * don't use thigs like mnt_resolve_target(), mnt_context_get_mtab() etc here.
+ * See lookup_umount_fs() for more details.
  */
 static int has_utab_entry(struct libmnt_context *cxt, const char *target)
 {