send-email: refactor sendemail.smtpencryption config parsing

With the removal of the support for sendemail.smtpssl in the preceding
commit the parsing of sendemail.smtpencryption is no longer special,
and can by moved to %config_settings.

This gets us rid of an unconditional call to Git::config(), which as
we'll see in subsequent commits matters for startup performance.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/git-send-email.perl b/git-send-email.perl
index 9a1a4898e36500953fc1e5fd1214de23c317643b..e2fe112aa50ec6b0bf5d2c00226661cc27b9e9c0 100755 (executable)
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -287,6 +287,7 @@ my %config_bool_settings = (
 );
 
 my %config_settings = (
+    "smtpencryption" => \$smtp_encryption,
     "smtpserver" => \$smtp_server,
     "smtpserverport" => \$smtp_server_port,
     "smtpserveroption" => \@smtp_server_options,
@@ -387,14 +388,6 @@ sub read_config {
                        $$target = $v;
                }
        }
-
-       if (!defined $smtp_encryption) {
-               my $setting = "$prefix.smtpencryption";
-               my $enc = Git::config(@repo, $setting);
-               return unless defined $enc;
-               return if $configured->{$setting}++;
-               $smtp_encryption = $enc;
-       }
 }
 
 # sendemail.identity yields to --identity. We must parse this