more: fix setuid/setgid order

The rule is pretty simple, always use setgid() before setuid().

Reported-by: Jan Pazdziora <jpazdziora@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/text-utils/more.c b/text-utils/more.c
index ee42dffb9bc32a2e650ebd0858fb686b10899a33..3cb2ca3af38803d0a2948b5ea2aa44070d7c94fc 100644 (file)
--- a/text-utils/more.c
+++ b/text-utils/more.c
@@ -1250,10 +1250,10 @@ static void execute(struct more_control *ctl, char *filename, char *cmd, ...)
                va_end(argp);
 
                if (geteuid() != getuid() || getegid() != getgid()) {
-                       if (setuid(getuid()) < 0)
-                               err(EXIT_FAILURE, _("setuid failed"));
                        if (setgid(getgid()) < 0)
                                err(EXIT_FAILURE, _("setgid failed"));
+                       if (setuid(getuid()) < 0)
+                               err(EXIT_FAILURE, _("setuid failed"));
                }
 
                execvp(cmd, args);