]> git.ipfire.org Git - people/stevee/pakfire.git/commitdiff
file: Correctly fail PIE test
authorMichael Tremer <michael.tremer@ipfire.org>
Wed, 15 Mar 2023 10:48:20 +0000 (10:48 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 15 Mar 2023 10:48:20 +0000 (10:48 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/libpakfire/file.c

index 3701aecb0a34421d230b617fd760930f0d38d64f..99130a4b3ac86b577508328cb547cf836483a750 100644 (file)
@@ -1761,12 +1761,15 @@ static int pakfire_file_hardening_check_pie(struct pakfire_file* file) {
        switch (pakfire_file_get_elf_type(file)) {
                // Shared Object files are good
                case ET_DYN:
-                       return 0;
+                       break;
 
                // Everything else is bad
                default:
-                       return 1;
+                       file->hardening_issues |= PAKFIRE_FILE_NO_PIE;
+                       break;
        }
+
+       return 0;
 }
 
 static int __pakfire_file_hardening_check_execstack(